Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [VisBuilder] Adds UIState to vis, adds index patterns to embeddable, bug fixes #3874

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ee32d20 from #3751.

…bug fixes (#3751)

* adds uiActions to visBuilder
* prevents multiple errors on load
* fixes visbuilder type errors
* fixes save
* adds ui state to vis builder
* fixes tests
* Adds support in embeddables for multiple indices
* Moves ui state to separate slice
* Adds changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit ee32d20)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 18, 2023 00:50
Signed-off-by: Josh Romero <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #3874 (d850c8e) into 2.x (eb0a315) will decrease coverage by 0.04%.
The diff coverage is 27.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3874      +/-   ##
==========================================
- Coverage   66.47%   66.44%   -0.04%     
==========================================
  Files        3226     3227       +1     
  Lines       61975    62014      +39     
  Branches     9583     9588       +5     
==========================================
+ Hits        41199    41205       +6     
- Misses      18479    18510      +31     
- Partials     2297     2299       +2     
Flag Coverage Δ
Linux 66.38% <27.27%> (-0.04%) ⬇️
Windows 66.39% <27.27%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lder/common/vis_builder_saved_object_attributes.ts 100.00% <ø> (ø)
...uilder/public/application/components/right_nav.tsx 12.50% <ø> (ø)
...uilder/public/application/components/workspace.tsx 5.26% <0.00%> (-1.19%) ⬇️
...plication/utils/state_management/metadata_slice.ts 61.53% <ø> (ø)
...cation/utils/state_management/redux_persistence.ts 80.00% <ø> (ø)
...public/application/utils/state_management/store.ts 18.75% <ø> (ø)
...application/utils/use/use_saved_vis_builder_vis.ts 2.77% <0.00%> (-0.26%) ⬇️
...ilder/public/embeddable/vis_builder_embeddable.tsx 0.91% <0.00%> (-0.11%) ⬇️
...blic/embeddable/vis_builder_embeddable_factory.tsx 8.69% <0.00%> (-2.42%) ⬇️
..._builder/public/saved_visualizations/_saved_vis.ts 0.00% <ø> (ø)
... and 4 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr merged commit 0ae76d2 into 2.x Apr 18, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-3751-to-2.x branch April 18, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants