Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading spinner SVG #386

Closed
wants to merge 5 commits into from
Closed

Add loading spinner SVG #386

wants to merge 5 commits into from

Conversation

kgcreative
Copy link
Member

Description

  • add loading spinner svg and remove horizontal bar loading indicator

Issues Resolved

solves line item: OpenSearch mark loading spinner in #372

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed 20f9c8d
Run ./dev-tools/signoff-check.sh remotes/origin/main 20f9c8d978c2746988d6f2f2e82c94538a593c84 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed 3105bbe
Run ./dev-tools/signoff-check.sh remotes/origin/main 3105bbe1179e847889e2ccd03b60f6091d85d1e2 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@mihirsoni
Copy link
Contributor

@kgcreative Could you sign your commits ?

@kgcreative
Copy link
Member Author

@kgcreative Could you sign your commits ?

Yep - I might close this PR and open a new one because I somehow messed up the rebase on local (yay git)

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed f490899
Run ./dev-tools/signoff-check.sh remotes/origin/main f49089901023293cae4725463762884ff26f4078 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@kgcreative
Copy link
Member Author

kgcreative commented May 27, 2021

Closing PR -- will open new one, properly signed.

New PR: #387

@kgcreative kgcreative closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants