Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable datasource from cypress test workflow #3845

Closed
wants to merge 1 commit into from
Closed

Disable datasource from cypress test workflow #3845

wants to merge 1 commit into from

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Apr 13, 2023 •
edited
Loading

Description

Disable datasource from cypress test workflow

Issues Resolved

#3843

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@zhongnansu zhongnansu changed the title Add support for Cypress datasource management in cypress_workflow.yml [Multiple DataSource]Add support for Cypress datasource management in cypress_workflow.yml Apr 13, 2023
@zhongnansu zhongnansu changed the title [Multiple DataSource]Add support for Cypress datasource management in cypress_workflow.yml [Multiple DataSource]Enable datasource feature from cypress workflow Apr 13, 2023
@zhongnansu zhongnansu linked an issue Apr 13, 2023 that may be closed by this pull request
[BUG][MD] Cypress tests for multiple datasource are failing #3843
Closed
@zhongnansu zhongnansu changed the title [Multiple DataSource]Enable datasource feature from cypress workflow Enable datasource feature from cypress workflow Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023 •
edited
Loading

Codecov Report

Merging #3845 (46f4484) into main (4e14aae) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3845   +/-   ##
=======================================
  Coverage   66.41%   66.42%           
=======================================
  Files        3209     3209           
  Lines       61732    61732           
  Branches     9533     9533           
=======================================
+ Hits        41002    41008    +6     
+ Misses      18442    18438    -4     
+ Partials     2288     2286    -2
Flag Coverage Δ
Linux 66.37% <ø> (+<0.01%) ⬆️
Windows 66.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhongnansu zhongnansu closed this Apr 14, 2023
@zhongnansu zhongnansu force-pushed the enable-datasource-for-cypress branch from 9814429 to 4e14aae Compare April 14, 2023 00:27
@zhongnansu zhongnansu reopened this Apr 14, 2023
@zhongnansu zhongnansu changed the title Enable datasource feature from cypress workflow Disable datasource from cypress test workflow Apr 14, 2023
@zhongnansu zhongnansu mentioned this pull request Apr 14, 2023
Closed
@zhongnansu zhongnansu marked this pull request as ready for review April 14, 2023 00:56
@zhongnansu zhongnansu marked this pull request as draft April 14, 2023 01:08
@zhongnansu zhongnansu removed multiple datasource multiple datasource project v2.7.0 labels Apr 14, 2023
@zhongnansu zhongnansu closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq will be requested when the pull request is marked ready for review curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT will be requested when the pull request is marked ready for review BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba will be requested when the pull request is marked ready for review xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi will be requested when the pull request is marked ready for review zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 will be requested when the pull request is marked ready for review LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi will be requested when the pull request is marked ready for review virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli will be requested when the pull request is marked ready for review sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 will be requested when the pull request is marked ready for review joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo will be requested when the pull request is marked ready for review huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG][MD] Cypress tests for multiple datasource are failing
2 participants
@zhongnansu @codecov-commenter