Command with query parameter reports unrecognized parameter in DevTools

[Hailong-am]

Description

check whether the command has a query parameter or not first, if it has, then append &pretty=true instead of?pretty=true

Issues Resolved

#3812

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov-commenter]

Codecov Report

Merging #3813 (d3d3418) into main (be47d9a) will increase coverage by 0.00%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3813   +/-   ##
=======================================
  Coverage   66.41%   66.42%           
=======================================
  Files        3209     3209           
  Lines       61730    61732    +2     
  Branches     9533     9533           
=======================================
+ Hits        41000    41004    +4     
+ Misses      18442    18440    -2     
  Partials     2288     2288           

Flag	Coverage Δ
Linux	66.36% <80.00%> (+<0.01%)	⬆️
Windows	66.37% <80.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../server/routes/api/console/proxy/create_handler.ts	69.76% <80.00%> (+1.47%)	⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[zhongnansu]

Thanks @Hailong-am for submitting the issue and post PR to fix!

What do you think of rewriting this toUrlPath() function to the below code? I think this will handle most corner cases.

function toUrlPath(path: string) {
  const FAKE_BASE = 'http://localhost';
  const urlWithFakeBase = new URL(`${FAKE_BASE}/${trimStart(path, '/')}`);
  // Appending pretty here to have OpenSearch do the JSON formatting, as doing
  // in JS can lead to data loss (7.0 will get munged into 7, thus losing indication of
  // measurement precision)
  if (!urlWithFakeBase.searchParams.get('pretty')) {
    urlWithFakeBase.searchParams.append('pretty', 'true');
  }
  const urlPath = urlWithFakeBase.href.replace(urlWithFakeBase.origin, '');
  return urlPath;
}

[Hailong-am]

this looks much better and clear, update the change by your suggestion.

[zhongnansu]

Thanks for the change, lgtm!

[zhongnansu]

@kristenTian would you give a second review?

[manasvinibs]

LGTM. Will wait for windows CI check failures to pass before merging.