Command with query parameter reports unrecognized parameter in DevTools #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3813 +/- ##
=======================================
Coverage 66.41% 66.42%
=======================================
Files 3209 3209
Lines 61730 61732 +2
Branches 9533 9533
=======================================
+ Hits 41000 41004 +4
+ Misses 18442 18440 -2
Partials 2288 2288
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshuarrrr
changed the title
zhongnansu
reviewed
Apr 10, 2023
Comment on lines
78
to
82
| if (urlPath.includes('?')) { | ||
| urlPath += '&pretty=true'; | ||
| } else { | ||
| urlPath += '?pretty=true'; | ||
| } |
There was a problem hiding this comment.
Thanks @Hailong-am for submitting the issue and post PR to fix!
What do you think of rewriting this toUrlPath() function to the below code? I think this will handle most corner cases.
function toUrlPath(path: string) {
const FAKE_BASE = 'http://localhost';
const urlWithFakeBase = new URL(`${FAKE_BASE}/${trimStart(path, '/')}`);
// Appending pretty here to have OpenSearch do the JSON formatting, as doing
// in JS can lead to data loss (7.0 will get munged into 7, thus losing indication of
// measurement precision)
if (!urlWithFakeBase.searchParams.get('pretty')) {
urlWithFakeBase.searchParams.append('pretty', 'true');
}
const urlPath = urlWithFakeBase.href.replace(urlWithFakeBase.origin, '');
return urlPath;
}
There was a problem hiding this comment.
this looks much better and clear, update the change by your suggestion.
zhongnansu
added
Skip-Changelog
Signed-off-by: Hailong Cui <[email protected]>
zhongnansu
approved these changes
Apr 11, 2023
|
@kristenTian would you give a second review? |
zhongnansu
removed
the
Skip-Changelog
manasvinibs
approved these changes
Apr 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit e12ae0b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
joshuarrrr
pushed a commit
that referenced
this pull request
Apr 12, 2023
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit e12ae0b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…ject#3813) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: David Sinclair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check whether the command has a query parameter or not first, if it has, then append
&pretty=trueinstead of?pretty=trueIssues Resolved
#3812
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr