-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCI] Replace node
with scripts/use_node
in functional tests
#3783
[CCI] Replace node
with scripts/use_node
in functional tests
#3783
Conversation
Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3783 +/- ##
=======================================
Coverage 66.41% 66.42%
=======================================
Files 3209 3209
Lines 61732 61732
Branches 9533 9533
=======================================
+ Hits 41002 41004 +2
+ Misses 18442 18441 -1
+ Partials 2288 2287 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
node
with scripts/use_node
node
with scripts/use_node
in functional tests
@andreymyssak Thanks for the PR - this looks like a useful addition. I updated the PR title to clarify what I understand this change to do, which is updating all the scripts in the functional tests. I believe @kavilla may have also had in mind a campaign for making similar changes in all the other OpenSearch Dashboards plugin repositories (such as https://github.com/opensearch-project/alerting-dashboards-plugin or https://github.com/opensearch-project/dashboards-observability), but it's a great start to update all the usages in OpenSearch Dashboard first. |
Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]>
c524293
to
4c87c16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-3783-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f890e98f1af903a10b07ccb48065a9c843da990
# Push it to GitHub
git push --set-upstream origin backport/backport-3783-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3783-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f890e98f1af903a10b07ccb48065a9c843da990
# Push it to GitHub
git push --set-upstream origin backport/backport-3783-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3783-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f890e98f1af903a10b07ccb48065a9c843da990
# Push it to GitHub
git push --set-upstream origin backport/backport-3783-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
* Replace node with scripts/use_node (#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Update CHANGELOG.md (#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 8f890e9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-3783-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f890e98f1af903a10b07ccb48065a9c843da990
# Push it to GitHub
git push --set-upstream origin backport/backport-3783-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3783-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f890e98f1af903a10b07ccb48065a9c843da990
# Push it to GitHub
git push --set-upstream origin backport/backport-3783-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3 Then, create a pull request where the |
…) (#3881) * Replace node with scripts/use_node (#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Update CHANGELOG.md (#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 8f890e9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…) (#3881) * Replace node with scripts/use_node (#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Update CHANGELOG.md (#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 8f890e9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 6796992) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…) (#3881) (#3892) * Replace node with scripts/use_node (#3719) * Update CHANGELOG.md (#3719) --------- (cherry picked from commit 8f890e9) # Conflicts: # CHANGELOG.md (cherry picked from commit 6796992) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nsearch-project#3783) * Replace node with scripts/use_node (opensearch-project#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Update CHANGELOG.md (opensearch-project#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: David Sinclair <[email protected]>
…nsearch-project#3783) * Replace node with scripts/use_node (opensearch-project#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Update CHANGELOG.md (opensearch-project#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 8f890e9)
…) (#3970) * Replace node with scripts/use_node (#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Update CHANGELOG.md (#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 8f890e9) Co-authored-by: Andrey Myssak <[email protected]> (cherry picked from commit 501ba8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nsearch-project#3783) (opensearch-project#3970) * Replace node with scripts/use_node (opensearch-project#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Update CHANGELOG.md (opensearch-project#3719) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 8f890e9) Co-authored-by: Andrey Myssak <[email protected]>
Relabeling for 1.3.11, as backports weren't completed in time for 1.3.10. |
not backportable to 1.x/1.3 |
Description
Replace
node
withscripts/use_node
Issues Resolved
partially #3719
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr