Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature anywhere] Add annotation click handler #3777

Merged
merged 16 commits into from
May 22, 2023
Merged

[Feature anywhere] Add annotation click handler #3777

merged 16 commits into from
May 22, 2023

Commits on Apr 4, 2023

  1. added interaction handling 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    edab515 View commit details
    Browse the repository at this point in the history

  2. fixed lint errors 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5fca51a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. fixed unit tests 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0fe8e82 View commit details
    Browse the repository at this point in the history

  2. fixed unit test 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    325c9fc View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. addressed comments 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    09d6cbb View commit details
    Browse the repository at this point in the history

  2. updated test constants 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    e4921c6 View commit details
    Browse the repository at this point in the history

  3. unit test for addPointInTimeInteractionsConfig 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    4cfdca4 View commit details
    Browse the repository at this point in the history

  4. addressed PR comments 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    5912441 View commit details
    Browse the repository at this point in the history

  5. addressed PR comments 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    76d8744 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge remote-tracking branch 'origin/feature/feature-anywhere' into a… 

    …dd-annotation-click-handler
    @amsiglan
    amsiglan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e469fe9 View commit details
    Browse the repository at this point in the history

  2. refactored to use event bus for notifying click on annotation 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ed817b2 View commit details
    Browse the repository at this point in the history

  3. added framework for invoking flyout, tooltip 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    a53f8ab View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. using signals to listen for events on point annotation 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed May 17, 2023
    Configuration menu
    Copy the full SHA
    618ef27 View commit details
    Browse the repository at this point in the history

  2. updated test constant 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed May 17, 2023
    Configuration menu
    Copy the full SHA
    4669fca View commit details
    Browse the repository at this point in the history

  3. simplified logic to only include click event 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed May 17, 2023
    Configuration menu
    Copy the full SHA
    67cc5f5 View commit details
    Browse the repository at this point in the history

  4. removed unused code 

    Signed-off-by: Amardeepsingh Siglani <[email protected]>
    @amsiglan
    amsiglan committed May 17, 2023
    Configuration menu
    Copy the full SHA
    6d9b9b4 View commit details
    Browse the repository at this point in the history