Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Fix] VisType switching persistence and selectively show warning #3760

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2db2c43 from #3715.

* Refactor persistnece for simpler logic

Signed-off-by: Ashwin Pc <[email protected]>

* renamed files

Signed-off-by: Ashwin Pc <[email protected]>

* only show warning when dropping fields

Signed-off-by: Ashwin P Chandran <[email protected]>

* delete unnecessary tests

Signed-off-by: Ashwin P Chandran <[email protected]>

* addresses PR feedback

Signed-off-by: Ashwin P Chandran <[email protected]>

* Fixes comparison

---------

Signed-off-by: Ashwin Pc <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 2db2c43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 31, 2023 21:52
@codecov-commenter
Copy link

Codecov Report

Merging #3760 (46771fb) into 2.x (c731e7c) will decrease coverage by 0.07%.
The diff coverage is 59.57%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3760      +/-   ##
==========================================
- Coverage   66.46%   66.39%   -0.07%     
==========================================
  Files        3209     3209              
  Lines       61610    61617       +7     
  Branches     9504     9512       +8     
==========================================
- Hits        40948    40912      -36     
- Misses      18386    18421      +35     
- Partials     2276     2284       +8     
Flag Coverage Δ
Linux 66.39% <59.57%> (-0.01%) ⬇️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uilder/public/application/components/right_nav.tsx 8.69% <0.00%> (-2.42%) ⬇️
...plication/utils/state_management/shared_actions.ts 100.00% <ø> (ø)
...blic/application/utils/get_persisted_agg_params.ts 84.84% <84.84%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashwin-pc ashwin-pc self-assigned this Apr 3, 2023
@ashwin-pc ashwin-pc added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Apr 3, 2023
@ashwin-pc
Copy link
Member

Cypress tests for this will fail until the backport is merged in the functional testing repo. So not fail the other CI workflows that are being backported, that test will only be merged after this one.

Ref Functional test backport: opensearch-project/opensearch-dashboards-functional-test#601

@ashwin-pc ashwin-pc merged commit 5405561 into 2.x Apr 4, 2023
@github-actions github-actions bot deleted the backport/backport-3715-to-2.x branch April 4, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants