Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [CCI] Fix type errors in i18n #3750

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport fd61f7a from #3629.

* Changes related to i18n configs
* Added changes to missed commits and also added tasks Listr interface to common source
* Update imports for other files that using ListrContext interface

Signed-off-by: Alexei Karikov <[email protected]>

---------

Signed-off-by: Alexei Karikov <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit fd61f7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 30, 2023 23:38
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #3750 (960350b) into 2.x (6754c4d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3750   +/-   ##
=======================================
  Coverage   66.45%   66.46%           
=======================================
  Files        3209     3209           
  Lines       61610    61610           
  Branches     9504     9504           
=======================================
+ Hits        40946    40948    +2     
+ Misses      18387    18386    -1     
+ Partials     2277     2276    -1     
Flag Coverage Δ
Linux 66.40% <100.00%> (+<0.01%) ⬆️
Windows 66.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dev/i18n/integrate_locale_files.ts 76.81% <ø> (ø)
src/dev/i18n/utils/verify_icu_message.ts 80.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Mar 31, 2023
@ashwin-pc ashwin-pc self-assigned this Apr 3, 2023
@joshuarrrr joshuarrrr merged commit 26ff242 into 2.x Apr 4, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-3629-to-2.x branch April 4, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants