-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an achievement badger to the PR #3721
Add an achievement badger to the PR #3721
Conversation
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
permissions: | ||
pull-requests: write | ||
steps: | ||
- uses: aws-github-ops/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be allowed for the org?
i know in the past if the github action was not explicitly defined at the org wide settings that it will fail (at least for write permissions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its the same as the one thats already applied to OpenSearch
and opensearch-build
repos. They already have this in place and are using it. so i think its safe to assume that it will work
CHANGELOG.md
Outdated
@@ -123,6 +123,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
- Fix detection of Chrome's version on Darwin during CI ([#3296](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3296)) | |||
- Upgrade yarn version to be compatible with @openearch-project/opensearch ([#3443](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3443)) | |||
- [CI] Reduce redundancy by using matrix strategy on Windows and Linux workflows ([#3514](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3514)) | |||
- Adds achievement workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Adds achievement workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721)) | |
- Add an achievement badger to the PR workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721)) |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3721 +/- ##
==========================================
- Coverage 66.45% 66.44% -0.01%
==========================================
Files 3209 3209
Lines 61633 61633
Branches 9506 9506
==========================================
- Hits 40960 40954 -6
- Misses 18396 18400 +4
- Partials 2277 2279 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Adds achievement workflow Signed-off-by: Ashwin P Chandran <[email protected]> * Adds changelog entry Signed-off-by: Ashwin P Chandran <[email protected]> * Update CHANGELOG.md based on suggestion --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: vagimeli <[email protected]>
* Adds achievement workflow Signed-off-by: Ashwin P Chandran <[email protected]> * Adds changelog entry Signed-off-by: Ashwin P Chandran <[email protected]> * Update CHANGELOG.md based on suggestion --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: David Sinclair <[email protected]>
Description
Adding the achievement workflow for PR's
Issues Resolved
#3708
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr