fixing string placement in opensearch_dashboards_overview

[mukatay1]

Description

The goal of this task is to enhance the readability and maintainability of the Overview component in the OpenSearch Dashboards project. By completing this task, the Overview component will be more maintainable, easier to understand, and adhere to the project's coding standards. This will facilitate future development and reduce the likelihood of introducing bugs or regressions.

Issues Resolved

Improved readability and maintainability of the Overview component
#3049

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[ashwin-pc]

@mukatay1 can you fix the lint errors in the code and add a changelog entry for the change?

[mukatay1]

can you fix the lint errors in the code and add a changelog entry for the change?

Hi, yes I can.

[mukatay1]

@mukatay1 can you fix the lint errors in the code and add a changelog entry for the change?

@ashwin-pc @abbyhu2000 Can you please review this pr?

[joshuarrrr]

minor style nits - we prefer the imperative "use" or "fix" over "using" or "fixing". I also updated to be more reflective of the new feature.

Suggested change

	- Fixing string placement in opensearch_dashboards_overview ([#3670](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3670))
	- [Overview] Use branding.applicationTitle as page header ([#3670](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3670))

[mukatay1]

Thank you for your feedback and updates, I'll make sure to use the imperative form and keep the new feature in mind for future responses.

[codecov-commenter]

Codecov Report

Merging #3670 (5b42496) into main (53047b6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3670      +/-   ##
==========================================
- Coverage   66.45%   66.44%   -0.01%     
==========================================
  Files        3209     3209              
  Lines       61633    61634       +1     
  Branches     9506     9507       +1     
==========================================
- Hits        40960    40955       -5     
- Misses      18396    18400       +4     
- Partials     2277     2279       +2     

Flag	Coverage Δ
Linux	66.39% <100.00%> (-0.01%)	⬇️
Windows	66.40% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s_overview/public/components/overview/overview.tsx	58.69% <100.00%> (+0.91%)	⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[abbyhu2000]

I believe we can just utilize the <DefaultMessage> like below. The default is branding.applicationTitle is alreadyOpenSearch Dashboards

title={
          <FormattedMessage
            defaultMessage={branding.applicationTitle}
            id="opensearchDashboardsOverview.header.title"
          />
        }

[abbyhu2000]

@mukatay1 What do you think of the above suggestion? It is aligned with previous application title configuration for the welcome title:

OpenSearch-Dashboards/src/plugins/home/public/application/components/welcome.tsx

Line 237 in 6b42669

defaultMessage={`Welcome to ${branding.applicationTitle}`}

[mukatay1]

Its sounds great

[abbyhu2000]

@mukatay1 Do you think you are able to make changes to the PR based on the suggestions and also rebase this PR?

[joshuarrrr]

@mukatay1 I'm converting this PR to a draft for now - when you have a chance to work on it again, you can take it out of draft mode.