Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCI][#3590]Indicate that IE is no longer supported #3641

Merged
merged 14 commits into from
Apr 13, 2023
Merged

[CCI][#3590]Indicate that IE is no longer supported #3641

merged 14 commits into from
Apr 13, 2023

Conversation

frost017
Copy link
Contributor

@frost017 frost017 commented Mar 21, 2023 •
edited
Loading

Description

Now the language clearly indicates that IE is no longer supported.

Issues Resolved

#3590

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@frost017 frost017 requested a review from a team as a code owner March 21, 2023 13:13
@frost017 frost017 changed the title [#3590]Indicate that IE is no longer supported [CCI][#3590]Indicate that IE is no longer supported Mar 21, 2023
@kavilla kavilla linked an issue Mar 21, 2023 that may be closed by this pull request
Indicate that IE is no longer supported #3590
Closed
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023 •
edited
Loading

Codecov Report

Merging #3641 (62f0c28) into main (ccac24e) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3641   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files        3209     3209           
  Lines       61732    61732           
  Branches     9533     9533           
=======================================
  Hits        40968    40968           
  Misses      18470    18470           
  Partials     2294     2294
Flag Coverage Δ
Linux 66.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/public/chrome/chrome_service.tsx 91.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@frost017
Copy link
Contributor Author

@AMoo-Miki @kavilla I don't get why some tests are failing, just I haven't changed or added logical code

@joshuarrrr joshuarrrr added the OSCI Open Source Contributor Initiative label Mar 22, 2023
@joshuarrrr
Copy link
Member

@frost017 Some of the tests are flaky and need to be re-run. See #3400 and #3376 as examples.

AMoo-Miki
AMoo-Miki previously requested changes Mar 22, 2023
View reviewed changes
src/core/public/chrome/chrome_service.tsx Outdated Show resolved Hide resolved
src/core/public/chrome/chrome_service.tsx Outdated Show resolved Hide resolved
src/core/public/chrome/chrome_service.tsx Outdated Show resolved Hide resolved
frost017 and others added 5 commits March 23, 2023 02:02
@frost017
[opensearch-project#3590]Indicate that IE is no longer supported
a00a8e7 
Signed-off-by: Raiymbek Aiymbet <[email protected]>
@frost017
new entry in CHANGELOG.md
34fe8ba 
Signed-off-by: Raiymbek Aiymbet <[email protected]>
@frost017 @joshuarrrr
Update src/core/public/chrome/chrome_service.tsx
26dbe11 
Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Raiymbek Aiymbet <[email protected]>
@frost017
minor fix
27abfa0 
Signed-off-by: Raiymbek Aiymbet <[email protected]>
@frost017
new default message
2296f30 
Signed-off-by: Raiymbek Aiymbet <[email protected]>
@frost017 frost017 requested review from AMoo-Miki and joshuarrrr and removed request for AMoo-Miki and joshuarrrr March 22, 2023 21:05
@joshuarrrr joshuarrrr mentioned this pull request Mar 23, 2023
Closed
23 tasks
@frost017 frost017 requested review from joshuarrrr and removed request for AMoo-Miki March 24, 2023 15:06
@joshuarrrr
Copy link
Member

@frost017 Don't worry about trying to keep the branch up to date - we'll try and get one completely passing workflow first.

joshuarrrr
joshuarrrr previously approved these changes Apr 11, 2023
View reviewed changes
@joshuarrrr
Copy link
Member

all checks passed prior to changelog conflict resolution.

@joshuarrrr joshuarrrr merged commit 0a83c47 into opensearch-project:main Apr 13, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 13, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 13, 2023
@github-actions @joshuarrrr
[CCI][#3590]Indicate that IE is no longer supported (#3641)
d9ef4cf 
* [#3590]Indicate that IE is no longer supported
* Update src/core/public/chrome/chrome_service.tsx

---------

Signed-off-by: Raiymbek Aiymbet <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 0a83c47)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki pushed a commit that referenced this pull request Apr 15, 2023
@opensearch-trigger-bot @github-actions @joshuarrrr
[Backport 2.x] [CCI][#3590]Indicate that IE is no longer supported (#…
05fccc7 
…3839)

* [CCI][#3590]Indicate that IE is no longer supported (#3641)

* [#3590]Indicate that IE is no longer supported
* Update src/core/public/chrome/chrome_service.tsx

---------

Signed-off-by: Raiymbek Aiymbet <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 0a83c47)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* update changelog

Signed-off-by: Josh Romero <[email protected]>

* update changelog correctly

Signed-off-by: Josh Romero <[email protected]>

* restore changelog and update

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Raiymbek Aiymbet <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@frost017 @joshuarrrr @sikhote
[CCI][opensearch-project#3590]Indicate that IE is no longer supported (…
3ee3f5f 
…opensearch-project#3641)

* [opensearch-project#3590]Indicate that IE is no longer supported
* Update src/core/public/chrome/chrome_service.tsx

---------

Signed-off-by: Raiymbek Aiymbet <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

Assignees

@AMoo-Miki AMoo-Miki

Labels
backport 2.x OSCI Open Source Contributor Initiative v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate that IE is no longer supported
5 participants
@frost017 @codecov-commenter @joshuarrrr @AMoo-Miki @kavilla