Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport][2.6] [Dev] enable opensearch snapshot for Darwin (#3537) #3578

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 9, 2023

Backport 81a5fad from #3537

Enable the downloading of Darwin for running the command
`yarn opensearch snapshot`.

Darwin is not officially supported but snapshots are being
built here:
https://build.ci.opensearch.org/job/distribution-build-opensearch/

Issue resolved:
opensearch-project#2944

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
@kavilla kavilla requested a review from a team as a code owner March 9, 2023 21:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #3578 (d8df9d8) into 2.6 (b15a28f) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.6    #3578      +/-   ##
==========================================
- Coverage   66.45%   66.45%   -0.01%     
==========================================
  Files        3205     3205              
  Lines       61567    61568       +1     
  Branches     9497     9497              
==========================================
- Hits        40915    40914       -1     
- Misses      18381    18383       +2     
  Partials     2271     2271              
Flag Coverage Δ
Linux 66.39% <75.00%> (-0.01%) ⬇️
Windows 66.39% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../public/application/components/aggs/serial_diff.js 18.18% <0.00%> (ø)
packages/osd-opensearch/src/artifact.js 49.07% <100.00%> (+0.31%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr added the not in release PRs backported to already shipped releases with no future release planned label Mar 10, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Josh Romero <[email protected]>
@joshuarrrr joshuarrrr merged commit 339969f into opensearch-project:2.6 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not in release PRs backported to already shipped releases with no future release planned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants