Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Multiple DataSource] Refactor test connection to support SigV4 auth type #3480

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 02e0bc1 from #3456.

Signed-off-by: Su <[email protected]>
(cherry picked from commit 02e0bc1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@zhongnansu zhongnansu requested a review from ananzh February 21, 2023 22:08
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #3480 (7ebd972) into 2.x (1b1477c) will increase coverage by 0.01%.
The diff coverage is 53.57%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3480      +/-   ##
==========================================
+ Coverage   66.43%   66.44%   +0.01%     
==========================================
  Files        3205     3205              
  Lines       61564    61567       +3     
  Branches     9494     9497       +3     
==========================================
+ Hits        40899    40911      +12     
+ Misses      18397    18384      -13     
- Partials     2268     2272       +4     
Flag Coverage Δ
Linux 66.39% <53.57%> (+0.01%) ⬆️
Windows 66.40% <53.57%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/create_form/create_data_source_form.tsx 75.00% <ø> (-0.27%) ⬇️
.../data_source_management/public/components/utils.ts 100.00% <ø> (+4.34%) ⬆️
...rce/components/edit_form/edit_data_source_form.tsx 67.85% <40.00%> (-2.89%) ⬇️
...gins/data_source/server/client/configure_client.ts 71.42% <66.66%> (+24.76%) ⬆️
...ata_source/server/client/configure_client_utils.ts 86.11% <66.66%> (+21.40%) ⬆️
.../plugins/data_source/server/data_source_service.ts 75.00% <100.00%> (+3.57%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 51.31% <0.00%> (-2.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Feb 21, 2023
@kavilla
Copy link
Member

kavilla commented Feb 21, 2023

@zhongnansu for future reference: #3456 (comment)

@zhongnansu zhongnansu merged commit 82c45c1 into 2.x Feb 21, 2023
@github-actions github-actions bot deleted the backport/backport-3456-to-2.x branch February 21, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants