Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x][MD] Support SigV4 as a new auth type of datasource (#3058) #3477

Merged

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Feb 21, 2023

Backport #3058 to branch 2.x

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…ct#3058)

* [Multiple DataSource] Add support for SigV4 authentication

Signed-off-by: Su <[email protected]>
(cherry picked from commit de89c52)
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #3477 (8b407b8) into 2.x (d40da8f) will decrease coverage by 0.13%.
The diff coverage is 40.41%.

❗ Current head 8b407b8 differs from pull request most recent head cc1ee80. Consider uploading reports for the commit cc1ee80 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3477      +/-   ##
==========================================
- Coverage   66.54%   66.42%   -0.13%     
==========================================
  Files        3203     3205       +2     
  Lines       61410    61564     +154     
  Branches     9455     9494      +39     
==========================================
+ Hits        40868    40895      +27     
- Misses      18286    18400     +114     
- Partials     2256     2269      +13     
Flag Coverage Δ
Linux 66.37% <40.41%> (-0.13%) ⬇️
Windows 66.37% <40.41%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugins/data_source/server/client/client_config.ts 100.00% <ø> (ø)
...omponents/validation/datasource_form_validation.ts 75.86% <0.00%> (-24.14%) ⬇️
src/plugins/data_source_management/public/types.ts 100.00% <ø> (ø)
...s_credential_modal/update_aws_credential_modal.tsx 5.26% <5.26%> (ø)
...gins/data_source/server/client/configure_client.ts 46.66% <35.71%> (-19.38%) ⬇️
...rce/components/edit_form/edit_data_source_form.tsx 70.74% <38.35%> (-20.03%) ⬇️
...components/create_form/create_data_source_form.tsx 75.26% <41.66%> (-21.71%) ⬇️
...c/plugins/data_source/server/client/client_pool.ts 46.66% <45.00%> (-12.16%) ⬇️
...ta_source/server/legacy/configure_legacy_client.ts 59.61% <50.00%> (-11.22%) ⬇️
...ata_source/server/client/configure_client_utils.ts 64.70% <64.70%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhongnansu zhongnansu merged commit 1b1477c into opensearch-project:2.x Feb 21, 2023
@@ -3,12 +3,12 @@
* SPDX-License-Identifier: Apache-2.0
*/

import { ApiResponse } from '@opensearch-project/opensearc-next';
import { ApiResponse } from '@opensearch-project/opensearch-next';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, sorry for the typo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants