Add docker dev set up instruction #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbyhu2000
added
docs
abbyhu2000
force-pushed
the
docker-dev-setup-instruction
branch
from
f194730 to
846e04a
Compare
abbyhu2000
force-pushed
the
docker-dev-setup-instruction
branch
2 times, most recently
from
182d342 to
12b9451
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3444 +/- ##
==========================================
- Coverage 66.46% 66.40% -0.06%
==========================================
Files 3205 3205
Lines 61563 61563
Branches 9497 9497
==========================================
- Hits 40915 40881 -34
- Misses 18377 18405 +28
- Partials 2271 2277 +6
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshuarrrr
reviewed
Feb 24, 2023
There was a problem hiding this comment.
Lots of little copyediting suggestions.
I didn't look too deeply at the docker-compose file.
The biggest missing piece is just an intro to the setup guide that helps a user understand what they'll end up with by completing the guide, and enough info to determine if it's useful for them (it assumes Docker, VS Code, etc.)
abbyhu2000
force-pushed
the
docker-dev-setup-instruction
branch
2 times, most recently
from
ebacd34 to
cfd8075
Compare
ananzh
previously approved these changes
Mar 6, 2023
abbyhu2000
force-pushed
the
docker-dev-setup-instruction
branch
2 times, most recently
from
6a17485 to
c770649
Compare
kavilla
reviewed
Mar 8, 2023
kavilla
reviewed
Mar 8, 2023
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
force-pushed
the
docker-dev-setup-instruction
branch
3 times, most recently
from
c483bfa to
875b965
Compare
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
force-pushed
the
docker-dev-setup-instruction
branch
from
875b965 to
2d954da
Compare
Signed-off-by: abbyhu2000 <[email protected]>
kavilla
approved these changes
Mar 10, 2023
|
@abbyhu2000 or anyone who is merging this in. I would make sure the commit when it gets merged a single cohesive commit instead of an automatic squashing for commits. |
ananzh
approved these changes
Mar 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* docker dev set up folder Signed-off-by: abbyhu2000 <[email protected]> * add curl commands to set up and copy the files Signed-off-by: abbyhu2000 <[email protected]> * changelog changes Signed-off-by: abbyhu2000 <[email protected]> * addressing comments Signed-off-by: abbyhu2000 <[email protected]> * add docker link to the developer guide Signed-off-by: abbyhu2000 <[email protected]> * Add notes on docker desktop Signed-off-by: abbyhu2000 <[email protected]> * publish the docker image to docker hub Signed-off-by: abbyhu2000 <[email protected]> * add docker exec as another option Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 7b18e06) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
abbyhu2000
pushed a commit
that referenced
this pull request
Mar 13, 2023
* docker dev set up folder Signed-off-by: abbyhu2000 <[email protected]> * add curl commands to set up and copy the files Signed-off-by: abbyhu2000 <[email protected]> * changelog changes Signed-off-by: abbyhu2000 <[email protected]> * addressing comments Signed-off-by: abbyhu2000 <[email protected]> * add docker link to the developer guide Signed-off-by: abbyhu2000 <[email protected]> * Add notes on docker desktop Signed-off-by: abbyhu2000 <[email protected]> * publish the docker image to docker hub Signed-off-by: abbyhu2000 <[email protected]> * add docker exec as another option Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 7b18e06) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Apr 13, 2023
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
* docker dev set up folder Signed-off-by: abbyhu2000 <[email protected]> * add curl commands to set up and copy the files Signed-off-by: abbyhu2000 <[email protected]> * changelog changes Signed-off-by: abbyhu2000 <[email protected]> * addressing comments Signed-off-by: abbyhu2000 <[email protected]> * add docker link to the developer guide Signed-off-by: abbyhu2000 <[email protected]> * Add notes on docker desktop Signed-off-by: abbyhu2000 <[email protected]> * publish the docker image to docker hub Signed-off-by: abbyhu2000 <[email protected]> * add docker exec as another option Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: David Sinclair <[email protected]>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
* docker dev set up folder Signed-off-by: abbyhu2000 <[email protected]> * add curl commands to set up and copy the files Signed-off-by: abbyhu2000 <[email protected]> * changelog changes Signed-off-by: abbyhu2000 <[email protected]> * addressing comments Signed-off-by: abbyhu2000 <[email protected]> * add docker link to the developer guide Signed-off-by: abbyhu2000 <[email protected]> * Add notes on docker desktop Signed-off-by: abbyhu2000 <[email protected]> * publish the docker image to docker hub Signed-off-by: abbyhu2000 <[email protected]> * add docker exec as another option Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: David Sinclair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the college contributor initiative, add a folder under the root docs folder that includes instruction on using docker to set up the development environment for docker.
Issues Resolved
[List any issues this PR will resolve]
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr