Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 1.x] Gets rid of github-checks-reporter (#3126) #3401

Merged

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Feb 9, 2023

Signed-off-by: Miki [email protected]
(cherry picked from commit 5116f16)

Coming from #3126

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@zhongnansu zhongnansu requested review from AMoo-Miki and a team February 9, 2023 00:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #3401 (92d1d4f) into 1.x (8f8aaa0) will increase coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              1.x    #3401      +/-   ##
==========================================
+ Coverage   67.45%   67.49%   +0.04%     
==========================================
  Files        3044     3044              
  Lines       58696    58696              
  Branches     8902     8902              
==========================================
+ Hits        39591    39615      +24     
+ Misses      16952    16932      -20     
+ Partials     2153     2149       -4     
Flag Coverage Δ
Linux 67.44% <ø> (-0.01%) ⬇️
Windows 67.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (ø)
src/setup_node_env/harden/child_process.js 88.46% <0.00%> (+3.84%) ⬆️
src/dev/build/lib/config.ts 85.29% <0.00%> (+5.88%) ⬆️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/osd-cross-platform/src/path.ts 86.04% <0.00%> (+37.20%) ⬆️
src/dev/build/lib/get_build_number.ts 100.00% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

yarn.lock Outdated Show resolved Hide resolved
tasks/config/run.js Outdated Show resolved Hide resolved
@zhongnansu zhongnansu force-pushed the backport/backport-3126-to-1.x branch from 56891d3 to 2619e70 Compare February 9, 2023 18:35
@zhongnansu zhongnansu force-pushed the backport/backport-3126-to-1.x branch from 2619e70 to 92d1d4f Compare February 9, 2023 19:00
@zhongnansu zhongnansu requested review from AMoo-Miki and a team February 9, 2023 19:03
@joshuarrrr joshuarrrr merged commit 5ad84f9 into opensearch-project:1.x Feb 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 5116f16)

Co-authored-by: Miki <[email protected]>
(cherry picked from commit 5ad84f9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kristenTian pushed a commit that referenced this pull request Feb 16, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 5116f16)

Co-authored-by: Miki <[email protected]>
(cherry picked from commit 5ad84f9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants