Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase feature/feature-anywhere with main #3364

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Feb 1, 2023

Description

Rebasing feature branch with main. Mostly needed for picking up vega-lite v5 PR #3076

AMoo-Miki and others added 30 commits November 30, 2022 15:19
…pensearch-project#2964)

* When updating the timestamps were requested, scanCopy first set the times and then copied content into the destination folder. On certain platforms, copying files into a folder updates its "Last Access Time" and that overwrites the just set timestamps. This PR, makes sure the timestamps are set only after copying the content.

Signed-off-by: Miki <[email protected]>

Signed-off-by: Miki <[email protected]>
…roject#2963)

* Makes `yarn pkg-version` work across platforms

Signed-off-by: Miki <[email protected]>

* Makes `yarn pkg-version` work across platforms

Signed-off-by: Miki <[email protected]>

Signed-off-by: Miki <[email protected]>
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.3...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixes opensearch-project#2996, opensearch-project#2353

- Bump `leaflet-vega` to `^0.9.0` - they merged in our upstream PR and made a release
- Fix the parameter name for passing `vega.parse` options.

Signed-off-by: Miki <[email protected]>
Basic data points
[OSD] 16 submitted PRs (https://github.com/opensearch-project/OpenSearch-Dashboards/pulls/manasvinibs)
[OSD] 74 reviewed PRs (https://github.com/opensearch-project/OpenSearch-Dashboards/issues?q=reviewed-by%3Amanasvinibs)
[OSD] 28 issues involved (https://github.com/opensearch-project/OpenSearch-Dashboards/issues?page=1&q=involves%3Amanasvinibs+is%3Aissue)

Highlight
Mana is assisting with extensions project which will be the next evolution of extending core functionality from OpenSearch Dashboards
Mana implemented opensearch-project#2734 which allows for a huge quality of life for local development for external plugin developers to utilize snapshots with a single CLI command compared to before when they would had to pull down OpenSearch build, install their plugin on OpenSearch, and ensure the proper configurations. This has caused historically problems when plugin teams do development and miss some steps per their onboard documentation/PR suggestion and get different results than expected.
Mana has assisted reviewing PRs providing great insight on BWC tests, BWC in general, and the release process.
Mana has added documentation from insight she has gained within the informal dev doc repo https://cptnb.github.io/opensearch-dashboards-dev-docs/ ensuring the spread of knowledge.

Signed-off-by: Kawika Avilla <[email protected]>

Signed-off-by: Kawika Avilla <[email protected]>
…-project#2896)

* Add global data persistence for vis builder

Persist filters, time range, time refresh interval for vis builder when we
refresh or navigate to other apps such as dashboard, discover, timeline and visualize

Signed-off-by: abbyhu2000 <[email protected]>
…true (opensearch-project#3020)

`no-restricted-paths` compares source files and import statements, and their membership in restricted zones. However, when `allowSameFolder` is true, it failed to remove a trailing slash before validation which results in a false-positive.

Signed-off-by: Miki <[email protected]>

Signed-off-by: Miki <[email protected]>
* test connection intial code

Signed-off-by: mpabba3003 <[email protected]>

* error handling

Signed-off-by: mpabba3003 <[email protected]>

* refactor

Signed-off-by: mpabba3003 <[email protected]>

* removing get cluster info dependency

Signed-off-by: mpabba3003 <[email protected]>

* refactor test connection

Signed-off-by: mpabba3003 <[email protected]>

* adding test cases and test connection on edit datasource

Signed-off-by: mpabba3003 <[email protected]>

* adding changelog comment

Signed-off-by: mpabba3003 <[email protected]>

* fixing bug on edit datasource page

Signed-off-by: mpabba3003 <[email protected]>

* refactor based on PR comments

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
* [Chore] Add 2.4.1 release notes

Signed-off-by: Josh Romero <[email protected]>
…t#2918)

Currently, the new table can not format Url. If we
set to use URL format in index pattern field, table
will display it as string.

In this PR, we switch the format from string to html.
To make html understandable by react as a DOM element,
we use dangerouslySetInnerHTML to transform it. For the
security, since the content is not from random input but
fetched from stored data, we should be safe as long as
data is not messed.

To provide more security protection, we also add dompurify
package to sanitize the html content.

Issue Resolved:
opensearch-project#2905

Signed-off-by: Anan Zhuang <[email protected]>

Signed-off-by: Anan Zhuang <[email protected]>
* Removes manual resolution of `axios`.

Signed-off-by: Tommy Markley <[email protected]>

Signed-off-by: Tommy Markley <[email protected]>
* The minimatch resolution was no longer necessary after the upstream
library that depended on v3.0.4 was removed in opensearch-project#2711.

Signed-off-by: Tommy Markley <[email protected]>

Signed-off-by: Tommy Markley <[email protected]>
Signed-off-by: Kristen Tian <[email protected]>

Signed-off-by: Kristen Tian <[email protected]>
Co-authored-by: Miki <[email protected]>
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ashwin P Chandran <[email protected]>
…oject#3080)

* Update console to use core.http instead of jQuery.ajax

Signed-off-by: Yan Zeng <[email protected]>
…#3051)

* Aligns NOTICE with rules outlined in
opensearch-project/.github#21.
* Adds NOTICE validation to the build and test workflow.
* Fixes product name discrepancies between repository NOTICE file and
the generated NOTICE file for the build.
* Skips template-izing the build and test workflow since that's being
worked on in opensearch-project#2991.

Resolves opensearch-project#765

Signed-off-by: Tommy Markley <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
…h-project#3081)

* readme

Signed-off-by: abbyhu2000 <[email protected]>

* Add readme for current plugin data persistence implementation

Added readme in root level doc folder

Signed-off-by: abbyhu2000 <[email protected]>

* Changelog and minor fixes

Signed-off-by: abbyhu2000 <[email protected]>

* some modifications

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
…Grid (opensearch-project#2863)

* [Table Visualization] Replace table visualization with React and DataGrid

In this PR, we add back functions to make new table usage to
be consistent with the replaced one.
* total function
* percentage column
* filter in/out

Meanwhile, we also add back server. Functional tests are removed.
We will add new functional test in opensearch-dashboards-functional-test
repo. We also clean out some legacy codes.

Issue Resolved:
opensearch-project#2855

Signed-off-by: Anan Zhuang <[email protected]>

* add some data-test-subj and fix PR comments

Signed-off-by: Anan Zhuang <[email protected]>

* Fix PR comments and add unit tests

Signed-off-by: Anan Zhuang <[email protected]>

* remove listenOnChange

Signed-off-by: Anan Zhuang <[email protected]>

Signed-off-by: Anan Zhuang <[email protected]>
dblock and others added 24 commits January 5, 2023 13:52
…e container (opensearch-project#3100)

* connect without container

Signed-off-by: abbyhu2000 <[email protected]>

* Query and filter persistence working

Signed-off-by: abbyhu2000 <[email protected]>

* Rebase and changelog

Signed-off-by: abbyhu2000 <[email protected]>

* Simplify filter management

Signed-off-by: abbyhu2000 <[email protected]>

* change function name

Signed-off-by: abbyhu2000 <[email protected]>

* add unit test for function connect storage to query

Signed-off-by: abbyhu2000 <[email protected]>

* changelog change

Signed-off-by: abbyhu2000 <[email protected]>

* add comments and functional documentation in readme

Signed-off-by: abbyhu2000 <[email protected]>

* add more documentation in data persistence readme about vis builder persistence

Signed-off-by: abbyhu2000 <[email protected]>

* error handling

Signed-off-by: abbyhu2000 <[email protected]>

* add function definition in data plugin api doc

Signed-off-by: abbyhu2000 <[email protected]>

* document and comments

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
* Update json5 to 1.0.2 and 2.2.3

Signed-off-by: Matt Provost <[email protected]>

* Update changelog

Signed-off-by: Matt Provost <[email protected]>

Signed-off-by: Matt Provost <[email protected]>
…rch-project#3076)

* [Chore] Add vega-lite v5 dep and bundle from source

- Add vega-lite@^5.6.0 dependency
- Update webpack config to build `vega-lite` from typescript source to target es5
- Add babel plugin for logical assignment operators
- Selectively import only the vega-lite modules used
- Update vega_parser tests

Co-authored-by: Miki <[email protected]>
Signed-off-by: Josh Romero <[email protected]>

* [Chore] Update vega-lite defaults and tests to v5

- Add test case for older vega-light spec parsing
- Update default schema version in default spec, test specs, mocked saved objects
- Fix indentation of comments in default spec
- Update jest mock imports to use `vega-lite`

Signed-off-by: Josh Romero <[email protected]>

Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
…t#3160)

* [Feature] Allow order control in `createAggConfig`

Add new optional boolean param that adds the new `AggConfig` to the beginning of the array rather than the end.
Makes it easier to work with Pie or other visualizations with `Schemas` that set `mustBeFirst`

Signed-off-by: Josh Romero <[email protected]>

* [Chore] Add changelog

Signed-off-by: Josh Romero <[email protected]>

Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
* Adds field tests

Signed-off-by: Ashwin P Chandran <[email protected]>

* Adds changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

Signed-off-by: Ashwin P Chandran <[email protected]>
…ect#3213)

Remove setting join field even if it is already set.

Signed-off-by: Vijayan Balasubramanian <[email protected]>

Signed-off-by: Vijayan Balasubramanian <[email protected]>
…t#3210)

* fixes table vis for filter aggregation types

Signed-off-by: Ashwin P Chandran <[email protected]>

* Fixes filter and add error boundry

Signed-off-by: Ashwin P Chandran <[email protected]>

* Adds changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

Signed-off-by: Ashwin P Chandran <[email protected]>
* fixes pipeline aggs in visbuilder

Signed-off-by: Ashwin P Chandran <[email protected]>

* adds changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

* Adds unit tests

Signed-off-by: Ashwin P Chandran <[email protected]>

* fixes pipeline aggs in visbuilder

Signed-off-by: Ashwin P Chandran <[email protected]>

* adds changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

* Adds unit tests

Signed-off-by: Ashwin P Chandran <[email protected]>

* fixes unit tests

Signed-off-by: Ashwin P Chandran <[email protected]>

Signed-off-by: Ashwin P Chandran <[email protected]>
* Add v2.5.0 release notes

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* Adds aliased vega-lite v5 dependency to the notes opensearch-project#3151

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* Address feedback comments

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* Add opensearch-project#3197 to notes

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* Address feedback comments

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* Address feedback comments

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* Address feedback comments

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
…earch-project#3251)

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
Signed-off-by: Josh Romero <[email protected]>

Signed-off-by: Josh Romero <[email protected]>
- Add new documentation link
- move from `noDocumentation` to `opensearch`

fixes opensearch-project#2849

Signed-off-by: Josh Romero <[email protected]>
* Removes manual resolution on `qs`. The latest version of `supertest` depends on v6.11.0.
* Adds steps for upgrading `re2`.
* Addresses CVE-2022-24999 (no issue opened)

Signed-off-by: Tommy Markley <[email protected]>

Signed-off-by: Tommy Markley <[email protected]>
…ject#2992)

Enables the configuration of `disablePrototypePoisoningProtection` by setting
`opensearch.disablePrototypePoisoningProtection`. Enables users to store
protected logs that include reserve words from JS without the
OpenSearch JS client throwing errors.

We should still consider transforming unsafe data values if a bad actor
attempts to prototype pollute the cluster.

More information:
https://web.archive.org/web/20200319091159/https://hueniverse.com/square-brackets-are-the-enemy-ff5b9fd8a3e8?gi=184a27ee2a08

Related issue:
opensearch-project#1777

Signed-off-by: Kawika Avilla <[email protected]>

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
This PR only sets up the boilerplate code for the new plugin. The additions of the new saved object type and expression function types will be added in later PRs. Breaking it up for readability purposes.

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler requested a review from a team as a code owner February 1, 2023 20:56
@ohltyler ohltyler changed the title Rebase with main Rebase feature/feature-anywhere with main Feb 1, 2023
@joshuarrrr
Copy link
Member

rebase commit - skippinjg automation completion.

@joshuarrrr joshuarrrr merged commit 2b82edd into opensearch-project:feature/feature-anywhere Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.