[Backport 2.5] [2.x] Add aliased vega-lite v5 dependency and bundle from source #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* [Chore] Add vega-lite v5 dep and bundle from source - Add vega-lite@^5.6.0 dependency, aliased to `vega-lite-next` to maintain backwards compatability for any plugins dependent on v4 - Update webpack config to build `vega-lite-next` from typescript source to target es5 - Add babel plugin for logical assignment operators - Selectively import only the vega-lite modules used - Update vega_parser tests Co-authored-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> * [Chore] Update vega-lite defaults and tests to v5 - Add test case for older vega-light spec parsing - Update default schema version in default spec, test specs, mocked saved objects - Fix indentation of comments in default spec - Update jest mock imports to use `vega-lite-next` Signed-off-by: Josh Romero <[email protected]> * [Chore] Change @babel/plugin-proposal-logical-assignment-operators version - Keep new babel proposal plugin version in sync with other babel plugins Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit ad2cd3a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
added
v2.5.0
Codecov Report
@@ Coverage Diff @@
## 2.5 #3237 +/- ##
==========================================
- Coverage 66.55% 66.49% -0.06%
==========================================
Files 3200 3200
Lines 61295 61295
Branches 9440 9440
==========================================
- Hits 40794 40758 -36
- Misses 18246 18276 +30
- Partials 2255 2261 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
manasvinibs
approved these changes
Jan 10, 2023
joshuarrrr
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ad2cd3a from #3151.