Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Feature] Allow order control in createAggConfig #3219

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b750846 from #3160.

* [Feature] Allow order control in `createAggConfig`

Add new optional boolean param that adds the new `AggConfig` to the beginning of the array rather than the end.
Makes it easier to work with Pie or other visualizations with `Schemas` that set `mustBeFirst`

Signed-off-by: Josh Romero <[email protected]>

* [Chore] Add changelog

Signed-off-by: Josh Romero <[email protected]>

Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
(cherry picked from commit b750846)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 9, 2023 19:23
@manasvinibs manasvinibs added v2.5.0 'Issues and PRs related to version v2.5.0' autocut Skip the changelog verification check on backports labels Jan 9, 2023
@abbyhu2000 abbyhu2000 removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3219 (a4b355b) into 2.x (cd4fa97) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.x    #3219      +/-   ##
==========================================
- Coverage   66.75%   66.71%   -0.05%     
==========================================
  Files        3221     3221              
  Lines       61630    61632       +2     
  Branches     9455     9456       +1     
==========================================
- Hits        41142    41116      -26     
- Misses      18229    18253      +24     
- Partials     2259     2263       +4     
Flag Coverage Δ
Linux ?
Windows 66.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/data/common/search/aggs/agg_configs.ts 73.68% <100.00%> (+0.56%) ⬆️
src/dev/build/lib/get_build_number.ts 57.14% <0.00%> (-42.86%) ⬇️
packages/osd-opensearch/src/artifact.js 34.56% <0.00%> (-14.20%) ⬇️
src/dev/build/lib/config.ts 79.41% <0.00%> (-5.89%) ⬇️
packages/osd-cross-platform/src/path.ts 82.92% <0.00%> (-2.44%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-1.32%) ⬇️
...ared/static/forms/hook_form_lib/hooks/use_field.ts 66.66% <0.00%> (+0.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 9, 2023
@manasvinibs manasvinibs merged commit dd28a5b into 2.x Jan 9, 2023
@github-actions github-actions bot deleted the backport/backport-3160-to-2.x branch January 9, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants