-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual] [Backport 2.x] Automates chromedriver version selection for tests (#2990) #3125
[Manual] [Backport 2.x] Automates chromedriver version selection for tests (#2990) #3125
Conversation
8de7c90
to
efeba57
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #3125 +/- ##
==========================================
- Coverage 66.67% 66.59% -0.08%
==========================================
Files 3219 3219
Lines 61450 61531 +81
Branches 9417 9431 +14
==========================================
+ Hits 40971 40978 +7
- Misses 18232 18308 +76
+ Partials 2247 2245 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Josh for taking care of this.
…t#2990) Signed-off-by: Miki <[email protected]> (cherry picked from commit a26fb43)
efeba57
to
ad391fd
Compare
Not waiting for tests as this has no bearing on them other than installing the correct chromedriver which we know it does. Moreover, all the linux tests are passing. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-3125-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-3125-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.1 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-3125-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.2 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.3 2.3
# Navigate to the new working tree
pushd ../.worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-3125-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-3125-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4 Then, create a pull request where the |
backport a26fb43 from #2990