[Bug]Fix version conflict for plugins #312

ananzh · 2021-04-23T20:30:34Z

Signed-off-by: Anan Zhuang [email protected]

Description

Main branch is on version 1.0.0, but there is a version check expecting 7.9 when building plugins. This PR fixes the issue by revising the version check to unblock plugin build.

Issues Resolved

#309
#224

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

Signed-off-by: Anan Zhuang <[email protected]>

odfe-release-bot · 2021-04-23T20:34:45Z

✅ DCO Check Passed 75a95db

…igger version Signed-off-by: Anan Zhuang <[email protected]>

odfe-release-bot · 2021-04-23T22:10:54Z

✅ DCO Check Passed 723db9c

mihirsoni · 2021-04-23T22:57:11Z

packages/osd-plugin-helpers/src/cli.ts

@@ -94,17 +94,12 @@ export function runCli() {
          plugin
        );

-        if (semver.satisfies(opensearchDashboardsVersion, '<7.9')) {
+        if (semver.satisfies(opensearchDashboardsVersion, '>=2.0.0')) {


For this, we will need to make main to 2.0 right ?

This check is good for 1.x and current main.
If later we have 2.x and main is 2.x, then we need to update here.

this condition means, dashboard version should be >= 2.0.0 is that correct ? our current version is 1.0

Actually we can remove these two condition completely, we are mostly on 7.10 which the issue doesn't persist. @ananzh let's remove it.

Will do. Thanks for providing me the issue link.

Signed-off-by: Anan Zhuang <[email protected]>

odfe-release-bot · 2021-04-24T00:52:15Z

✅ DCO Check Passed 1369fcc

mihirsoni

LGTM !!

ohltyler

LGTM, thanks for the change!

Axis improvements - Hide axis but show gridlines - hide axis titles, labels, ticks and line independently - add inner and outer padding to tick labels - add inner and outer padding to axes titles - transform offsets relative to local reference (i.e. rotated coordinates) - transform offsets relative to global reference - add tick label horizontal and vertical alignment closes opensearch-project#714, opensearch-project#312 BREAKING CHANGE: - `AxisSpec.gridLineStyle` => `AxisSpec.gridLine` - `AxisSpec.gridLineStyle` => `AxisSpec.gridLine` - `AxisSpec.tickLabelRotation` => `AxisStyle.tickLabel.rotation` - `AxisSpec.tickPadding` => `AxisStyle.tickLine.padding` - `AxisSpec.tickSize` => `AxisStyle.tickLine.size` - `AxisStyle.tickLabelPadding` => `AxisStyle.tickLabel.padding` - `GridLineConfig` => `GridLineStyle` - `AxisSpec.style` => `RecursivePartial<AxisStyle>` (new `AxisStyle` type) - `AxisConfig.axisLineStyle` => `AxisStyle.axisLine` - `AxisConfig.axisTitleStyle` => `AxisStyle.axisTitle` - `AxisConfig.tickLabelStyle` => `AxisStyle.tickLabel` - `AxisConfig.tickLineStyle` => `AxisStyle.tickLine` - `GridLineStyle` requires all properties - deprecate `AxisSpec.showGridLines` in favor of `AxisSpec.gridLine.visible`

# [20.0.0](elastic/elastic-charts@v19.9.1...v20.0.0) (2020-07-19) ### Features * **axis:** improved axis styles ([opensearch-project#711](elastic/elastic-charts#711)) ([e736aad](elastic/elastic-charts@e736aad)), closes [opensearch-project#714](elastic/elastic-charts#714) [opensearch-project#312](elastic/elastic-charts#312) ### BREAKING CHANGES * **axis:** - `AxisSpec.gridLineStyle` => `AxisSpec.gridLine` - `AxisSpec.gridLineStyle` => `AxisSpec.gridLine` - `AxisSpec.tickLabelRotation` => `AxisStyle.tickLabel.rotation` - `AxisSpec.tickPadding` => `AxisStyle.tickLine.padding` - `AxisSpec.tickSize` => `AxisStyle.tickLine.size` - `AxisStyle.tickLabelPadding` => `AxisStyle.tickLabel.padding` - `GridLineConfig` => `GridLineStyle` - `AxisSpec.style` => `RecursivePartial<AxisStyle>` (new `AxisStyle` type) - `AxisConfig.axisLineStyle` => `AxisStyle.axisLine` - `AxisConfig.axisTitleStyle` => `AxisStyle.axisTitle` - `AxisConfig.tickLabelStyle` => `AxisStyle.tickLabel` - `AxisConfig.tickLineStyle` => `AxisStyle.tickLine` - `GridLineStyle` requires all properties - deprecate `AxisSpec.showGridLines` in favor of `AxisSpec.gridLine.visible`

…#312) * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add APIs to support plugin state in request (#312) * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: use request app to store request workspace id Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless if Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>

…roject#6303) * feat: add APIs to support plugin state in request (opensearch-project#312) * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: use request app to store request workspace id Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless if Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>

…roject#6303) (opensearch-project#315) * feat: add APIs to support plugin state in request (opensearch-project#312) * feat: add APIs to support plugin state in request * feat: add APIs to support plugin state in request --------- * feat: update CHANGELOG * feat: update * feat: use request app to store request workspace id * feat: remove useless if --------- Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add APIs to support plugin state in request (#312) * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: use request app to store request workspace id Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless if Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit fc3fef2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

* feat: add APIs to support plugin state in request (#312) * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> * feat: add APIs to support plugin state in request Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: use request app to store request workspace id Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless if Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit fc3fef2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Fix version conflix for plugins

75a95db

Signed-off-by: Anan Zhuang <[email protected]>

ananzh added the bug Something isn't working label Apr 23, 2021

ananzh requested review from mihirsoni, tmarkley, kavilla and boktorbb April 23, 2021 20:30

ananzh mentioned this pull request Apr 23, 2021

[BUG] Unable to build plugins using main branch #309

Closed

ananzh added plugins Plugin related work build Build related additions or modifications labels Apr 23, 2021

Give the check a wider version. Then maintaince would be just every b…

723db9c

…igger version Signed-off-by: Anan Zhuang <[email protected]>

mihirsoni reviewed Apr 23, 2021

View reviewed changes

Remove semver version check

1369fcc

Signed-off-by: Anan Zhuang <[email protected]>

mihirsoni approved these changes Apr 24, 2021

View reviewed changes

ohltyler approved these changes Apr 24, 2021

View reviewed changes

seraphjiang approved these changes Apr 24, 2021

View reviewed changes

seraphjiang merged commit b563989 into opensearch-project:main Apr 24, 2021

kavilla pushed a commit that referenced this pull request May 21, 2021

[Bug]Fix version conflict for plugins (#312)

4288668

ananzh deleted the fix_version branch June 21, 2021 01:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]Fix version conflict for plugins #312

[Bug]Fix version conflict for plugins #312

ananzh commented Apr 23, 2021 •

edited

Loading

odfe-release-bot commented Apr 23, 2021

odfe-release-bot commented Apr 23, 2021

mihirsoni Apr 23, 2021

ananzh Apr 23, 2021

mihirsoni Apr 24, 2021

mihirsoni Apr 24, 2021

ananzh Apr 24, 2021

odfe-release-bot commented Apr 24, 2021

mihirsoni left a comment

ohltyler left a comment

[Bug]Fix version conflict for plugins #312

[Bug]Fix version conflict for plugins #312

Conversation

ananzh commented Apr 23, 2021 • edited Loading

Description

Issues Resolved

Check List

odfe-release-bot commented Apr 23, 2021

odfe-release-bot commented Apr 23, 2021

mihirsoni Apr 23, 2021

Choose a reason for hiding this comment

ananzh Apr 23, 2021

Choose a reason for hiding this comment

mihirsoni Apr 24, 2021

Choose a reason for hiding this comment

mihirsoni Apr 24, 2021

Choose a reason for hiding this comment

ananzh Apr 24, 2021

Choose a reason for hiding this comment

odfe-release-bot commented Apr 24, 2021

mihirsoni left a comment

Choose a reason for hiding this comment

ohltyler left a comment

Choose a reason for hiding this comment

ananzh commented Apr 23, 2021 •

edited

Loading