Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create switch to render line charts using vega-lite #3106

Merged
merged 13 commits into from
Feb 21, 2023
Merged

Create switch to render line charts using vega-lite #3106

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d660f1b
initial commit for vega migration
lezzago Dec 15, 2022
f6cd3a2
Cleanup vega implementation
lezzago Dec 19, 2022
e4b160d
fix minor if statement
lezzago Dec 19, 2022
6830c4e
remove log
lezzago Dec 19, 2022
d9bdb50
minor enhancements for robustness
lezzago Dec 20, 2022
62eef08
Update fixes and more robust
lezzago Feb 13, 2023
1dea9df
fix yarn.lock conflicts
lezzago Feb 13, 2023
c94b1b9
Merge branch 'feature/feature-anywhere' of github.com:opensearch-proj…
lezzago Feb 13, 2023
99dd114
Clean up code
lezzago Feb 14, 2023
73a7f81
add additional comments
lezzago Feb 15, 2023
62a5209
add unit tests
lezzago Feb 16, 2023
cff7b4f
add fixes and update tests
lezzago Feb 17, 2023
b1eaaf7
fix test name
lezzago Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions src/plugins/vis_type_vega/public/expressions/line_vega_spec_fn.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/plugins/vis_type_vega/public/expressions/line_vega_spec_fn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ const getXAxisId = (dimensions: any, columns: OpenSearchDashboardsDatatableColum
return columns.filter((column) => column.name === dimensions.x.label)[0].id;
};

const cleanString = (rawString: string): string => {
export const cleanString = (rawString: string): string => {
return rawString.replaceAll('"', '');
};

const formatDataTable = (
export const formatDataTable = (
datatable: OpenSearchDashboardsDatatable
): OpenSearchDashboardsDatatable => {
datatable.columns.forEach((column) => {
Expand All @@ -49,7 +49,7 @@ const formatDataTable = (
return datatable;
};

const createSpecFromDatatable = (
export const createSpecFromDatatable = (
datatable: OpenSearchDashboardsDatatable,
visParams: VisParams,
dimensions: VislibDimensions
Expand Down