Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Add vega-lite v5 dependency and bundle from source #3076

Merged
merged 5 commits into from
Jan 9, 2023
Merged

[Chore] Add vega-lite v5 dependency and bundle from source #3076

merged 5 commits into from
Jan 9, 2023

Commits on Dec 28, 2022

  1. [Chore] Add vega-lite v5 dep and bundle from source 

    - Add vega-lite@^5.6.0 dependency, aliased to `vega-lite-next` to maintain backwards compatability for any plugins dependent on v4
- Update webpack config to build `vega-lite-next` from typescript source to target es5
- Add babel plugin for logical assignment operators
- Selectively import only the vega-lite modules used
- Update vega_parser tests

Co-authored-by: Miki <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
    @joshuarrrr @AMoo-Miki
    joshuarrrr and AMoo-Miki committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    e410fb7 View commit details
    Browse the repository at this point in the history

  2. [Chore] Update vega-lite defaults and tests to v5 

    - Add test case for older vega-light spec parsing
- Update default schema version in default spec, test specs, mocked saved objects
- Fix indentation of comments in default spec
- Update jest mock imports to use `vega-lite-next`

Signed-off-by: Josh Romero <[email protected]>
    @joshuarrrr
    joshuarrrr committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    8dbc4a7 View commit details
    Browse the repository at this point in the history

  3. [Chore] Remove backwards-compatible hacks for main target 

    Signed-off-by: Josh Romero <[email protected]>
    @joshuarrrr
    joshuarrrr committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    1d3823a View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Merge branch 'main' into chore/vega-lite-v5-from-source

    @joshuarrrr
    joshuarrrr authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ad59146 View commit details
    Browse the repository at this point in the history

  2. [Chore] Fix webpack config filter 

    - filter on `vega-lite` instead of aliased `vega-lite-next`
- Keep new babel proposal plugin version in sync with other babel plugins

Signed-off-by: Josh Romero <[email protected]>
    @joshuarrrr
    joshuarrrr committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    289e33c View commit details
    Browse the repository at this point in the history