Add support for CIDR mask filters on IP fields #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirsoni
reviewed
Apr 19, 2021
There was a problem hiding this comment.
Thank you for your PR @micrictor. It would be great if you could create an Issue with details in project and refer it in a PR.
Comment on lines
+194
to
+207
| it('should return true if ip address is valid CIDR string', () => { | ||
| const isValidParams = validateParams('192.168.0.0/24', 'ip'); | ||
| expect(isValidParams).toBe(true); | ||
| }); |
There was a problem hiding this comment.
Could we add UT for passing 192.168.0.0//24
|
✅ DCO Check Passed b17043b |
|
Nice, working for me.
|
kavilla
previously approved these changes
Apr 19, 2021
Signed-off-by: Michael Torres <[email protected]>
|
Pushed in additional sad-path testing for CIDR notation. This PR fixes #306 |
|
✅ DCO Check Passed 5a597fc |
mihirsoni
approved these changes
Apr 21, 2021
kavilla
pushed a commit
that referenced
this pull request
May 21, 2021
Signed-off-by: Michael Torres <[email protected]> Fixes #306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Torres [email protected]
Description
Users of Dashboards will be able to specify CIDR strings as filters against IP fields
Issues Resolved
Issue posted initially against the upstream (Kibana) - elastic/kibana#50520
Users are not able to specify a CIDR netmask when using the filter UI.
Check List