-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify instructions in README #286
Conversation
Added link to the opensearch dev guide. Fixed the URL for the clone to work for OpenSearch Dashboards Signed-off-by: Jonah Kowall <[email protected]>
✅ DCO Check Passed d00df7e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change @jkowall LGTM !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Nits.
Removed "repo" from text and added https to the link Signed-off-by: Jonah Kowall [email protected]
✅ DCO Check Passed 4901475 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
* Clarify instructions Added link to the opensearch dev guide. Fixed the URL for the clone to work for OpenSearch Dashboards Signed-off-by: Jonah Kowall <[email protected]> * Minor README fixed per discussion Removed "repo" from text and added https to the link Signed-off-by: Jonah Kowall [email protected]
* revert unnecessary changes to recently viewed component refactor nav link updater so that the displayed links can be customized, this is majority required by workspace as with workspace, user would be able to config what features(plugins) then want to see for a workspace, this requires to filter out those links that are not configured by the user. Signed-off-by: Yulong Ruan <[email protected]> * fix test snapshot Signed-off-by: Yulong Ruan <[email protected]> * tweak comments Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
* revert unnecessary changes to recently viewed component refactor nav link updater so that the displayed links can be customized, this is majority required by workspace as with workspace, user would be able to config what features(plugins) then want to see for a workspace, this requires to filter out those links that are not configured by the user. Signed-off-by: Yulong Ruan <[email protected]> * fix test snapshot Signed-off-by: Yulong Ruan <[email protected]> * tweak comments Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
Description
Added link to the opensearch dev guide.
Fixed the URL for the clone to work for OpenSearch Dashboards
Signed-off-by: Jonah Kowall [email protected]