[Doc] Correct "help" command to reflect actual behaviour #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Clausen <[email protected]>
Signed-off-by: Patrick Clausen <[email protected]>
Flyingliuhub
previously approved these changes
Nov 7, 2022
|
Thanks @Patrick-Clausen for quick fix. |
ashwin-pc
previously approved these changes
Nov 7, 2022
joshuarrrr
dismissed stale reviews from ashwin-pc, Flyingliuhub, and themself
via
b921f62
joshuarrrr
approved these changes
Nov 22, 2022
ashwin-pc
approved these changes
Nov 22, 2022
joshuarrrr
added
backport 1.x
backport 2.x
v1.3.7
v2.5.0
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
* [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 311fe91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
* [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 311fe91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
This was referenced Nov 29, 2022
joshuarrrr
added a commit
that referenced
this pull request
Nov 29, 2022
…ur (#2942) * [Doc] Correct "help" command to reflect actual behaviour (#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 311fe91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * [Chore] Add changelog Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]>
joshuarrrr
added a commit
that referenced
this pull request
Nov 30, 2022
…ur (#2943) * [Doc] Correct "help" command to reflect actual behaviour (#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 311fe91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * [Chore] Update changelog Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
…ur (#2943) * [Doc] Correct "help" command to reflect actual behaviour (#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 311fe91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * [Chore] Update changelog Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 9b7023f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
added a commit
to joshuarrrr/OpenSearch-Dashboards
that referenced
this pull request
Nov 30, 2022
…ur (opensearch-project#2943) * [Doc] Correct "help" command to reflect actual behaviour (opensearch-project#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 311fe91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * [Chore] Update changelog Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 9b7023f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
added a commit
that referenced
this pull request
Dec 1, 2022
…ur (#2975) * [Backport 1.x] [Doc] Correct "help" command to reflect actual behaviour (#2943) * [Doc] Correct "help" command to reflect actual behaviour (#2810) Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 311fe91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * [Chore] Update changelog Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 9b7023f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [Chore] Update changelog Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Josh Romero <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AlexRuiz7
pushed a commit
to wazuh/wazuh-dashboard
that referenced
this pull request
Dec 14, 2022
…project#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]>
AlexRuiz7
pushed a commit
to wazuh/wazuh-dashboard
that referenced
this pull request
Dec 14, 2022
…project#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
…project#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Sergey Osipov <[email protected]>
Arpit-Bandejiya
pushed a commit
to Arpit-Bandejiya/OpenSearch-Dashboards
that referenced
this pull request
Jan 13, 2023
…project#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Arpit Bandejiya <[email protected]>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…project#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: David Sinclair <[email protected]>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…project#2810) * [Doc] Correct "help" command to reflect actual behaviour Signed-off-by: Patrick Clausen <[email protected]> * Update CHANGELOG.md Signed-off-by: Patrick Clausen <[email protected]> Signed-off-by: Patrick Clausen <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: David Sinclair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Clausen [email protected]
Description
Noticed that the README and "help" command for osd-plugin-helpers don't describe the correct flag for specifying OSD version. The plugin accepts -k, but the README and "help" command describe -v, which is the --verbose flag.
Issues Resolved
Decided not to open issue since its such a small change, but please say if this is needed anyway.
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr