Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Vis Builder] Bug fixes for datasource picker and auto time interval #2765

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7a41d94 from #2632.

…2632)

* Fixes auto time interval

Signed-off-by: Ashwin P Chandran <[email protected]>

* Fixes change datasource while editing agg

Signed-off-by: Ashwin P Chandran <[email protected]>

* Misc fixes

Signed-off-by: Ashwin P Chandran <[email protected]>

* Updates Changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

* Correctly sets timerange

Signed-off-by: Ashwin P Chandran <[email protected]>

* Fixes rebase

Signed-off-by: Ashwin P Chandran <[email protected]>

Signed-off-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 7a41d94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner November 3, 2022 16:19
@codecov-commenter
Copy link

Codecov Report

Merging #2765 (556bf3d) into 2.x (19656d6) will decrease coverage by 0.01%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##              2.x    #2765      +/-   ##
==========================================
- Coverage   66.74%   66.72%   -0.02%     
==========================================
  Files        3210     3211       +1     
  Lines       61266    61284      +18     
  Branches     9360     9362       +2     
==========================================
+ Hits        40891    40892       +1     
- Misses      18128    18146      +18     
+ Partials     2247     2246       -1     
Impacted Files Coverage Δ
...pplication/components/data_tab/use/use_dropbox.tsx 5.97% <0.00%> (+0.33%) ⬆️
...s_builder/public/application/components/option.tsx 0.00% <ø> (ø)
...uilder/public/application/components/workspace.tsx 4.00% <0.00%> (ø)
...public/application/utils/state_management/store.ts 15.00% <ø> (ø)
...tion/utils/state_management/visualization_slice.ts 16.66% <0.00%> (-0.48%) ⬇️
...ilder/public/embeddable/vis_builder_embeddable.tsx 0.98% <0.00%> (-0.01%) ⬇️
...ublic/services/type_service/visualization_type.tsx 100.00% <ø> (ø)
...lder/public/visualizations/metric/to_expression.ts 6.12% <ø> (ø)
.../public/visualizations/vislib/common/create_vis.ts 11.11% <0.00%> (-5.56%) ⬇️
...s_builder/public/application/utils/use/use_aggs.ts 5.88% <5.88%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Nov 3, 2022
@AMoo-Miki AMoo-Miki merged commit af8aaab into 2.x Nov 3, 2022
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Nov 3, 2022
…pensearch-project#2632) (opensearch-project#2765)

* Fixes auto time interval

Signed-off-by: Ashwin P Chandran <[email protected]>

* Fixes change datasource while editing agg

Signed-off-by: Ashwin P Chandran <[email protected]>

* Misc fixes

Signed-off-by: Ashwin P Chandran <[email protected]>

* Updates Changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

* Correctly sets timerange

Signed-off-by: Ashwin P Chandran <[email protected]>

* Fixes rebase

Signed-off-by: Ashwin P Chandran <[email protected]>

Signed-off-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 7a41d94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kavilla kavilla deleted the backport-2632-to-2.x branch November 23, 2022 09:08
@joshuarrrr joshuarrrr added the v2.4.0 'Issues and PRs related to version v2.4.0' label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants