[Backport 2.4] [Save Object Aggregation View] Fix for export all after scroll count response changed in PR#2656 #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…response changed in PR#2656 (opensearch-project#2696) * Fix for filterSavedObjectCounts for namespaceRegistry Signed-off-by: Craig Perkins <[email protected]> * Fix saved_objects_table.test.tsx Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Correct reference to namespacesToInclude Signed-off-by: Craig Perkins <[email protected]> * Use filteredTypeCounts Signed-off-by: Craig Perkins <[email protected]> * Use namespaces similar to types for fetchObjects Signed-off-by: Craig Perkins <[email protected]> * Use _all to represent query for all namespaces Signed-off-by: Craig Perkins <[email protected]> * Pass all registered namespaces Signed-off-by: Craig Perkins <[email protected]> * Switch back signature of scroll_count Signed-off-by: Craig Perkins <[email protected]> * Change countOptions to options Signed-off-by: Craig Perkins <[email protected]> * Use not not instead of in Signed-off-by: Craig Perkins <[email protected]> * Filter namespaces to only include namespace that have been registered Signed-off-by: Craig Perkins <[email protected]> * Add filterQuery with tests Signed-off-by: Craig Perkins <[email protected]> * Update license headers and address review comments Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit d8f66d3)
kristenTian
approved these changes
Nov 2, 2022
AMoo-Miki
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of d8f66d3 from #2696