Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Windows] Facilitate building of OSD and plugins #2647

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Oct 21, 2022

Signed-off-by: Miki [email protected]

Description

[Windows] Facilitate building and running OSD and plugins on Windows platforms (#2601)

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AMoo-Miki AMoo-Miki requested a review from a team as a code owner October 21, 2022 20:57
@AMoo-Miki AMoo-Miki force-pushed the 2.x-windows branch 2 times, most recently from e7a7f87 to 8e8fc00 Compare October 21, 2022 21:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #2647 (dec8e8b) into 2.x (054e550) will decrease coverage by 0.02%.
The diff coverage is 30.55%.

❗ Current head dec8e8b differs from pull request most recent head 97d9592. Consider uploading reports for the commit 97d9592 to get more accurate results

@@            Coverage Diff             @@
##              2.x    #2647      +/-   ##
==========================================
- Coverage   66.78%   66.76%   -0.03%     
==========================================
  Files        3206     3206              
  Lines       61112    61137      +25     
  Branches     9306     9319      +13     
==========================================
+ Hits        40815    40819       +4     
- Misses      18066    18084      +18     
- Partials     2231     2234       +3     
Impacted Files Coverage Δ
src/cli_plugin/install/settings.js 100.00% <ø> (ø)
src/dev/build/args.ts 84.21% <ø> (ø)
src/dev/build/lib/config.ts 79.41% <0.00%> (-2.41%) ⬇️
src/dev/build/lib/fs.ts 20.72% <0.00%> (-3.00%) ⬇️
src/dev/build/lib/platform.ts 100.00% <ø> (ø)
src/dev/build/tasks/nodejs/node_download_info.ts 100.00% <ø> (ø)
packages/osd-utils/src/path/index.ts 56.52% <14.28%> (-18.48%) ⬇️
packages/osd-telemetry-tools/src/tools/utils.ts 63.93% <33.33%> (-0.24%) ⬇️
...rl_forwarding/public/forward_app/normalize_path.ts 66.66% <50.00%> (-33.34%) ⬇️
packages/osd-opensearch/src/artifact.js 48.76% <100.00%> (+0.31%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kristenTian
kristenTian previously approved these changes Oct 21, 2022
@ananzh ananzh merged commit ae79996 into opensearch-project:2.x Oct 24, 2022
@ashwin-pc ashwin-pc changed the title Manually backports Windows changes [Backport 2.x] Manually backports Windows changes Nov 4, 2022
@ashwin-pc ashwin-pc changed the title [Backport 2.x] Manually backports Windows changes [Backport 2.x] [Windows] Facilitate building of OSD and plugins Nov 4, 2022
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Dec 1, 2022
…search-project#2647)

* [Windows] Replaces `rm -rf` with `remove.js`
* [dev/build] Facilitates using zipped archives of node releases
* [div/build] Introduces Windows as a platform
* [dev/build] Corrects cleaning of platform specific build artifacts
* [dev/build] Enhances the cleanup of downloaded node binaries
* [opensearch-dashboards-plugin] Removes prohibition on installing plugins on Windows
* [@osd/utils] Adds a method to standardize path references across platforms
* [dev/build] Standardize paths in tests
* [@osd/telemetry-tools] Normalizes the collection paths
* [plugins/url-forwarding] Fixes the usage of `normalizePath` across node and browser
* [@osd/pm] Allows symlink created for tests without elevated privileges on Windows
* [@osd/opensearch] Allows usage of Windows snapshots in integration tests
* [@osd/opensearch] Employs absolute paths in tests
* [@osd/apm-config-loader] Employs absolute paths in tests
* [core/server] Employs absolute and posix references to paths
* [@osd/optimizer] Standardize paths in tests
* [@osd/tests] Employs absolute paths in tests
* [@osd/pm] Standardize paths in project trees
* [plugins/telemetry] Accommodates the inability of Windows to create unreadable files for testing
* [@osd/config-schema] Normalize paths in tests
* [@osd/plugin-helpers] Standardize paths in tests
* [@osd/plugin-generator] Standardize paths in tests
* [Windows] Update changelog

backport PR: opensearch-project#2601

Signed-off-by: Miki <[email protected]>
@joshuarrrr joshuarrrr added the v2.4.0 'Issues and PRs related to version v2.4.0' label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants