[MD]Address comments from UX sign-off meeting-Datasource list and create page

[yibow98]

Signed-off-by: Yibo Wang [email protected]

Description

Resolve the meta issue for datasource list page and create page from Multi-datasource UX sign off meeting.

Below are screenshots for UX modification:

1. Datasource experimental callout wording:

2. Datasource table column header wording:

3. Datasource listing page delete button refactor:

4. Datasource listing page create button in empty state:

5. Datasource create page spacing between header description and Connection Details:

6. Datasource create page endpoint field placeholder wording:

7. Datasource create page toast that fail to save:

8. Datasource list page fail toast:

Issues Resolved

#2614
#2615
#2616
#2617
#2618
#2619
#2620
#2626

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[KrooshalUX]

1-7 LGTM

In regards to 8 - If a user has not created any data source connections yet, it is incorrect to present an error toast. When working through these use cases with @kristenTian, I believe it was agreed that the danger toast would only be used when there was a server error preventing data source connections to load. Given the timeline, I can mark this for enhancement in 2.5, unless its something you think is a reasonable fix for 2.4.

[yibow98]

1-7 LGTM

#8 - If a user has not created any data source connections yet, it is incorrect to present an error toast. When working through these use cases with @kristenTian, I believe it was agreed that the danger toast would only be used when there was a server error preventing data source connections to load. Given the timeline, I can mark this for enhancement in 2.5, unless its something you think is a reasonable fix for 2.4.

@KrooshalUX Thanks for your comment! The toast will not show up when a user has not created any data source connections. In the screenshot, I just want to show the toast has been changed to danger state. Thus, I first shut down the server and tried to create a datasource, then it showed an error toast. So currently design matches your statement "The danger toast would only be used when there was a server error preventing data source connections to load."

[KrooshalUX]

Upon clarification from @yibow98 , all items 1-8 look good and have UX approval.
Thanks team for your continued efforts!

[yibow98]

Upon clarification from @yibow98 , all items 1-8 look good and have UX approval. Thanks team for your continued efforts!

Thanks @KrooshalUX for your review and all your efforts!

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2625-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fb4bdfa7bfd10878481814862fc794debeac272e
# Push it to GitHub
git push --set-upstream origin backport/backport-2625-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2625-to-2.x.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2625-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fb4bdfa7bfd10878481814862fc794debeac272e
# Push it to GitHub
git push --set-upstream origin backport/backport-2625-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2625-to-2.x.