[MD] Address UX comments on index pattern stack

[kristenTian]

• Update data source column header in index pattern table
• Update index pattern column name to Title
• Remove data source search field error check given it is not required

Signed-off-by: Kristen Tian [email protected]

Description

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[kavilla]

Looks like a snapshot failure?

[KrooshalUX]

LGTM with one slight change - the table column header should not appear sentence case and should read Data Source Connection

[zhongnansu]

lgtm

[codecov-commenter]

Codecov Report

Merging #2611 (430962e) into main (195cc8e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2611   +/-   ##
=======================================
  Coverage   66.78%   66.79%           
=======================================
  Files        3207     3207           
  Lines       61174    61174           
  Branches     9329     9329           
=======================================
+ Hits        40856    40860    +4     
+ Misses      18083    18080    -3     
+ Partials     2235     2234    -1     

Impacted Files	Coverage Δ
...ents/step_data_source/components/header/header.tsx	61.11% <0.00%> (ø)
...ic/application/models/sense_editor/sense_editor.ts	64.88% <0.00%> (ø)
packages/osd-optimizer/src/node/cache.ts	52.77% <0.00%> (+2.77%)	⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	87.75% <0.00%> (+4.08%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[zhongnansu]

@kristenTian can you change the title to something meaningful? So when we squash and merge. The commit message makes sense for user.

[kavilla]

Do we have insight or if this favorable or not?

[kristenTian]

@KrooshalUX requested this change. She mentioned to be consistent with save object management table.

[joshuarrrr]

@kristenTian @KrooshalUX - We discussed in the brainstorming meeting today - the "title" reference in the saved object table is a bit misleading, and "pattern" or "index pattern" is the more accurate term. One potential solution in the future would be to disambiguate the index pattern saved object title from the pattern itself: #2649

[kavilla]

Just blocking for more insight on the Pattern to Title change

[kristenTian]

@kristenTian can you change the title to something meaningful? So when we squash and merge. The commit message makes sense for user.

Done I have included all changes the commit message already. So even with squash, it will be visible to user.

[KrooshalUX]

@kavilla As we were working through all of the interfaces for MDS and working to aligning to established patterns, we determined that Index Pattern tables were inconsistent with the pattern across Dashboards, which is to use "Title", as it also reflects the object API.

[AMoo-Miki]

I would argue that this interface does not show a "title" or even a "pattern"; it is specifically an "index pattern". While creating an index pattern, OSD doesn't ask for a "title" or "pattern"; it asks the user for an "index pattern".

PS, the index pattern creation page incorrectly calls it "Index pattern name" for a field that is really the "index pattern" and is not a name. We will have to fix that separately.

edit: wrote this in a hurry and reading it out loud, i didn't like the tune; rewording it.

[kristenTian]

I would argue that this interface does not show a "title" or even a "pattern"; it is specifically an "index pattern". While creating an index pattern, you don't get to set a "name" or "title"; you only get to set an "index pattern".

PS, the index pattern creation page incorrectly calls it "Index pattern name" for a field that is really the "index pattern" and is not a name. We will have to fix that separately.

This make sense to me, however still requires a further alignment on UX. Given the PR contains other small issues to address, I will revert the column title change for now and address it in a separate PR.

[KrooshalUX]

We can move forward without the change to Pattern / Title - given the discussion around naming, APIs and table patterns that needs to happen at a larger scale.

Reverted the title change

[zhongnansu]

lgtm

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2611-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 189cf81a185f59a934d4d593206f7a115ebbd399
# Push it to GitHub
git push --set-upstream origin backport/backport-2611-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2611-to-2.x.