Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update PR template and workflow #261

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 9, 2021

Description

Updated the PR template to be in .github so github can find it and
automatically apply it to all PRs. Also renamed bootstrap_lint
workflow to be more inclusive of the commands and added unit tests
to be ran for PRs.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

n/a

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Updated the PR template to be in .github so github can find it and
automatically apply it to all PRs. Also renamed bootstrap_lint
workflow to be more inclusive of the commands and added unit tests
to be ran for PRs.

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla added the >Fork label Apr 9, 2021
@kavilla kavilla requested review from mihirsoni, boktorbb and ananzh April 9, 2021 18:34
@odfe-release-bot
Copy link

✅   DCO Check Passed 03fa911

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mihirsoni mihirsoni merged commit aaf9ba3 into opensearch-project:main Apr 9, 2021
@kavilla kavilla deleted the github-template-workflow-updates branch April 27, 2021 20:57
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 1, 2024
… objects client (opensearch-project#261)

* feat: consume current workspace in saved objects management and saved objects client

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test for each change

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: update snapshot of unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
… objects client (opensearch-project#261)

* feat: consume current workspace in saved objects management and saved objects client

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test for each change

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: update snapshot of unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants