Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD] Make text content dynamically translated & update unit tests #2570

Merged
merged 3 commits into from
Oct 13, 2022
Merged

[MD] Make text content dynamically translated & update unit tests #2570

merged 3 commits into from
Oct 13, 2022

Conversation

yibow98
Copy link
Contributor

@yibow98 yibow98 commented Oct 13, 2022 •
edited
Loading

Description

  1. Make text content dynamically translated in all files
  2. Update unit test coverage for Create datasource & Data source table.
  3. Remove unit test for experimental callout component for now since it only contains text. Discussed with Ashwin about this in my previous PR (relevant PR: [MD] UX refactor for datasource create page #2501)

Screen Shot 2022-10-13 at 10 42 47 AM

Issues Resolved

#2543
#2566

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yibow98 yibow98 requested a review from a team as a code owner October 13, 2022 17:48
@zhongnansu zhongnansu added multiple datasource multiple datasource project backport 2.x labels Oct 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #2570 (c4d9d10) into main (8e8b89b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
- Coverage   66.74%   66.73%   -0.02%     
==========================================
  Files        3205     3203       -2     
  Lines       60998    60940      -58     
  Branches     9275     9275              
==========================================
- Hits        40712    40666      -46     
+ Misses      18067    18055      -12     
  Partials     2219     2219
Impacted Files Coverage Δ
.../public/components/create_button/create_button.tsx 100.00% <ø> (ø)
...ents/experimental_callout/experimental_callout.tsx 50.00% <ø> (-50.00%) ⬇️
...components/create_form/create_data_source_form.tsx 98.36% <100.00%> (+14.75%) ⬆️
...te_data_source_wizard/components/header/header.tsx 100.00% <100.00%> (ø)
...components/data_source_table/data_source_table.tsx 100.00% <100.00%> (+3.17%) ⬆️
...omponents/validation/datasource_form_validation.ts 100.00% <100.00%> (ø)
...nent/experimental_callout/experimental_callout.tsx
...e_data_source_wizard/create_data_source_wizard.tsx 96.77% <0.00%> (+6.45%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yibow98 yibow98 requested a review from ashwin-pc October 13, 2022 18:31
@yibow98 yibow98 self-assigned this Oct 13, 2022
@zengyan-amazon zengyan-amazon merged commit 9a55e0c into opensearch-project:main Oct 13, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 13, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 13, 2022
@yibow98 @github-actions
[MD] Make text content dynamically translated & update unit tests (#2570
a4242e7 
)

* Make text content dynamically translated
* add unit tests

Signed-off-by: Yibo Wang <[email protected]>
(cherry picked from commit 9a55e0c)
kavilla pushed a commit that referenced this pull request Oct 17, 2022
@opensearch-trigger-bot
[MD] Make text content dynamically translated & update unit tests (#2570
b37e7dd 
) (#2571)

* Make text content dynamically translated
* add unit tests

Signed-off-by: Yibo Wang <[email protected]>
(cherry picked from commit 9a55e0c)
@AMoo-Miki AMoo-Miki added i18n Internationalization related Issues and PRs v2.4.0 'Issues and PRs related to version v2.4.0' enhancement New feature or request labels Nov 5, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@yibow98 @sipopo
[MD] Make text content dynamically translated & update unit tests (op…
8dcaadc 
…ensearch-project#2570)

* Make text content dynamically translated
* add unit tests

Signed-off-by: Yibo Wang <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristenTian kristenTian kristenTian approved these changes

@zengyan-amazon zengyan-amazon zengyan-amazon approved these changes

@mpabba3003 mpabba3003 Awaiting requested review from mpabba3003

@noCharger noCharger Awaiting requested review from noCharger

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

Assignees

@yibow98 yibow98

Labels
backport 2.x enhancement New feature or request i18n Internationalization related Issues and PRs multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yibow98 @codecov-commenter @zengyan-amazon @kristenTian @AMoo-Miki @zhongnansu