-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD]Add column service to index pattern & Register data source column #2542
Conversation
src/plugins/data_source_management/public/components/data_source_column/data_source_column.tsx
Outdated
Show resolved
Hide resolved
src/plugins/index_pattern_management/public/service/column_service/column_service.ts
Show resolved
Hide resolved
LGTM, thanks for the additional thinking around the deleted state. For speed to release for 2.4, I will put some notes for the 2.5 release around column organization for the default tag etc. |
Signed-off-by: Kristen Tian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2542 +/- ##
==========================================
- Coverage 66.73% 66.72% -0.01%
==========================================
Files 3201 3202 +1
Lines 60958 60969 +11
Branches 9271 9273 +2
==========================================
+ Hits 40678 40684 +6
- Misses 18062 18067 +5
Partials 2218 2218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2542-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2600196224214fac153c4f0380059bb2a48a8ce7
# Push it to GitHub
git push --set-upstream origin backport/backport-2542-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
) Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]> (cherry picked from commit 2600196)
) (#2558) Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]> (cherry picked from commit 2600196) Co-authored-by: Kristen Tian <[email protected]>
…ensearch-project#2542) Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
Signed-off-by: Kristen Tian [email protected]
Description
Adding data source column to index pattern table.
Issues Resolved
UX mock up:
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr