Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Add experimental callout for index pattern section #2523

Merged

Conversation

yibow98
Copy link
Contributor

@yibow98 yibow98 commented Oct 6, 2022

Signed-off-by: Yibo Wang [email protected]

Description

This PR fixes several issues from opensearch-project/ux#16

Index pattern listing page:
Screen Shot 2022-10-05 at 8 07 54 PM

Index pattern create page-step one:
Screen Shot 2022-10-05 at 8 05 54 PM
Index pattern create page-step two:
Screen Shot 2022-10-05 at 8 06 13 PM
Index pattern create page-step three:
Screen Shot 2022-10-05 at 8 06 38 PM

Issues Resolved

opensearch-project/ux#37
opensearch-project/ux#39
opensearch-project/ux#41
opensearch-project/ux#43

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yibow98 yibow98 requested a review from a team as a code owner October 6, 2022 01:10
@yibow98 yibow98 added v2.4.0 'Issues and PRs related to version v2.4.0' multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements labels Oct 6, 2022
@yibow98 yibow98 force-pushed the index-pattern-experimental-callout branch from b5867bf to 1aa30ea Compare October 6, 2022 01:14
@seraphjiang seraphjiang requested a review from a team October 6, 2022 02:41
@seraphjiang
Copy link
Member

could we add screenshot?

@yibow98
Copy link
Contributor Author

yibow98 commented Oct 6, 2022

could we add screenshot?

Added screenshots for all pages.

@kavilla
Copy link
Member

kavilla commented Oct 6, 2022

Thanks @yibow98, looks like the snapshots need to be updated for tests since they are failing. Which can be done with yarn test:jest -u.

@yibow98 yibow98 force-pushed the index-pattern-experimental-callout branch 2 times, most recently from a8758df to 839a4c4 Compare October 6, 2022 19:17
@yibow98
Copy link
Contributor Author

yibow98 commented Oct 6, 2022

Thanks @yibow98, looks like the snapshots need to be updated for tests since they are failing. Which can be done with yarn test:jest -u.

Thanks @kavilla ! I updated snapshots accordingly.

@yibow98 yibow98 force-pushed the index-pattern-experimental-callout branch from 839a4c4 to 25819fa Compare October 6, 2022 19:31
kristenTian
kristenTian previously approved these changes Oct 6, 2022
@yibow98 yibow98 force-pushed the index-pattern-experimental-callout branch from 25819fa to 723a3fb Compare October 6, 2022 20:53
noCharger
noCharger previously approved these changes Oct 6, 2022
Copy link
Contributor

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kristenTian
kristenTian previously approved these changes Oct 6, 2022
zhongnansu
zhongnansu previously approved these changes Oct 6, 2022
@yibow98 yibow98 force-pushed the index-pattern-experimental-callout branch from 013cc5f to b9ed285 Compare October 10, 2022 18:41
kristenTian
kristenTian previously approved these changes Oct 10, 2022
KrooshalUX
KrooshalUX previously approved these changes Oct 10, 2022
Copy link

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely from UX perspective based on screenshots, lgtm!

ashwin-pc
ashwin-pc previously approved these changes Oct 11, 2022
@yibow98 yibow98 dismissed stale reviews from ashwin-pc, KrooshalUX, and kristenTian via 72c9110 October 11, 2022 00:53
@kristenTian kristenTian merged commit 7777749 into opensearch-project:main Oct 11, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2523-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2523-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2523-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2022
* Add experimental callout for index pattern section

Signed-off-by: Yibo Wang <[email protected]>

* add switch for experimental callout & update snapshots

Signed-off-by: Yibo Wang <[email protected]>

* Update UT

Signed-off-by: Yibo Wang <[email protected]>

Signed-off-by: Yibo Wang <[email protected]>
(cherry picked from commit 7777749)
kristenTian pushed a commit that referenced this pull request Oct 12, 2022
* Add experimental callout for index pattern section

Signed-off-by: Yibo Wang <[email protected]>

* add switch for experimental callout & update snapshots

Signed-off-by: Yibo Wang <[email protected]>

* Update UT

Signed-off-by: Yibo Wang <[email protected]>

Signed-off-by: Yibo Wang <[email protected]>
(cherry picked from commit 7777749)

Co-authored-by: Yibo Wang <[email protected]>
@AMoo-Miki AMoo-Miki added the enhancement New feature or request label Nov 5, 2022
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Dec 1, 2022
…roject#2523) (opensearch-project#2561)

* Add experimental callout for index pattern section

Signed-off-by: Yibo Wang <[email protected]>

* add switch for experimental callout & update snapshots

Signed-off-by: Yibo Wang <[email protected]>

* Update UT

Signed-off-by: Yibo Wang <[email protected]>

Signed-off-by: Yibo Wang <[email protected]>
(cherry picked from commit 7777749)

Co-authored-by: Yibo Wang <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
…roject#2523)

* Add experimental callout for index pattern section

Signed-off-by: Yibo Wang <[email protected]>

* add switch for experimental callout & update snapshots

Signed-off-by: Yibo Wang <[email protected]>

* Update UT

Signed-off-by: Yibo Wang <[email protected]>

Signed-off-by: Yibo Wang <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants