-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] Add experimental callout for index pattern section #2523
[MD] Add experimental callout for index pattern section #2523
Conversation
b5867bf
to
1aa30ea
Compare
...ugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx
Outdated
Show resolved
Hide resolved
...ern_management/public/components/create_index_pattern_wizard/create_index_pattern_wizard.tsx
Outdated
Show resolved
Hide resolved
...ins/index_pattern_management/public/components/experimental_callout/experimental_callout.tsx
Show resolved
Hide resolved
could we add screenshot? |
Added screenshots for all pages. |
Thanks @yibow98, looks like the snapshots need to be updated for tests since they are failing. Which can be done with |
...ins/index_pattern_management/public/components/experimental_callout/experimental_callout.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Yibo Wang <[email protected]>
a8758df
to
839a4c4
Compare
839a4c4
to
25819fa
Compare
Signed-off-by: Yibo Wang <[email protected]>
25819fa
to
723a3fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
013cc5f
to
b9ed285
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely from UX perspective based on screenshots, lgtm!
72c9110
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* Add experimental callout for index pattern section Signed-off-by: Yibo Wang <[email protected]> * add switch for experimental callout & update snapshots Signed-off-by: Yibo Wang <[email protected]> * Update UT Signed-off-by: Yibo Wang <[email protected]> Signed-off-by: Yibo Wang <[email protected]> (cherry picked from commit 7777749)
* Add experimental callout for index pattern section Signed-off-by: Yibo Wang <[email protected]> * add switch for experimental callout & update snapshots Signed-off-by: Yibo Wang <[email protected]> * Update UT Signed-off-by: Yibo Wang <[email protected]> Signed-off-by: Yibo Wang <[email protected]> (cherry picked from commit 7777749) Co-authored-by: Yibo Wang <[email protected]>
…roject#2523) (opensearch-project#2561) * Add experimental callout for index pattern section Signed-off-by: Yibo Wang <[email protected]> * add switch for experimental callout & update snapshots Signed-off-by: Yibo Wang <[email protected]> * Update UT Signed-off-by: Yibo Wang <[email protected]> Signed-off-by: Yibo Wang <[email protected]> (cherry picked from commit 7777749) Co-authored-by: Yibo Wang <[email protected]>
…roject#2523) * Add experimental callout for index pattern section Signed-off-by: Yibo Wang <[email protected]> * add switch for experimental callout & update snapshots Signed-off-by: Yibo Wang <[email protected]> * Update UT Signed-off-by: Yibo Wang <[email protected]> Signed-off-by: Yibo Wang <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
Signed-off-by: Yibo Wang [email protected]
Description
This PR fixes several issues from opensearch-project/ux#16
Index pattern listing page:
Index pattern create page-step one:
Index pattern create page-step two:
Index pattern create page-step three:
Issues Resolved
opensearch-project/ux#37
opensearch-project/ux#39
opensearch-project/ux#41
opensearch-project/ux#43
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr