Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] UX updates on data source page & validation changes #2521

Merged
merged 10 commits into from
Oct 6, 2022

Conversation

mpabba3003
Copy link
Contributor

@mpabba3003 mpabba3003 commented Oct 6, 2022

Description

This PR includes feedback changes received from #2399 & opensearch-project/ux#16

Issues Resolved

opensearch-project/ux#18
opensearch-project/ux#21
opensearch-project/ux#22
opensearch-project/ux#28
opensearch-project/ux#30
opensearch-project/ux#31
opensearch-project/ux#32
opensearch-project/ux#33
opensearch-project/ux#34
opensearch-project/ux#35
opensearch-project/ux#36
#2426
#2489
#2438

SCREENSHOTS

Home.-.OpenSearch.Dashboards.mp4

Update password:

dfg.-.OpenSearch.Dashboards.mp4

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@mpabba3003 mpabba3003 requested a review from a team as a code owner October 6, 2022 00:09
@mpabba3003 mpabba3003 added ux / ui Improvements or additions to user experience, flows, components, UI elements multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 6, 2022
@seraphjiang
Copy link
Member

could we add screenshot

@mpabba3003
Copy link
Contributor Author

could we add screenshot

Added a video

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #2521 (cbd6c84) into main (4095e12) will decrease coverage by 0.02%.
The diff coverage is 89.56%.

@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
- Coverage   66.76%   66.73%   -0.03%     
==========================================
  Files        3201     3201              
  Lines       60943    60946       +3     
  Branches     9258     9266       +8     
==========================================
- Hits        40687    40673      -14     
- Misses      18041    18055      +14     
- Partials     2215     2218       +3     
Impacted Files Coverage Δ
.../public/components/create_button/create_button.tsx 100.00% <ø> (ø)
src/plugins/data_source_management/public/types.ts 100.00% <ø> (ø)
...components/create_form/create_data_source_form.tsx 83.33% <68.96%> (-16.67%) ⬇️
...e_data_source_wizard/create_data_source_wizard.tsx 90.32% <81.25%> (-9.68%) ⬇️
...te_data_source_wizard/components/header/header.tsx 100.00% <100.00%> (ø)
...components/data_source_table/data_source_table.tsx 96.82% <100.00%> (-3.18%) ⬇️
...ent/public/components/text_content/text_content.ts 100.00% <100.00%> (ø)
...omponents/validation/datasource_form_validation.ts 100.00% <100.00%> (ø)
...plugins/management/public/utils/management_item.ts 91.66% <100.00%> (+0.75%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -90,6 +90,7 @@ export interface CreateManagementItemArgs {
title: string;
tip?: string;
order?: number;
showExperimentalBadge?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may consider to support other badge types to make this more generic. e.g. let outer component to optionally pass a badge type.
Not a blocker for this change though.

zengyan-amazon
zengyan-amazon previously approved these changes Oct 6, 2022
@kristenTian
Copy link
Contributor

kristenTian commented Oct 6, 2022

am waiting for tests to pass to approve and merge, could you rebase first due to the changelog conflict?

@mpabba3003
Copy link
Contributor Author

am waiting for tests to pass to approve and merge, could you rebase first due to the changelog conflict?

@kristenTian Tests passed. But got a merge conflict as your PR got merged.

@kristenTian kristenTian merged commit 21a173b into opensearch-project:main Oct 6, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2521-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21a173b6d3e323038eafce121dffae28d0362299
# Push it to GitHub
git push --set-upstream origin backport/backport-2521-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2521-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2521-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21a173b6d3e323038eafce121dffae28d0362299
# Push it to GitHub
git push --set-upstream origin backport/backport-2521-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2521-to-2.x.

yibow98 pushed a commit to yibow98/OpenSearch-Dashboards_Dev that referenced this pull request Oct 7, 2022
…project#2521)

* new ux changes v2.4.0

Signed-off-by: mpabba3003 <[email protected]>

* new UX changes and Validation changed

Signed-off-by: mpabba3003 <[email protected]>

* refactoring duplicate title validation on edit data source

Signed-off-by: mpabba3003 <[email protected]>

* replacing eui toasts with notifications toasts

Signed-off-by: mpabba3003 <[email protected]>

* updating testcases after updating toasts methods

Signed-off-by: mpabba3003 <[email protected]>

* adding change log for data source

Signed-off-by: mpabba3003 <[email protected]>

* adding password validation on update stored password modal

Signed-off-by: mpabba3003 <[email protected]>

* removing un-used text content

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
zhongnansu pushed a commit to zhongnansu/OpenSearch-Dashboards that referenced this pull request Oct 11, 2022
…project#2521)

* new ux changes v2.4.0

Signed-off-by: mpabba3003 <[email protected]>

* new UX changes and Validation changed

Signed-off-by: mpabba3003 <[email protected]>

* refactoring duplicate title validation on edit data source

Signed-off-by: mpabba3003 <[email protected]>

* replacing eui toasts with notifications toasts

Signed-off-by: mpabba3003 <[email protected]>

* updating testcases after updating toasts methods

Signed-off-by: mpabba3003 <[email protected]>

* adding change log for data source

Signed-off-by: mpabba3003 <[email protected]>

* adding password validation on update stored password modal

Signed-off-by: mpabba3003 <[email protected]>

* removing un-used text content

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 21a173b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2022
* new ux changes v2.4.0

Signed-off-by: mpabba3003 <[email protected]>

* new UX changes and Validation changed

Signed-off-by: mpabba3003 <[email protected]>

* refactoring duplicate title validation on edit data source

Signed-off-by: mpabba3003 <[email protected]>

* replacing eui toasts with notifications toasts

Signed-off-by: mpabba3003 <[email protected]>

* updating testcases after updating toasts methods

Signed-off-by: mpabba3003 <[email protected]>

* adding change log for data source

Signed-off-by: mpabba3003 <[email protected]>

* adding password validation on update stored password modal

Signed-off-by: mpabba3003 <[email protected]>

* removing un-used text content

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 21a173b)
kristenTian pushed a commit that referenced this pull request Oct 11, 2022
* new ux changes v2.4.0

Signed-off-by: mpabba3003 <[email protected]>

* new UX changes and Validation changed

Signed-off-by: mpabba3003 <[email protected]>

* refactoring duplicate title validation on edit data source

Signed-off-by: mpabba3003 <[email protected]>

* replacing eui toasts with notifications toasts

Signed-off-by: mpabba3003 <[email protected]>

* updating testcases after updating toasts methods

Signed-off-by: mpabba3003 <[email protected]>

* adding change log for data source

Signed-off-by: mpabba3003 <[email protected]>

* adding password validation on update stored password modal

Signed-off-by: mpabba3003 <[email protected]>

* removing un-used text content

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 21a173b)

Co-authored-by: Manideep Pabba <[email protected]>
@AMoo-Miki AMoo-Miki added the enhancement New feature or request label Nov 5, 2022
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Dec 1, 2022
…project#2521) (opensearch-project#2546)

* new ux changes v2.4.0

Signed-off-by: mpabba3003 <[email protected]>

* new UX changes and Validation changed

Signed-off-by: mpabba3003 <[email protected]>

* refactoring duplicate title validation on edit data source

Signed-off-by: mpabba3003 <[email protected]>

* replacing eui toasts with notifications toasts

Signed-off-by: mpabba3003 <[email protected]>

* updating testcases after updating toasts methods

Signed-off-by: mpabba3003 <[email protected]>

* adding change log for data source

Signed-off-by: mpabba3003 <[email protected]>

* adding password validation on update stored password modal

Signed-off-by: mpabba3003 <[email protected]>

* removing un-used text content

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 21a173b)

Co-authored-by: Manideep Pabba <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
…project#2521)

* new ux changes v2.4.0

Signed-off-by: mpabba3003 <[email protected]>

* new UX changes and Validation changed

Signed-off-by: mpabba3003 <[email protected]>

* refactoring duplicate title validation on edit data source

Signed-off-by: mpabba3003 <[email protected]>

* replacing eui toasts with notifications toasts

Signed-off-by: mpabba3003 <[email protected]>

* updating testcases after updating toasts methods

Signed-off-by: mpabba3003 <[email protected]>

* adding change log for data source

Signed-off-by: mpabba3003 <[email protected]>

* adding password validation on update stored password modal

Signed-off-by: mpabba3003 <[email protected]>

* removing un-used text content

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants