-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] UX updates on data source page & validation changes #2521
[MD] UX updates on data source page & validation changes #2521
Conversation
Signed-off-by: mpabba3003 <[email protected]>
Signed-off-by: mpabba3003 <[email protected]>
...management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
Show resolved
Hide resolved
...management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/text_content/text_content.ts
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/text_content/text_content.ts
Outdated
Show resolved
Hide resolved
..._source_management/public/components/create_data_source_wizard/create_data_source_wizard.tsx
Show resolved
Hide resolved
Signed-off-by: mpabba3003 <[email protected]>
could we add screenshot |
Signed-off-by: mpabba3003 <[email protected]>
Signed-off-by: mpabba3003 <[email protected]>
Added a video |
Signed-off-by: mpabba3003 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2521 +/- ##
==========================================
- Coverage 66.76% 66.73% -0.03%
==========================================
Files 3201 3201
Lines 60943 60946 +3
Branches 9258 9266 +8
==========================================
- Hits 40687 40673 -14
- Misses 18041 18055 +14
- Partials 2215 2218 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: mpabba3003 <[email protected]>
@@ -90,6 +90,7 @@ export interface CreateManagementItemArgs { | |||
title: string; | |||
tip?: string; | |||
order?: number; | |||
showExperimentalBadge?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may consider to support other badge types to make this more generic. e.g. let outer component to optionally pass a badge type.
Not a blocker for this change though.
am waiting for tests to pass to approve and merge, could you rebase first due to the changelog conflict? |
# Conflicts: # CHANGELOG.md
@kristenTian Tests passed. But got a merge conflict as your PR got merged. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2521-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21a173b6d3e323038eafce121dffae28d0362299
# Push it to GitHub
git push --set-upstream origin backport/backport-2521-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2521-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21a173b6d3e323038eafce121dffae28d0362299
# Push it to GitHub
git push --set-upstream origin backport/backport-2521-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…project#2521) * new ux changes v2.4.0 Signed-off-by: mpabba3003 <[email protected]> * new UX changes and Validation changed Signed-off-by: mpabba3003 <[email protected]> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <[email protected]> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <[email protected]> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <[email protected]> * adding change log for data source Signed-off-by: mpabba3003 <[email protected]> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <[email protected]> * removing un-used text content Signed-off-by: mpabba3003 <[email protected]> Signed-off-by: mpabba3003 <[email protected]>
…project#2521) * new ux changes v2.4.0 Signed-off-by: mpabba3003 <[email protected]> * new UX changes and Validation changed Signed-off-by: mpabba3003 <[email protected]> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <[email protected]> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <[email protected]> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <[email protected]> * adding change log for data source Signed-off-by: mpabba3003 <[email protected]> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <[email protected]> * removing un-used text content Signed-off-by: mpabba3003 <[email protected]> Signed-off-by: mpabba3003 <[email protected]> (cherry picked from commit 21a173b)
* new ux changes v2.4.0 Signed-off-by: mpabba3003 <[email protected]> * new UX changes and Validation changed Signed-off-by: mpabba3003 <[email protected]> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <[email protected]> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <[email protected]> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <[email protected]> * adding change log for data source Signed-off-by: mpabba3003 <[email protected]> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <[email protected]> * removing un-used text content Signed-off-by: mpabba3003 <[email protected]> Signed-off-by: mpabba3003 <[email protected]> (cherry picked from commit 21a173b)
* new ux changes v2.4.0 Signed-off-by: mpabba3003 <[email protected]> * new UX changes and Validation changed Signed-off-by: mpabba3003 <[email protected]> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <[email protected]> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <[email protected]> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <[email protected]> * adding change log for data source Signed-off-by: mpabba3003 <[email protected]> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <[email protected]> * removing un-used text content Signed-off-by: mpabba3003 <[email protected]> Signed-off-by: mpabba3003 <[email protected]> (cherry picked from commit 21a173b) Co-authored-by: Manideep Pabba <[email protected]>
…project#2521) (opensearch-project#2546) * new ux changes v2.4.0 Signed-off-by: mpabba3003 <[email protected]> * new UX changes and Validation changed Signed-off-by: mpabba3003 <[email protected]> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <[email protected]> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <[email protected]> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <[email protected]> * adding change log for data source Signed-off-by: mpabba3003 <[email protected]> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <[email protected]> * removing un-used text content Signed-off-by: mpabba3003 <[email protected]> Signed-off-by: mpabba3003 <[email protected]> (cherry picked from commit 21a173b) Co-authored-by: Manideep Pabba <[email protected]>
…project#2521) * new ux changes v2.4.0 Signed-off-by: mpabba3003 <[email protected]> * new UX changes and Validation changed Signed-off-by: mpabba3003 <[email protected]> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <[email protected]> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <[email protected]> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <[email protected]> * adding change log for data source Signed-off-by: mpabba3003 <[email protected]> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <[email protected]> * removing un-used text content Signed-off-by: mpabba3003 <[email protected]> Signed-off-by: mpabba3003 <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
Description
This PR includes feedback changes received from #2399 & opensearch-project/ux#16
Issues Resolved
opensearch-project/ux#18
opensearch-project/ux#21
opensearch-project/ux#22
opensearch-project/ux#28
opensearch-project/ux#30
opensearch-project/ux#31
opensearch-project/ux#32
opensearch-project/ux#33
opensearch-project/ux#34
opensearch-project/ux#35
opensearch-project/ux#36
#2426
#2489
#2438
SCREENSHOTS
Home.-.OpenSearch.Dashboards.mp4
Update password:
dfg.-.OpenSearch.Dashboards.mp4
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr