[MD] Display error toast for create index pattern with data source #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Su <[email protected]>
Signed-off-by: Su <[email protected]>
zhongnansu
assigned kristenTian, zengyan-amazon, mpabba3003 and zhongnansu and unassigned zhongnansu, zengyan-amazon, mpabba3003 and kristenTian
Codecov Report
@@ Coverage Diff @@
## main #2506 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 3201 3201
Lines 60913 60915 +2
Branches 9254 9255 +1
=======================================
+ Hits 40681 40683 +2
Misses 18019 18019
Partials 2213 2213
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
noCharger
approved these changes
Oct 5, 2022
kristenTian
reviewed
Oct 6, 2022
| @@ -199,7 +199,14 @@ export async function getIndices({ | |||
| pattern, | |||
| showAllIndices, | |||
| dataSourceId, | |||
| }).catch(() => []); | |||
| }).catch((error) => { | |||
| // swallow the errors to be backwards compatible with non-data-source use case | |||
There was a problem hiding this comment.
there is also line 103 could use the same :P
There was a problem hiding this comment.
line 103 maps to getIndicesViaSearch which is specifically for CCS use case as a step 2 request. But for CCS it also requires step 1 querying against local cluster. Even we added the same logic to step 2, the code won't be able to reach there, because the error will be thrown at step 1 already. Let's leave as it is.
There was a problem hiding this comment.
My point was the call through search client in getIndicesViaSearch itself could also have error. And it's a different route from the resolve api. But it's not blocking this PR though.
kristenTian
approved these changes
Oct 6, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
…2506) * add error toast for create index pattern with data source Signed-off-by: Su <[email protected]> * update change log Signed-off-by: Su <[email protected]> Signed-off-by: Su <[email protected]> (cherry picked from commit 0e742b9)
kavilla
pushed a commit
that referenced
this pull request
Oct 11, 2022
…2506) (#2526) * add error toast for create index pattern with data source * update change log Signed-off-by: Su <[email protected]> (cherry picked from commit 0e742b9)
pjfitzgibbons
pushed a commit
to pjfitzgibbons/OpenSearch-Dashboards
that referenced
this pull request
Dec 1, 2022
…pensearch-project#2506) (opensearch-project#2526) * add error toast for create index pattern with data source * update change log Signed-off-by: Su <[email protected]> (cherry picked from commit 0e742b9)
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
…pensearch-project#2506) * add error toast for create index pattern with data source Signed-off-by: Su <[email protected]> * update change log Signed-off-by: Su <[email protected]> Signed-off-by: Su <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Su [email protected]
Description
Display error toast for create index pattern with data source.
Make use of the existing toast component instead of swallowing error, we generate the pop-up for data source use case in index pattern
Issues Resolved
#2285
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr