[BUG] Plugin helpers fix related to fs promises module #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: opensearch-project#2485 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
avillk/1.x/fix_plugin_version_bump
branch
from
4cc430a to
322287c
Compare
joshuarrrr
approved these changes
Oct 3, 2022
AMoo-Miki
approved these changes
Oct 3, 2022
|
integ passed locally and unit tests seem to be passing. due to the nature of this, will merge in. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: #2485 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 945cfe6)
kavilla
pushed a commit
that referenced
this pull request
Oct 3, 2022
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: #2485 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 945cfe6)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2486-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 945cfe65ff7042ba27cffd798b6b627e7b89fa5d
# Push it to GitHub
git push --set-upstream origin backport/backport-2486-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins.
Solved by importing promises from fs then using the desired methods.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#2485
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr