New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataSource & dataSourceManagement Readme #2448

Merged

kristenTian merged 1 commit into opensearch-project:main from kristenTian:multiD-rebase6

Oct 4, 2022

Contributor

kristenTian commented Sep 28, 2022 •

edited

Loading

Signed-off-by: Kristen Tian [email protected]

Description

Add dataSource & dataSourceManagement Readme

Issues Resolved

#2436
#2437
#2199
#2158

Check List

Commits are signed per the DCO using --signoff

kristenTian requested a review from a team as a code owner

September 28, 2022 23:47

kristenTian added the multiple datasource label

kristenTian requested review from zengyan-amazon, zhongnansu, noCharger, mpabba3003 and yibow98

September 28, 2022 23:49

Member

zhongnansu commented Sep 28, 2022

#2199
#2158
This PR also resolves these 2. Let's try not to have duplicate issues.

kristenTian requested a review from AMoo-Miki

September 28, 2022 23:55

kristenTian force-pushed the multiD-rebase6 branch 2 times, most recently from be55af1 to ed76bf7 Compare

September 29, 2022 00:07

yibow98 reviewed

View reviewed changes

src/plugins/data_source/README.md Outdated Show resolved Hide resolved

yibow98 reviewed

View reviewed changes

src/plugins/data_source/README.md Outdated Show resolved Hide resolved

yibow98 reviewed

View reviewed changes

src/plugins/data_source_management/README.md Outdated Show resolved Hide resolved

yibow98 reviewed

View reviewed changes

src/plugins/data_source_management/README.md Outdated Show resolved Hide resolved

yibow98 reviewed

View reviewed changes

Contributor

yibow98 left a comment

Overall looks good to me. Just fix some typos.

yibow98 reviewed

View reviewed changes

src/plugins/data_source/README.md Outdated Show resolved Hide resolved

yibow98 reviewed

View reviewed changes

src/plugins/data_source/README.md Outdated Show resolved Hide resolved

kristenTian force-pushed the multiD-rebase6 branch from ed76bf7 to 656653e Compare

September 29, 2022 00:37

Contributor Author

kristenTian commented Sep 29, 2022

Overall looks good to me. Just fix some typos.

thanks a lot, addressed all

zengyan-amazon reviewed

View reviewed changes

src/plugins/data_source/README.md Outdated Show resolved Hide resolved

src/plugins/data_source/README.md Outdated Show resolved Hide resolved

src/plugins/data_source/README.md Outdated Show resolved Hide resolved

src/plugins/data_source_management/README.md Outdated Show resolved Hide resolved

zengyan-amazon mentioned this pull request

Add sample config of multi data source to yml template. #2428

Merged

8 tasks

Contributor

noCharger commented Sep 29, 2022

Let's also update the CHANGELOG

kavilla added backport 2.x v2.4.0 labels

Member

seraphjiang commented Sep 30, 2022

Let's also update the CHANGELOG

+1
a reference

Documentation
README.md for saving index pattern relationship (#2276)
Remove extra typo from README. (#2403)

kristenTian force-pushed the multiD-rebase6 branch 2 times, most recently from c4e72b5 to 38ef966 Compare

September 30, 2022 20:26

zengyan-amazon previously approved these changes

View reviewed changes

kristenTian dismissed zengyan-amazon’s stale review via

336a272

October 4, 2022 00:14

kristenTian force-pushed the multiD-rebase6 branch from 38ef966 to 336a272 Compare

October 4, 2022 00:14

noCharger previously approved these changes

View reviewed changes

Contributor

noCharger left a comment

Approved with one nit.

src/plugins/data_source/README.md Outdated Show resolved Hide resolved

kristenTian dismissed noCharger’s stale review via

41de1f8

October 4, 2022 00:24

kristenTian force-pushed the multiD-rebase6 branch from 336a272 to 41de1f8 Compare

October 4, 2022 00:24

zhongnansu previously approved these changes

View reviewed changes

kristenTian requested a review from kavilla

October 4, 2022 00:27

noCharger previously approved these changes

View reviewed changes

kristenTian dismissed stale reviews from noCharger and zhongnansu via

aae7cbc

October 4, 2022 00:34

kristenTian force-pushed the multiD-rebase6 branch from 41de1f8 to aae7cbc Compare

October 4, 2022 00:34


          Add dataSource & dataSourceManagement ReadMe

bfc1e8d

Signed-off-by: Kristen Tian <[email protected]>

kristenTian force-pushed the multiD-rebase6 branch from 5e5a9af to bfc1e8d Compare

October 4, 2022 01:04

AMoo-Miki approved these changes

View reviewed changes

zengyan-amazon approved these changes

View reviewed changes

kristenTian merged commit fb39f7d into opensearch-project:main

Contributor

opensearch-trigger-bot bot commented Oct 4, 2022

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2448-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fb39f7d4732faad33a23388aa707366db97d3527
# Push it to GitHub
git push --set-upstream origin backport/backport-2448-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2448-to-2.x.

vagimeli mentioned this pull request

[Meta] Restructure the TOC to make it easier for users to find content opensearch-project/documentation-website#1036

Closed

15 tasks

zhongnansu added backport 2.x and removed backport 2.x labels

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.x] Add dataSource & dataSourceManagement Readme #2518

Merged

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          Add dataSource & dataSourceManagement ReadMe (#2448)

5a53628

Signed-off-by: Kristen Tian <[email protected]>

Signed-off-by: Kristen Tian <[email protected]>
(cherry picked from commit fb39f7d)

This was linked to issues Oct 6, 2022

[MD] Documentation for "data_source" plugin #2436

Closed

[MD] Documentation for "data_source_management" plugin #2437

Closed

[MD] Add README for data_source plugin #2199

Closed

[MD] Add doc for feature flag #2158

Closed

kavilla pushed a commit that referenced this pull request


          Add dataSource & dataSourceManagement ReadMe (#2448) (#2518)

22ae8fe

Signed-off-by: Kristen Tian <[email protected]>
(cherry picked from commit fb39f7d)

sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request


          Add dataSource & dataSourceManagement ReadMe (opensearch-project#2448)

5df8bd1

Signed-off-by: Kristen Tian <[email protected]>

Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yibow98 yibow98 left review comments

zengyan-amazon zengyan-amazon approved these changes

AMoo-Miki AMoo-Miki approved these changes

noCharger noCharger left review comments

zhongnansu zhongnansu left review comments

mpabba3003 Awaiting requested review from mpabba3003

kavilla Awaiting requested review from kavilla kavilla is a code owner

Labels

backport 2.x multiple datasource v2.4.0