[MD] Fix view single document issue by updating low-level search call param #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Su <[email protected]>
zhongnansu
requested review from
abbyhu2000,
zengyan-amazon,
ashwin-pc and
joshuarrrr
kristenTian
previously approved these changes
Sep 28, 2022
ananzh
previously approved these changes
Sep 29, 2022
|
@zhongnansu need to update the CHANGELOG.md file to pass the check |
Signed-off-by: Su <[email protected]>
Thanks, done. Could you approve again? |
Codecov Report
@@ Coverage Diff @@
## main #2431 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 3200 3200
Lines 60886 60886
Branches 9250 9250
=======================================
+ Hits 40642 40646 +4
+ Misses 18032 18029 -3
+ Partials 2212 2211 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kristenTian
approved these changes
Sep 29, 2022
7 tasks
zhongnansu
changed the title
zhongnansu
changed the title
kavilla
approved these changes
Oct 2, 2022
kavilla
approved these changes
Oct 3, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
… param (#2431) * Add datasource param to low-level search call in Discover * update change log Signed-off-by: Su <[email protected]> (cherry picked from commit 1f639b0)
joshuarrrr
pushed a commit
that referenced
this pull request
Oct 4, 2022
… param (#2431) (#2483) * Add datasource param to low-level search call in Discover * update change log Signed-off-by: Su <[email protected]> (cherry picked from commit 1f639b0) Co-authored-by: Zhongnan Su <[email protected]>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
… param (opensearch-project#2431) * Add datasource param to low-level search call in Discover * update change log Signed-off-by: Su <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Su [email protected]
Description
Add datasource param to low-level search call in Discover, that fixes the rendering issue of single document, while searching against data source
Issues Resolved
Part of #2400, issue reported by @abbyhu2000
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr