Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Fix renaming issues #243

Closed
wants to merge 1 commit into from
Closed

[Rename] Fix renaming issues #243

wants to merge 1 commit into from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Apr 2, 2021

Signed-off-by: Anan Zhuang [email protected]

This PR fixes some renaming issues for plugins built.

  1. The json file for plugins telemetry, telemetry_collection_manager and telemetry_management_section are not properly renamed. These 3 plugins can't be built and the system just simply ignore them. Make the following changes:
    src/plugins/telemetry/opensearch_dashboards_back.json --> opensearch_dashboards.json
    src/plugins/telemetry_collection_manager/opensearch_dashboards_back.json --> opensearch_dashboards.json
    src/plugins/telemetry_management_section/opensearch_dashboards_back.json --> opensearch_dashboards.json

  2. correct a renaming typo

Signed-off-by: Anan Zhuang <[email protected]>
@odfe-release-bot
Copy link

✅   DCO Check Passed 42ea1f3

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually these files are expected as we don't want telemetry to be supported.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are purposely named opensearch_dashboards_back so that they aren't loaded by Dashboards.

@ananzh ananzh closed this Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants