Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGELOG.md and related workflows #2414

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Sep 23, 2022

Description

Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

#2394

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@kavilla kavilla requested a review from a team as a code owner September 23, 2022 23:54
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
opensearch-project#2394

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla linked an issue Sep 23, 2022 that may be closed by this pull request
@@ -5,10 +5,11 @@
[List any issues this PR will resolve]

### Check List
- [ ] All tests pass
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be spruced up but i moved this higher because not everything needed new tests but tests should pass

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
simplify release note process

@codecov-commenter
Copy link

Codecov Report

Merging #2414 (66f8788) into main (08d0504) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 66f8788 differs from pull request most recent head 78c4fa0. Consider uploading reports for the commit 78c4fa0 to get more accurate results

@@            Coverage Diff             @@
##             main    #2414      +/-   ##
==========================================
- Coverage   66.75%   66.74%   -0.01%     
==========================================
  Files        3194     3194              
  Lines       60803    60803              
  Branches     9238     9238              
==========================================
- Hits        40587    40585       -2     
- Misses      18008    18010       +2     
  Partials     2208     2208              
Impacted Files Coverage Δ
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-2.78%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


### 🔩 Tests

## [2.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use x.x as place holder or change to 3.x algin with main?

@kavilla kavilla merged commit 806e96c into opensearch-project:main Sep 26, 2022
@kavilla kavilla deleted the rocky/changelog branch September 26, 2022 09:38
@noCharger
Copy link
Contributor

@kavilla Thanks for taking the purpose into action!

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 28, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
#2394

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 806e96c)
kavilla pushed a commit that referenced this pull request Sep 28, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
#2394

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 806e96c)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 28, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
#2394

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 806e96c)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2414-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 806e96c18672fcb7b7587740b2dec32aa48d6ec7
# Push it to GitHub
git push --set-upstream origin backport/backport-2414-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2414-to-1.x.

kavilla pushed a commit that referenced this pull request Sep 28, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
#2394

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 806e96c)
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Sep 30, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
opensearch-project#2394

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Sep 30, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
opensearch-project#2394

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Sep 30, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
opensearch-project#2394

Signed-off-by: Kawika Avilla <[email protected]>
joshuarrrr pushed a commit that referenced this pull request Sep 30, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
#2394

Signed-off-by: Kawika Avilla <[email protected]>

Signed-off-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
#2394

Signed-off-by: Kawika Avilla <[email protected]>

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit b497050)
joshuarrrr pushed a commit that referenced this pull request Sep 30, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
#2394

Signed-off-by: Kawika Avilla <[email protected]>

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit b497050)

Co-authored-by: Kawika Avilla <[email protected]>
@AMoo-Miki AMoo-Miki added docs Improvements or additions to documentation v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 5, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
Adding a CHANGELOG.md to be manually update per PR

This should be automated though in the future.

Issue:
opensearch-project#2394

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x docs Improvements or additions to documentation v1.3.6 v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Maintain a changelog for OSD repo
9 participants