Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes management app breadcrumb error #2344

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fixes management app breadcrumb error #2344

merged 1 commit into from
Sep 16, 2022

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Sep 13, 2022 •
edited
Loading

Signed-off-by: Ashwin Pc [email protected]

Description

Fixes console error when loading management app

Issues Resolved

#2048

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@ashwin-pc ashwin-pc requested a review from a team as a code owner September 13, 2022 21:09
@codecov-commenter
Copy link

Codecov Report

Merging #2344 (62aef0b) into main (a19a741) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
- Coverage   66.55%   66.55%   -0.01%     
==========================================
  Files        3170     3170              
  Lines       60316    60317       +1     
  Branches     9181     9181              
==========================================
  Hits        40142    40142              
- Misses      17981    17982       +1     
  Partials     2193     2193
Impacted Files Coverage Δ
...ndex_pattern_prompt/empty_index_pattern_prompt.tsx 80.00% <50.00%> (-20.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla kavilla linked an issue Sep 13, 2022 that may be closed by this pull request
[Bug] Header component error on index pattern management page #2048
Closed
joshuarrrr
joshuarrrr approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ashwin-pc ashwin-pc merged commit b5d529a into opensearch-project:main Sep 16, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2022
@ashwin-pc @github-actions
Fixes management app breadcrumb error (#2344)
78d249a 
Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
(cherry picked from commit b5d529a)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 16, 2022
Merged
kavilla pushed a commit that referenced this pull request Sep 16, 2022
@opensearch-trigger-bot @ashwin-pc
Fixes management app breadcrumb error (#2344) (#2377)
4f45570 
Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
(cherry picked from commit b5d529a)

Co-authored-by: Ashwin P Chandran <[email protected]>
@AMoo-Miki AMoo-Miki added bug Something isn't working v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 5, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@ashwin-pc @sipopo
Fixes management app breadcrumb error (opensearch-project#2344)
607ad19 
Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kaddy645 kaddy645 kaddy645 approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

Assignees
No one assigned
Labels
backport 2.x bug Something isn't working v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Header component error on index pattern management page
6 participants
@ashwin-pc @codecov-commenter @joshuarrrr @kaddy645 @abbyhu2000 @AMoo-Miki