Update unit tests #233
Merged
Update unit tests #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed 2a5aebe |
ananzh
reviewed
Mar 24, 2021
..._pattern_wizard/components/step_index_pattern/__snapshots__/step_index_pattern.test.tsx.snap
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 24, 2021
..._pattern_wizard/components/step_index_pattern/__snapshots__/step_index_pattern.test.tsx.snap
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 24, 2021
...ensearch_dashboards_overview/public/components/overview/__snapshots__/overview.test.tsx.snap
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 24, 2021
src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx
Show resolved
Hide resolved
~25 failures still. I need to update the project to just ignore the maps directory completely for tests instead of just ignoring one test. Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
8 failures still. Committing here because the remaining but require an agreement of next steps. Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
update-unit-tests
branch
from
2a5aebe to
7d42286
Compare
|
✅ DCO Check Passed 7d42286 |
|
✅ DCO Check Passed 499711f |
|
✅ DCO Check Passed 20d3952 |
Files were uncompressed, renamed, and then compressed again for unit tests. Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
update-unit-tests
branch
from
20d3952 to
4f390a6
Compare
|
✅ DCO Check Passed 4f390a6 |
ananzh
previously approved these changes
Mar 25, 2021
…t.js Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed c314dbd |
Updated references to OpenSearch and OpenSearch Dashboards for the zipped files with the cli_plugin for the tests to pass. Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed 8c44e54 |
This test checks if image exists but this image was removed in the renaming process at this commit: 3ecadd0. Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed e3a9612 |
Updating a test that discovers plugins to have the correct amount. The original tests removed the creation of the mock related to x-pack. Update the test to get the correct values while running tests. Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed b93ef34 |
|
Results: |
3 tasks
boktorbb
previously approved these changes
Mar 25, 2021
mihirsoni
reviewed
Mar 26, 2021
mihirsoni
reviewed
Mar 26, 2021
mihirsoni
reviewed
Mar 26, 2021
mihirsoni
reviewed
Mar 26, 2021
mihirsoni
reviewed
Mar 26, 2021
src/plugins/advanced_settings/public/management_app/lib/get_category_name.test.ts
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 26, 2021
src/plugins/opensearch_dashboards_react/public/markdown/markdown.test.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Mar 26, 2021
src/plugins/security_oss/public/insecure_cluster_service/components/default_alert.test.tsx
Outdated
Show resolved
Hide resolved
PR comment to include RENAMEME for easy grepping and update a ref to opensearch.com to opensearch.co so that it is easier to grep while renaming. Then had to regenerate the snapshots. Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed 4fcc7bb |
kavilla
added a commit
that referenced
this pull request
Mar 26, 2021
* [Tests] A few easy fixes for unit tests ~25 failures still. I need to update the project to just ignore the maps directory completely for tests instead of just ignoring one test. Signed-off-by: Kawika Avilla <[email protected]> * [Tests] exclude maps from jest Signed-off-by: Kawika Avilla <[email protected]> * [Tests] More easy fixes for unit tests 8 failures still. Committing here because the remaining but require an agreement of next steps. Signed-off-by: Kawika Avilla <[email protected]> * [Tests] Update compressed files for unit tests Files were uncompressed, renamed, and then compressed again for unit tests. Signed-off-by: Kawika Avilla <[email protected]> * [Tests] Rename cli_plugin/kibana.test.js to opensearch_dashboards.test.js Signed-off-by: Kawika Avilla <[email protected]> * [Tests] update zip files in cli_plugin Updated references to OpenSearch and OpenSearch Dashboards for the zipped files with the cli_plugin for the tests to pass. Signed-off-by: Kawika Avilla <[email protected]> * [Tests] remove optimize/image tests This test checks if image exists but this image was removed in the renaming process at this commit: 3ecadd0. Signed-off-by: Kawika Avilla <[email protected]> * [Tests] update plugins_discovery test Updating a test that discovers plugins to have the correct amount. The original tests removed the creation of the mock related to x-pack. Update the test to get the correct values while running tests. Signed-off-by: Kawika Avilla <[email protected]> * [Tests] update TODOs with [RENAMEME] and ref to .com PR comment to include RENAMEME for easy grepping and update a ref to opensearch.com to opensearch.co so that it is easier to grep while renaming. Then had to regenerate the snapshots. Signed-off-by: Kawika Avilla <[email protected]>
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Oct 27, 2023
…ect#192) (opensearch-project#233) * [Workspace][Feature] Left navigation menu adjustment (opensearch-project#192) * add util function to filter workspace feature by wildcard Signed-off-by: Yulong Ruan <[email protected]> * resolve conflict Signed-off-by: yuye-aws <[email protected]> * update tests and snapshots Signed-off-by: yuye-aws <[email protected]> * small adjustment to left menu Signed-off-by: yuye-aws <[email protected]> * resolve git conflict Signed-off-by: yuye-aws <[email protected]> * rename nav link service function Signed-off-by: yuye-aws <[email protected]> * unit test for workspace plugin.ts Signed-off-by: yuye-aws <[email protected]> * update snapshots Signed-off-by: yuye-aws <[email protected]> * optimize code Signed-off-by: yuye-aws <[email protected]> * optimize code Signed-off-by: yuye-aws <[email protected]> * optimize code Signed-off-by: yuye-aws <[email protected]> * optimize code Signed-off-by: yuye-aws <[email protected]> * optimize code Signed-off-by: yuye-aws <[email protected]> * optimize code Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: yuye-aws <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> * resolve conflict Signed-off-by: yuye-aws <[email protected]> * update snapshots Signed-off-by: yuye-aws <[email protected]> * resolve conflicts Signed-off-by: yuye-aws <[email protected]> * restore snapshot Signed-off-by: yuye-aws <[email protected]> * update tests Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: yuye-aws <[email protected]> Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update unit tests to succeed. Updating the tests where it needs to be in expectations, or potentially some missed updates, or even ignoring some directories because they are no longer relevant. Also, included updating the compressed files that get uncompressed during test run and verified.
Some snapshots had to be updated again as well.
Issues Resolved
#207
Check List
New functionality has been documented.New functionality has javadoc added