[backport 2.x][CI][Tests] add BWC tests for 2.3.0 #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add bwc test data (v2.2.0) backport PR: opensearch-project#2148 Signed-off-by: Anan Zhuang <[email protected]>
ashwin-pc
approved these changes
Sep 7, 2022
joshuarrrr
reviewed
Sep 7, 2022
| @@ -176,7 +176,7 @@ jobs: | |||
| working-directory: ./artifacts | |||
| strategy: | |||
| matrix: | |||
| version: [ osd-1.3.2,osd-2.0.0,osd-2.1.0 ] | |||
| version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0 ] | |||
There was a problem hiding this comment.
Why are we dropping the testing for 1.3.2? If this is a backport, shouldn't we just be adding 2.2.0 to the end of the list?
There was a problem hiding this comment.
great question. Compare https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2281/files and https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2148/files . We could see osd-1.3.2 is removed earlier. I think the problem is that we have build_and_test_workflow.yml in the lastest main but 2.x still use pr_check_workflow.yml (this still have v1.3.2). it seems we are missing some PRs in 2.x
noCharger
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add bwc test data (v2.2.0)
backport PR: #2148
Signed-off-by: Anan Zhuang [email protected]
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr