Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D&D] Adds Bar line and Area charts to Wizard #2266

Merged
merged 10 commits into from
Sep 8, 2022
Merged

[D&D] Adds Bar line and Area charts to Wizard #2266

merged 10 commits into from
Sep 8, 2022

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Sep 3, 2022 •
edited
Loading

Description

  • Adds Bar line and Area charts to Wizard
  • Adds resizable right nav to Wizard
  • E2E tests for bar chart and chart switching

Sep-07-2022 14-57-41

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@ashwin-pc ashwin-pc requested a review from a team as a code owner September 3, 2022 05:01
@ashwin-pc ashwin-pc self-assigned this Sep 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022 •
edited
Loading

Codecov Report

Merging #2266 (dd6aadd) into main (4a06f5a) will decrease coverage by 0.21%.
The diff coverage is 11.90%.

@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
- Coverage   66.77%   66.55%   -0.22%     
==========================================
  Files        3133     3169      +36     
  Lines       60086    60315     +229     
  Branches     9154     9180      +26     
==========================================
+ Hits        40121    40145      +24     
- Misses      17775    17981     +206     
+ Partials     2190     2189       -1
Impacted Files Coverage Δ
src/plugins/vis_type_vislib/public/index.ts 0.00% <ø> (ø)
src/plugins/visualizations/public/index.ts 0.00% <ø> (ø)
src/plugins/wizard/public/application/app.tsx 33.33% <0.00%> (-16.67%) ⬇️
...ublic/application/components/experimental_info.tsx 66.66% <0.00%> (+16.66%) ⬆️
...wizard/public/application/components/right_nav.tsx 13.33% <0.00%> (-6.67%) ⬇️
...wizard/public/application/components/workspace.tsx 4.00% <0.00%> (-0.17%) ⬇️
...zard/public/visualizations/metric/to_expression.ts 6.12% <0.00%> (+0.66%) ⬆️
...ations/vislib/area/components/area_vis_options.tsx 0.00% <0.00%> (ø)
...lib/histogram/components/histogram_vis_options.tsx 0.00% <0.00%> (ø)
...ations/vislib/line/components/line_vis_options.tsx 0.00% <0.00%> (ø)
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashwin-pc
Working histogram
8fbd20f 
Signed-off-by: Ashwin Pc <[email protected]>
@ashwin-pc
Adds histogram options
7841c81 
Signed-off-by: Ashwin Pc <[email protected]>
@ashwin-pc
Adds line chart
aa3c2ac 
Signed-off-by: Ashwin Pc <[email protected]>
@ashwin-pc
Adds area chart
f71d630 
Signed-off-by: Ashwin Pc <[email protected]>
@ashwin-pc
updates nav sizes
b49ba63 
Signed-off-by: Ashwin Pc <[email protected]>
@ashwin-pc
adds resizeable container to right nav
3b6c3d3 
Signed-off-by: Ashwin Pc <[email protected]>
@ashwin-pc
Misc fixes
3769a3a 
Signed-off-by: Ashwin Pc <[email protected]>
@ashwin-pc
Adds chart switcher test
240cc1e 
Signed-off-by: Ashwin Pc <[email protected]>
joshuarrrr
joshuarrrr previously approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on getting all the basics working! Some questions and callouts for future work, but I think this will give people a lot more freedom to play with the tool!

Now that we have all the functionality working, we'll want to also set aside some more time to get a lot of the defaults set, which will minimize user steps for common tasks.

test/functional/apps/wizard/_base.ts Show resolved Hide resolved
src/plugins/wizard/public/application/_variables.scss Outdated Show resolved Hide resolved
src/plugins/wizard/public/application/components/right_nav.tsx Show resolved Hide resolved
src/plugins/wizard/public/application/components/right_nav.tsx Outdated Show resolved Hide resolved
src/plugins/wizard/public/visualizations/common/expression_helpers.ts Outdated Show resolved Hide resolved
src/plugins/wizard/public/visualizations/common/expression_helpers.ts Show resolved Hide resolved
src/plugins/wizard/public/visualizations/vislib/area/area_vis_type.ts Show resolved Hide resolved
src/plugins/wizard/public/visualizations/vislib/common/get_value_axes.ts Show resolved Hide resolved
src/plugins/wizard/public/visualizations/vislib/histogram/histogram_vis_type.ts Outdated Show resolved Hide resolved
src/plugins/wizard/public/visualizations/vislib/line/line_vis_type.ts Show resolved Hide resolved
@ashwin-pc @joshuarrrr
Github comment feedback
e8b4899 
Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
@ashwin-pc
Updates copy
dd6aadd 
Signed-off-by: Ashwin Pc <[email protected]>
AMoo-Miki
AMoo-Miki reviewed Sep 7, 2022
View reviewed changes
src/plugins/wizard/public/visualizations/metric/to_expression.ts
@@ -3,18 +3,13 @@
* SPDX-License-Identifier: Apache-2.0
*/

import { cloneDeep } from 'lodash';
Copy link
Collaborator

@AMoo-Miki AMoo-Miki Sep 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

kavilla
kavilla approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@ashwin-pc ashwin-pc merged commit 77af7f9 into opensearch-project:main Sep 8, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 8, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2022
@ashwin-pc @github-actions
[D&D] Adds Bar line and Area charts to Wizard (#2266)
8b14d83 
* Working histogram

Signed-off-by: Ashwin Pc <[email protected]>

* Adds histogram options

Signed-off-by: Ashwin Pc <[email protected]>

* Adds line chart

Signed-off-by: Ashwin Pc <[email protected]>

* Adds area chart

Signed-off-by: Ashwin Pc <[email protected]>

* updates nav sizes

Signed-off-by: Ashwin Pc <[email protected]>

* adds resizeable container to right nav

Signed-off-by: Ashwin Pc <[email protected]>

* Misc fixes

Signed-off-by: Ashwin Pc <[email protected]>

* Adds chart switcher test

Signed-off-by: Ashwin Pc <[email protected]>

* Github comment feedback

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>

* Updates copy

Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 77af7f9)
ananzh pushed a commit that referenced this pull request Sep 8, 2022
@opensearch-trigger-bot @joshuarrrr
[D&D] Adds Bar line and Area charts to Wizard (#2266) (#2291)
5f7541e 
Description
* Adds Bar line and Area charts to Wizard
* Adds resizable right nav to Wizard
* E2E tests for bar chart and chart switching

Issues Resolved:
#1616
#1617
#1618

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Sep 14, 2022
@ashwin-pc @joshuarrrr @sipopo
[D&D] Adds Bar line and Area charts to Wizard (opensearch-project#2266)
166945e 
* Working histogram

Signed-off-by: Ashwin Pc <[email protected]>

* Adds histogram options

Signed-off-by: Ashwin Pc <[email protected]>

* Adds line chart

Signed-off-by: Ashwin Pc <[email protected]>

* Adds area chart

Signed-off-by: Ashwin Pc <[email protected]>

* updates nav sizes

Signed-off-by: Ashwin Pc <[email protected]>

* adds resizeable container to right nav

Signed-off-by: Ashwin Pc <[email protected]>

* Misc fixes

Signed-off-by: Ashwin Pc <[email protected]>

* Adds chart switcher test

Signed-off-by: Ashwin Pc <[email protected]>

* Github comment feedback

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>

* Updates copy

Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
seraphjiang pushed a commit to seraphjiang/OpenSearch-Dashboards that referenced this pull request Oct 17, 2022
@opensearch-trigger-bot @joshuarrrr @seraphjiang
[D&D] Adds Bar line and Area charts to Wizard (opensearch-project#2266)…
1ab0f0a 
… (opensearch-project#2291)

Description
* Adds Bar line and Area charts to Wizard
* Adds resizable right nav to Wizard
* E2E tests for bar chart and chart switching

Issues Resolved:
opensearch-project#1616
opensearch-project#1617
opensearch-project#1618

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@ashwin-pc @joshuarrrr @sipopo
[D&D] Adds Bar line and Area charts to Wizard (opensearch-project#2266)
a7115b2 
* Working histogram

Signed-off-by: Ashwin Pc <[email protected]>

* Adds histogram options

Signed-off-by: Ashwin Pc <[email protected]>

* Adds line chart

Signed-off-by: Ashwin Pc <[email protected]>

* Adds area chart

Signed-off-by: Ashwin Pc <[email protected]>

* updates nav sizes

Signed-off-by: Ashwin Pc <[email protected]>

* adds resizeable container to right nav

Signed-off-by: Ashwin Pc <[email protected]>

* Misc fixes

Signed-off-by: Ashwin Pc <[email protected]>

* Adds chart switcher test

Signed-off-by: Ashwin Pc <[email protected]>

* Github comment feedback

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>

* Updates copy

Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@kavilla kavilla kavilla approved these changes

@bandinib-amzn bandinib-amzn bandinib-amzn approved these changes

Assignees

@ashwin-pc ashwin-pc

Labels
backport 2.x v2.3.0 vis builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashwin-pc @codecov-commenter @joshuarrrr @AMoo-Miki @kavilla @bandinib-amzn