-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] Update delete credentials method to be in parallel #2076
[MD] Update delete credentials method to be in parallel #2076
Conversation
Signed-off-by: Louis Chu <[email protected]>
ff553c9
to
bba6d1f
Compare
The existing delete placement pattern for the button that appears after selection is to the left of the search field within a table. Please see: |
To provide additional context, the saved object management portal looks like this, complete with a delete button on right side. I'm looking forward to the decision. |
Note: Copy should be sentence cased. |
@noCharger |
src/plugins/credential_management/public/components/credential_table/credentials_table.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add confirmation before deletion
- refactory code to be more clear, make sure decouple ui and code logical for testibility.
Tracked on #2055 |
Tracked on #2055 |
Could you please explain which parts of the changed files require refactoring? |
expected an end to end production ready solution for deletion. or rewrite this to meet expectation on code quality. |
await Promise.all( | ||
selectedCredentials.map(async (selectedCredential) => { | ||
await savedObjectsClient.delete('credential', selectedCredential.id); | ||
}) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Louis Chu [email protected]
Description
Issues Resolved
Part 1 of #2055
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr