Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breadcrumbfix for datasource management #2066

Merged
merged 4 commits into from
Aug 4, 2022
Merged

breadcrumbfix for datasource management #2066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0a745f
breadcrumbfix for datasource management
mpabba3003 Aug 3, 2022
3093d83
breadcrumbfix for datasource management - refactoring code
mpabba3003 Aug 3, 2022
c1f84f5
using services to update breadcrumb on data sources management page
mpabba3003 Aug 3, 2022
294958d
Changing the license header on breadcrumbs.ts datasource management
mpabba3003 Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/plugins/data_source_management/public/components/breadcrumbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

import { i18n } from '@osd/i18n';

export function getListBreadcrumbs() {
return [
{
text: i18n.translate('indexPatternManagement.dataSources.listBreadcrumb', {
defaultMessage: 'Data Sources',
}),
href: `/`,
},
];
}
Comment on lines +6 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add Breadcrumbs for other pages as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be done as I create new pages and they are ready for user to navigate to.

7 changes: 7 additions & 0 deletions src/plugins/data_source_management/public/components/data_source_table/data_source_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,15 @@
import { EuiTitle } from '@elastic/eui';
import React from 'react';
import { withRouter } from 'react-router-dom';
import { getListBreadcrumbs } from '../breadcrumbs';
import { useOpenSearchDashboards } from '../../../../opensearch_dashboards_react/public';
import { DataSourceManagementContext } from '../../types';

export const DataSourceTable = () => {
const { setBreadcrumbs } = useOpenSearchDashboards<DataSourceManagementContext>().services;

setBreadcrumbs(getListBreadcrumbs());

return (
<EuiTitle>
<h2>{'This is the landing page, going to list data sources here...'}</h2>
Expand Down
12 changes: 10 additions & 2 deletions src/plugins/data_source_management/public/management_app/mount_management_section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import { StartServicesAccessor } from 'src/core/public';

import { I18nProvider } from '@osd/i18n/react';
import { i18n } from '@osd/i18n';
import React from 'react';
import ReactDOM from 'react-dom';
import { Route, Router, Switch } from 'react-router-dom';
Expand All @@ -14,7 +15,7 @@ import { ManagementAppMountParams } from '../../../management/public';
import { OpenSearchDashboardsContextProvider } from '../../../opensearch_dashboards_react/public';
import { CreateDataSourceWizardWithRouter } from '../components/create_data_source_wizard';
import { DataSourceTableWithRouter } from '../components/data_source_table';
import { DataSourceManagmentContext } from '../types';
import { DataSourceManagementContext } from '../types';

export async function mountManagementSection(
getStartServices: StartServicesAccessor,
Expand All @@ -24,7 +25,7 @@ export async function mountManagementSection(
{ chrome, application, savedObjects, uiSettings, notifications, overlays, http, docLinks },
] = await getStartServices();

const deps: DataSourceManagmentContext = {
const deps: DataSourceManagementContext = {
chrome,
application,
savedObjects,
Expand All @@ -36,6 +37,13 @@ export async function mountManagementSection(
setBreadcrumbs: params.setBreadcrumbs,
};

/* Browser - Page Title */
const title = i18n.translate('dataSourcesManagement.objects.dataSourcesTitle', {
defaultMessage: 'Data Sources',
});

chrome.docTitle.change(title);

ReactDOM.render(
<OpenSearchDashboardsContextProvider services={deps}>
<I18nProvider>
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/data_source_management/public/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export interface DataSourceManagementSetupDependencies {
management: ManagementSetup;
}

export interface DataSourceManagmentContext {
export interface DataSourceManagementContext {
chrome: ChromeStart;
application: ApplicationStart;
savedObjects: SavedObjectsStart;
Expand Down