Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adds the Drag and Drop editor to Visualize #1966

Merged
merged 47 commits into from
Aug 5, 2022
Merged

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Jul 27, 2022

Description

Draft PR to merge the long running work in Drag and Drop to mainline

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial feedback on everything except for src/plugins/wizard/common/* and src/plugins/wizard/public.

src/plugins/saved_objects_management/README.md Outdated Show resolved Hide resolved
src/plugins/saved_objects_management/README.md Outdated Show resolved Hide resolved
src/plugins/saved_objects_management/README.md Outdated Show resolved Hide resolved
src/plugins/wizard/.i18nrc.json Outdated Show resolved Hide resolved
src/plugins/wizard/server/index.ts Outdated Show resolved Hide resolved
src/plugins/wizard/server/types.ts Show resolved Hide resolved
Comment on lines +7 to +16
wizard: {
// TODO: investigate which capabilities we need to provide
// createNew: true,
// createShortUrl: true,
// delete: true,
show: true,
// showWriteControls: true,
// save: true,
// saveQuery: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to define wizard-specific capabilities, or can we just use the existing visualization capabilities?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer this to you, since you have more context here. Not entirely sure what the capabilities provider does w.r.t saved object management.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I’m not at all an expert in how capabilities work generally… but given the way the user flow works for D&D (we start by creating a visualization, and the result is essentially a visualization), using the existing visualization plugin capabilities actually makes more sense. So instead of defining and checking wizard.show or wizard.save, it seems like it makes more sense to just check for visualization.show or visualization.save capabilities (which is what I do in the embeddable to see whether to enable the Edit wizard action. Because we don’t really have a use case where a user has wizard capabilities that are different from their visualization capabilities.

But we'll definitely want to come back and figure out what exactly we should do here.

src/plugins/wizard/server/plugin.ts Outdated Show resolved Hide resolved
Comment on lines +36 to +37
// Register capabilities
capabilities.registerProvider(capabilitiesProvider);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer this to you, since you have more context here. Not entirely sure what the capabilities provider does w.r.t saved object management.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can leave it for now - see my other comment about capabilities.

@joshuarrrr joshuarrrr force-pushed the feature/d-and-d branch 2 times, most recently from d98644f to dfc33f0 Compare August 2, 2022 21:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #1966 (d79f3e0) into main (5fb4143) will decrease coverage by 0.28%.
The diff coverage is 21.39%.

@@            Coverage Diff             @@
##             main    #1966      +/-   ##
==========================================
- Coverage   67.51%   67.22%   -0.29%     
==========================================
  Files        3077     3100      +23     
  Lines       59188    59564     +376     
  Branches     9003     9062      +59     
==========================================
+ Hits        39958    40043      +85     
- Misses      17045    17334     +289     
- Partials     2185     2187       +2     
Impacted Files Coverage Δ
.../plugins/saved_objects_management/public/plugin.ts 62.50% <ø> (ø)
...ault_editor/public/components/agg_params_helper.ts 74.41% <ø> (ø)
src/plugins/vis_default_editor/public/index.ts 0.00% <ø> (ø)
...rc/plugins/vis_type_metric/public/metric_vis_fn.ts 44.44% <ø> (ø)
...ins/visualizations/public/legacy/build_pipeline.ts 49.18% <0.00%> (-0.27%) ⬇️
...ations/public/vis_types/vis_type_alias_registry.ts 33.33% <ø> (ø)
...s/wizard/public/embeddable/disabled_embeddable.tsx 0.00% <0.00%> (ø)
...izard/public/embeddable/disabled_visualization.tsx 0.00% <0.00%> (ø)
...s/wizard/public/saved_visualizations/_saved_vis.ts 0.00% <0.00%> (ø)
...ublic/saved_visualizations/saved_visualizations.ts 0.00% <0.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

import { WizardServices } from '../../types';
import { validateSchemaState } from '../utils/validate_schema_state';
import { useTypedDispatch, useTypedSelector } from '../utils/state_management';
import { setActiveVisualization } from '../utils/state_management/visualization_slice';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:
should we remove this import? since the only place uses it is a comment (toDO)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. will do that :)

@ashwin-pc ashwin-pc marked this pull request as ready for review August 3, 2022 22:19
@ashwin-pc ashwin-pc requested a review from a team as a code owner August 3, 2022 22:19
ashwin-pc and others added 19 commits August 4, 2022 00:02
* Initial Drag and Drop plugin code (#946)

* Initial Drag and Drop plugin code

Signed-off-by: Ashwin Pc <[email protected]>

* Adds state management to Drag and Drop

Signed-off-by: Ashwin Pc <[email protected]>

* Moves Drag and Drop to create visualization menu

Signed-off-by: Ashwin Pc <[email protected]>

* Field Search in Data panel  (#995)

Add ability to search on index fields
Signed-off-by: Abbas Hussain <[email protected]>

* Adds initial type service (#1260)

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates viz modal snapshot

Signed-off-by: Ashwin Pc <[email protected]>

* fix(License): Fixes license headers

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>
* feat(Contributions): Simple working contributions

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Add new field from dropbox

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working edit mode

Signed-off-by: Ashwin Pc <[email protected]>

* fix(Contributions): Fixes switching dropbox fields

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates license headers

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Adds initial drag & drop validation

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Allows multiple instances of the same field

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Working reorder fields

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working container contributions

Signed-off-by: Ashwin Pc <[email protected]>

* chore: clean up exports

Signed-off-by: Ashwin Pc <[email protected]>

* test(Contribution): Adds unit test `mergeArrays`

Signed-off-by: Ashwin Pc <[email protected]>

* test(TypeService): Adds plugin unit tests

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove redundant code

Signed-off-by: Ashwin Pc <[email protected]>

* test(Functional): Updates
Chart types

Signed-off-by: Ashwin Pc <[email protected]>
…1734)

* partial progress

Signed-off-by: Ashwin Pc <[email protected]>

* simle workign metric using aggShemas

Signed-off-by: Ashwin Pc <[email protected]>

* updated VisualizationTypeOptions to be a generic

Signed-off-by: Ashwin Pc <[email protected]>

* partially working metric style options

Signed-off-by: Ashwin Pc <[email protected]>

* all state objects are serializeable

Signed-off-by: Ashwin Pc <[email protected]>

* working delete and reorder

Signed-off-by: Ashwin Pc <[email protected]>

* chore: cleanup agg service changes

Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* cleanup dropbox field icon

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* Updated comment

Signed-off-by: Ashwin Pc <[email protected]>
* [D&D] Enable basic saved object management

- Create README stub for saved_objects_management plugin
- Register wizard saved object loader with management plugin
- Add management methods to SavedObjectsType
- Add capabilities provider to wizard
- Add saved wizard vis SavedObjectClass and SavedObjectLoader
- Add public plugin start method

partially addresses #1620

Signed-off-by: Josh Romero <[email protected]>

* [Doc] Add clarifications to README

for save objects management plugin

Signed-off-by: Josh Romero <[email protected]>
* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* feat: Adds agg type validation and defaults on drop

Signed-off-by: Ashwin Pc <[email protected]>

* chore: refactor filter

Signed-off-by: Ashwin Pc <[email protected]>
* adds min/max validation

Signed-off-by: Ashwin Pc <[email protected]>

* relocated contributions

Signed-off-by: Ashwin Pc <[email protected]>

* Some more cleanup

Signed-off-by: Ashwin Pc <[email protected]>

* minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* one more unnecessary file

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Seconday panel title

Signed-off-by: Ashwin Pc <[email protected]>
* fix dropbox styles and added animations

Signed-off-by: Ashwin Pc <[email protected]>

* simpler usePrefersReducedMotion

Signed-off-by: Ashwin Pc <[email protected]>

* fix drop target animation

Signed-off-by: Ashwin Pc <[email protected]>
* [D&D] Enable basic saving and loading

- Add `/edit` route
- Sync state for saving and loading
- Add setter for vizualization slice
- Switch from BrowserRouter to Router
- Add version to saved objects
- Add savedWizardLoader to services
- store visualization and style states separately
- add version
- update breadcrumb handling
- move useSavedWizardVis to top_nav
- handle savedObjectNotFound
- use savedObjectLoader correctly
- allow copy on save
- update url and chrome on save
- add type for WizardVisSavedObject

fixes #1867

Signed-off-by: Josh Romero <[email protected]>
* empty workspace polish

Signed-off-by: kaddy645 <[email protected]>

* pr update

Signed-off-by: kaddy645 <[email protected]>

* pr update 2

Signed-off-by: kaddy645 <[email protected]>
* fix(D&D): Fixes top nav query and timerange

Signed-off-by: Ashwin Pc <[email protected]>

* fix(D&D): Handles topnav state update

Signed-off-by: Ashwin Pc <[email protected]>
…gin (#1889)

Resolves Issue - #1877

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
config/opensearch_dashboards.yml Show resolved Hide resolved
src/plugins/saved_objects_management/README.md Outdated Show resolved Hide resolved
@@ -278,7 +276,7 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
>
<VisTypeIcon
icon={visType.type.icon === 'visTimeline' ? 'visTimelion' : visType.type.icon}
image={'image' in visType.type ? visType.type.image : 'visTimelion'}
image={'image' in visType.type ? visType.type.image : undefined}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just visType.type.image?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but Typescript cries because Property 'image' does not exist on type 'VisTypeAlias'.

import { IndexPattern } from '../../../../data/public';

function indexPatternEquality(A?: SearchableDropdownOption, B?: SearchableDropdownOption): boolean {
return !A || !B ? false : A.id === B.id;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/ Isn't this just A?.id === B?.id?
2/ Shouldn't it be A?.id && A.id === B?.id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CPTNB i'll let you take this since you did mention during the initial PR why we needed this. The only reason i can think of for this is when both A and B are undefined, case 1 will return true but your function returns false, and you explicitly needed that.

@@ -0,0 +1,24 @@
.wizFieldSelectorField {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comment above

<>
<FormattedMessage
id="wizard.experimentalInfoText"
defaultMessage="This editor is experimental, do not use in production.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt get your question here miki

Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more minor comments/responses

src/plugins/wizard/public/services/type_service/types.ts Outdated Show resolved Hide resolved
"ui": true,
"requiredPlugins": [
"navigation",
"charts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't actually use/reference their plugin lifecycle methods, we only need to import from them. That is, there's no runtime dependency on them, just a dependency on their bundle. I'm not 100% sure of this distinction, by the way, but it's the intuition I've pieced together from looking at other plugins.

src/plugins/wizard/.i18nrc.json Outdated Show resolved Hide resolved
Comment on lines +7 to +16
wizard: {
// TODO: investigate which capabilities we need to provide
// createNew: true,
// createShortUrl: true,
// delete: true,
show: true,
// showWriteControls: true,
// save: true,
// saveQuery: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I’m not at all an expert in how capabilities work generally… but given the way the user flow works for D&D (we start by creating a visualization, and the result is essentially a visualization), using the existing visualization plugin capabilities actually makes more sense. So instead of defining and checking wizard.show or wizard.save, it seems like it makes more sense to just check for visualization.show or visualization.save capabilities (which is what I do in the embeddable to see whether to enable the Edit wizard action. Because we don’t really have a use case where a user has wizard capabilities that are different from their visualization capabilities.

But we'll definitely want to come back and figure out what exactly we should do here.

Comment on lines +36 to +37
// Register capabilities
capabilities.registerProvider(capabilitiesProvider);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can leave it for now - see my other comment about capabilities.

src/plugins/wizard/server/plugin.ts Outdated Show resolved Hide resolved
src/plugins/wizard/.i18nrc.json Outdated Show resolved Hide resolved
src/plugins/wizard/README.md Outdated Show resolved Hide resolved
src/plugins/wizard/public/application/app.tsx Outdated Show resolved Hide resolved
@ashwin-pc ashwin-pc mentioned this pull request Aug 4, 2022
7 tasks
@ashwin-pc
Copy link
Member Author

I've fixed all the comments in #2071. Once that is merged in, i will resolve the comments here.

* chore: Disable wizard by default

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove routes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove translations

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: adds license to scss files

Signed-off-by: Ashwin Pc <[email protected]>

* chore: drop hover dark mode

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>
* fix: searchable dropdown

Signed-off-by: Ashwin Pc <[email protected]>

* fix: broken empty test

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds basic functional tests for D&D

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds CI group 13 to test workflow

Signed-off-by: Ashwin Pc <[email protected]>

* fix: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: att test to jenkinsfile

Signed-off-by: Ashwin Pc <[email protected]>

* chore: minor nit fixes

Signed-off-by: Ashwin Pc <[email protected]>
package.json Outdated Show resolved Hide resolved
@kavilla
Copy link
Member

kavilla commented Aug 4, 2022

NIT: Would be cool to add the enabled config here and in the build repo, but not blocking.

public static type = WIZARD_SAVED_OBJECT;

// if type:wizard has no mapping, we push this mapping into OpenSearch
public static mapping = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's important thing to note that i believe once this gets merged in. if stuff was removed (i believe) or fields type was changed, a migration will need to be created.

@@ -30,11 +30,12 @@

import path from 'path';

export const OPENSEARCH_DASHBOARDS_ARCHIVE_PATH = path.resolve(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this was potentially exported because there might have been x-pack plugins that referenced it but i dont see none in the opensearch-project using.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm interesting. I was unable to add a new ciGroup until i removed these exports.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, played around with it. Secluded enough! Thank you!!!

Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming latest workflows all pass, shipit!

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to using new D&D

@ashwin-pc ashwin-pc merged commit 1e34c06 into main Aug 5, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1966-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1e34c060c23f8fb2ec5f54cfebc9b8b67813d694
# Push it to GitHub
git push --set-upstream origin backport/backport-1966-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1966-to-2.x.

ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Aug 5, 2022
…pensearch-project#1966)

Backport PR:
opensearch-project#1966

Backport PR commit message:
* [Chore] Moves Drag and Drop to new branch (opensearch-project#1400)

* Initial Drag and Drop plugin code (opensearch-project#946)

* Initial Drag and Drop plugin code

Signed-off-by: Ashwin Pc <[email protected]>

* Adds state management to Drag and Drop

Signed-off-by: Ashwin Pc <[email protected]>

* Moves Drag and Drop to create visualization menu

Signed-off-by: Ashwin Pc <[email protected]>

* Field Search in Data panel  (opensearch-project#995)

Add ability to search on index fields
Signed-off-by: Abbas Hussain <[email protected]>

* Adds initial type service (opensearch-project#1260)

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates viz modal snapshot

Signed-off-by: Ashwin Pc <[email protected]>

* fix(License): Fixes license headers

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>

* [D&D] Type Service Contributions (opensearch-project#1402)

* feat(Contributions): Simple working contributions

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Add new field from dropbox

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working edit mode

Signed-off-by: Ashwin Pc <[email protected]>

* fix(Contributions): Fixes switching dropbox fields

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates license headers

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Adds initial drag & drop validation

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Allows multiple instances of the same field

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Working reorder fields

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working container contributions

Signed-off-by: Ashwin Pc <[email protected]>

* chore: clean up exports

Signed-off-by: Ashwin Pc <[email protected]>

* test(Contribution): Adds unit test `mergeArrays`

Signed-off-by: Ashwin Pc <[email protected]>

* test(TypeService): Adds plugin unit tests

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove redundant code

Signed-off-by: Ashwin Pc <[email protected]>

* test(Functional): Updates
Chart types

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Refactor to use AggService and introduce metric visualization (opensearch-project#1734)

* partial progress

Signed-off-by: Ashwin Pc <[email protected]>

* simle workign metric using aggShemas

Signed-off-by: Ashwin Pc <[email protected]>

* updated VisualizationTypeOptions to be a generic

Signed-off-by: Ashwin Pc <[email protected]>

* partially working metric style options

Signed-off-by: Ashwin Pc <[email protected]>

* all state objects are serializeable

Signed-off-by: Ashwin Pc <[email protected]>

* working delete and reorder

Signed-off-by: Ashwin Pc <[email protected]>

* chore: cleanup agg service changes

Signed-off-by: Ashwin Pc <[email protected]>

* Adds the data source selector and a useIndexPatterns hook (opensearch-project#1763)

Signed-off-by: Brooke Green <[email protected]>

* [D&D] Adding and editing an aggregation + metric color ranges (opensearch-project#1781)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* cleanup dropbox field icon

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* Updated comment

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic saved object management (opensearch-project#1816)

* [D&D] Enable basic saved object management

- Create README stub for saved_objects_management plugin
- Register wizard saved object loader with management plugin
- Add management methods to SavedObjectsType
- Add capabilities provider to wizard
- Add saved wizard vis SavedObjectClass and SavedObjectLoader
- Add public plugin start method

partially addresses opensearch-project#1620

Signed-off-by: Josh Romero <[email protected]>

* [Doc] Add clarifications to README

for save objects management plugin

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds drop validation (opensearch-project#1833)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* feat: Adds agg type validation and defaults on drop

Signed-off-by: Ashwin Pc <[email protected]>

* chore: refactor filter

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates D&D icon (opensearch-project#1844)

Signed-off-by: Ashwin Pc <[email protected]>

* Chore/remove contributions (opensearch-project#1843)

* adds min/max validation

Signed-off-by: Ashwin Pc <[email protected]>

* relocated contributions

Signed-off-by: Ashwin Pc <[email protected]>

* Some more cleanup

Signed-off-by: Ashwin Pc <[email protected]>

* minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* one more unnecessary file

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Seconday panel title

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates Field selector (opensearch-project#1845)

Signed-off-by: Ashwin Pc <[email protected]>

* Adding breadcrumbs for drag and drop creation (opensearch-project#1797)

Signed-off-by: Brooke Green <[email protected]>

* fix(D&D): fixes reloading app (opensearch-project#1855)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Dropbox style and animations (opensearch-project#1863)

* fix dropbox styles and added animations

Signed-off-by: Ashwin Pc <[email protected]>

* simpler usePrefersReducedMotion

Signed-off-by: Ashwin Pc <[email protected]>

* fix drop target animation

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Basic saving, loading, and updating (opensearch-project#1870)

* [D&D] Enable basic saving and loading

- Add `/edit` route
- Sync state for saving and loading
- Add setter for vizualization slice
- Switch from BrowserRouter to Router
- Add version to saved objects
- Add savedWizardLoader to services
- store visualization and style states separately
- add version
- update breadcrumb handling
- move useSavedWizardVis to top_nav
- handle savedObjectNotFound
- use savedObjectLoader correctly
- allow copy on save
- update url and chrome on save
- add type for WizardVisSavedObject

fixes opensearch-project#1867

Signed-off-by: Josh Romero <[email protected]>

* chore: Adds a few readme's (opensearch-project#1894)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Empty-workspace polish (opensearch-project#1900)

* empty workspace polish

Signed-off-by: kaddy645 <[email protected]>

* pr update

Signed-off-by: kaddy645 <[email protected]>

* pr update 2

Signed-off-by: kaddy645 <[email protected]>

* [D&D] Fix: Topnav updates aggregation parameters (opensearch-project#1905)

* fix(D&D): Fixes top nav query and timerange

Signed-off-by: Ashwin Pc <[email protected]>

* fix(D&D): Handles topnav state update

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (opensearch-project#1889)

Resolves Issue - opensearch-project#1877

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* fix(Workspace): Fixes illustration and copy (opensearch-project#1916)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Misc fixes (opensearch-project#1924)

* fix: minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit syntax fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: simplify useSavedWizardVis

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic embeddable panels (opensearch-project#1911)

- add embeddable, embeddable component, embeddable factory
- update `toExpression` to allow passing services
- register embeddable factory in plugin setup

fixes opensearch-project#1908

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix scss lint and available fields (opensearch-project#1927)

* fix(Lint): fixes scss linting issues

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Filter field types correctly

Signed-off-by: Ashwin Pc <[email protected]>

* fix: minor

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add wizard saved objects to vis list (opensearch-project#1933)

via appExtensions of alias registration

fixes opensearch-project#1887

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Feature/experimental (opensearch-project#1934)

* feat: experimental banner

Signed-off-by: Ashwin Pc <[email protected]>

* feat: experimental embeddable

Signed-off-by: Ashwin Pc <[email protected]>

* fix: experimental banner location

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Remove search/hasMatch embeddable vestiges (opensearch-project#1935)

- removedebugging rendering
- also update embeddables icon

fixes opensearch-project#1910, opensearch-project#1925

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Refactor and cleanup embeddables (opensearch-project#1947)

General plugin updates (opensearch-project#1939):
- add start service getters/setters to plugin service
- move setters from setup to start so they're available to embeddable

Embeddable updates:
- use getters instead of depending on start services in constructor
- remove wizard from add panel "create" list
- add correct edit paths/URLs for linking to wizard opensearch-project#1940
- add basic error embeddable rendering
- render via ExpressionLoader instead of wizard_component opensearch-project#1920
- wizard_component no longer used, but updated for future use
- add subscription handling for query, filter, timerange changes opensearch-project#1937
- fix clone/replace panel actions opensearch-project#1943, opensearch-project#1944
- fix title/description panel rendering opensearch-project#1921
- add inspection panel action opensearch-project#1936

Asset updates:
- Update empty workspace illustration
- Add secondary fill icon version to match new visualization icons

fixes opensearch-project#1936, opensearch-project#1920, opensearch-project#1937, opensearch-project#1940, opensearch-project#1921, opensearch-project#1939, opensearch-project#1941, opensearch-project#1943, opensearch-project#1944

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix index pattern state and loading (opensearch-project#1949)

Remove useIndexPattern hook in favor of useIndexPatterns

fixes opensearch-project#1917

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix duplicate title warning (opensearch-project#1950)

fixes opensearch-project#1918

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds autosave while editing aggregation (opensearch-project#1953)

* fest: Adds autosave while editing agg

Signed-off-by: Ashwin Pc <[email protected]>

* fix: autosave order

Signed-off-by: Ashwin Pc <[email protected]>

* fix: spelling

Co-authored-by: Josh Romero <[email protected]>

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Fixes autosave with debounce (opensearch-project#1965)

* fix: autosave editing

Signed-off-by: Ashwin Pc <[email protected]>

* chore: improve workspace animation

Signed-off-by: Ashwin Pc <[email protected]>

* fix: show invalid field when editing

Signed-off-by: Ashwin Pc <[email protected]>

* fix: header offset

Signed-off-by: Ashwin Pc <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/index.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/types.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Final fixes (opensearch-project#2071)

* chore: Disable wizard by default

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove routes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove translations

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: adds license to scss files

Signed-off-by: Ashwin Pc <[email protected]>

* chore: drop hover dark mode

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Initial functional tests (opensearch-project#2070)

* fix: searchable dropdown

Signed-off-by: Ashwin Pc <[email protected]>

* fix: broken empty test

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds basic functional tests for D&D

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds CI group 13 to test workflow

Signed-off-by: Ashwin Pc <[email protected]>

* fix: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: att test to jenkinsfile

Signed-off-by: Ashwin Pc <[email protected]>

* chore: minor nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: downgrade redux-toolkit for plugin compatibility

Signed-off-by: Ashwin Pc <[email protected]>

* chore: add docker config flag

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>
Co-authored-by: Brooke <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kartik Desai <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Aug 5, 2022
Backport PR:
opensearch-project#1966

Backport PR commit message:
* [Chore] Moves Drag and Drop to new branch (opensearch-project#1400)

* Initial Drag and Drop plugin code (opensearch-project#946)

* Initial Drag and Drop plugin code

Signed-off-by: Ashwin Pc <[email protected]>

* Adds state management to Drag and Drop

Signed-off-by: Ashwin Pc <[email protected]>

* Moves Drag and Drop to create visualization menu

Signed-off-by: Ashwin Pc <[email protected]>

* Field Search in Data panel  (opensearch-project#995)

Add ability to search on index fields
Signed-off-by: Abbas Hussain <[email protected]>

* Adds initial type service (opensearch-project#1260)

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates viz modal snapshot

Signed-off-by: Ashwin Pc <[email protected]>

* fix(License): Fixes license headers

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>

* [D&D] Type Service Contributions (opensearch-project#1402)

* feat(Contributions): Simple working contributions

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Add new field from dropbox

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working edit mode

Signed-off-by: Ashwin Pc <[email protected]>

* fix(Contributions): Fixes switching dropbox fields

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates license headers

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Adds initial drag & drop validation

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Allows multiple instances of the same field

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Working reorder fields

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working container contributions

Signed-off-by: Ashwin Pc <[email protected]>

* chore: clean up exports

Signed-off-by: Ashwin Pc <[email protected]>

* test(Contribution): Adds unit test `mergeArrays`

Signed-off-by: Ashwin Pc <[email protected]>

* test(TypeService): Adds plugin unit tests

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove redundant code

Signed-off-by: Ashwin Pc <[email protected]>

* test(Functional): Updates
Chart types

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Refactor to use AggService and introduce metric visualization (opensearch-project#1734)

* partial progress

Signed-off-by: Ashwin Pc <[email protected]>

* simle workign metric using aggShemas

Signed-off-by: Ashwin Pc <[email protected]>

* updated VisualizationTypeOptions to be a generic

Signed-off-by: Ashwin Pc <[email protected]>

* partially working metric style options

Signed-off-by: Ashwin Pc <[email protected]>

* all state objects are serializeable

Signed-off-by: Ashwin Pc <[email protected]>

* working delete and reorder

Signed-off-by: Ashwin Pc <[email protected]>

* chore: cleanup agg service changes

Signed-off-by: Ashwin Pc <[email protected]>

* Adds the data source selector and a useIndexPatterns hook (opensearch-project#1763)

Signed-off-by: Brooke Green <[email protected]>

* [D&D] Adding and editing an aggregation + metric color ranges (opensearch-project#1781)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* cleanup dropbox field icon

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* Updated comment

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic saved object management (opensearch-project#1816)

* [D&D] Enable basic saved object management

- Create README stub for saved_objects_management plugin
- Register wizard saved object loader with management plugin
- Add management methods to SavedObjectsType
- Add capabilities provider to wizard
- Add saved wizard vis SavedObjectClass and SavedObjectLoader
- Add public plugin start method

partially addresses opensearch-project#1620

Signed-off-by: Josh Romero <[email protected]>

* [Doc] Add clarifications to README

for save objects management plugin

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds drop validation (opensearch-project#1833)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* feat: Adds agg type validation and defaults on drop

Signed-off-by: Ashwin Pc <[email protected]>

* chore: refactor filter

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates D&D icon (opensearch-project#1844)

Signed-off-by: Ashwin Pc <[email protected]>

* Chore/remove contributions (opensearch-project#1843)

* adds min/max validation

Signed-off-by: Ashwin Pc <[email protected]>

* relocated contributions

Signed-off-by: Ashwin Pc <[email protected]>

* Some more cleanup

Signed-off-by: Ashwin Pc <[email protected]>

* minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* one more unnecessary file

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Seconday panel title

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates Field selector (opensearch-project#1845)

Signed-off-by: Ashwin Pc <[email protected]>

* Adding breadcrumbs for drag and drop creation (opensearch-project#1797)

Signed-off-by: Brooke Green <[email protected]>

* fix(D&D): fixes reloading app (opensearch-project#1855)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Dropbox style and animations (opensearch-project#1863)

* fix dropbox styles and added animations

Signed-off-by: Ashwin Pc <[email protected]>

* simpler usePrefersReducedMotion

Signed-off-by: Ashwin Pc <[email protected]>

* fix drop target animation

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Basic saving, loading, and updating (opensearch-project#1870)

* [D&D] Enable basic saving and loading

- Add `/edit` route
- Sync state for saving and loading
- Add setter for vizualization slice
- Switch from BrowserRouter to Router
- Add version to saved objects
- Add savedWizardLoader to services
- store visualization and style states separately
- add version
- update breadcrumb handling
- move useSavedWizardVis to top_nav
- handle savedObjectNotFound
- use savedObjectLoader correctly
- allow copy on save
- update url and chrome on save
- add type for WizardVisSavedObject

fixes opensearch-project#1867

Signed-off-by: Josh Romero <[email protected]>

* chore: Adds a few readme's (opensearch-project#1894)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Empty-workspace polish (opensearch-project#1900)

* empty workspace polish

Signed-off-by: kaddy645 <[email protected]>

* pr update

Signed-off-by: kaddy645 <[email protected]>

* pr update 2

Signed-off-by: kaddy645 <[email protected]>

* [D&D] Fix: Topnav updates aggregation parameters (opensearch-project#1905)

* fix(D&D): Fixes top nav query and timerange

Signed-off-by: Ashwin Pc <[email protected]>

* fix(D&D): Handles topnav state update

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (opensearch-project#1889)

Resolves Issue - opensearch-project#1877

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* fix(Workspace): Fixes illustration and copy (opensearch-project#1916)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Misc fixes (opensearch-project#1924)

* fix: minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit syntax fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: simplify useSavedWizardVis

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic embeddable panels (opensearch-project#1911)

- add embeddable, embeddable component, embeddable factory
- update `toExpression` to allow passing services
- register embeddable factory in plugin setup

fixes opensearch-project#1908

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix scss lint and available fields (opensearch-project#1927)

* fix(Lint): fixes scss linting issues

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Filter field types correctly

Signed-off-by: Ashwin Pc <[email protected]>

* fix: minor

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add wizard saved objects to vis list (opensearch-project#1933)

via appExtensions of alias registration

fixes opensearch-project#1887

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Feature/experimental (opensearch-project#1934)

* feat: experimental banner

Signed-off-by: Ashwin Pc <[email protected]>

* feat: experimental embeddable

Signed-off-by: Ashwin Pc <[email protected]>

* fix: experimental banner location

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Remove search/hasMatch embeddable vestiges (opensearch-project#1935)

- removedebugging rendering
- also update embeddables icon

fixes opensearch-project#1910, opensearch-project#1925

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Refactor and cleanup embeddables (opensearch-project#1947)

General plugin updates (opensearch-project#1939):
- add start service getters/setters to plugin service
- move setters from setup to start so they're available to embeddable

Embeddable updates:
- use getters instead of depending on start services in constructor
- remove wizard from add panel "create" list
- add correct edit paths/URLs for linking to wizard opensearch-project#1940
- add basic error embeddable rendering
- render via ExpressionLoader instead of wizard_component opensearch-project#1920
- wizard_component no longer used, but updated for future use
- add subscription handling for query, filter, timerange changes opensearch-project#1937
- fix clone/replace panel actions opensearch-project#1943, opensearch-project#1944
- fix title/description panel rendering opensearch-project#1921
- add inspection panel action opensearch-project#1936

Asset updates:
- Update empty workspace illustration
- Add secondary fill icon version to match new visualization icons

fixes opensearch-project#1936, opensearch-project#1920, opensearch-project#1937, opensearch-project#1940, opensearch-project#1921, opensearch-project#1939, opensearch-project#1941, opensearch-project#1943, opensearch-project#1944

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix index pattern state and loading (opensearch-project#1949)

Remove useIndexPattern hook in favor of useIndexPatterns

fixes opensearch-project#1917

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix duplicate title warning (opensearch-project#1950)

fixes opensearch-project#1918

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds autosave while editing aggregation (opensearch-project#1953)

* fest: Adds autosave while editing agg

Signed-off-by: Ashwin Pc <[email protected]>

* fix: autosave order

Signed-off-by: Ashwin Pc <[email protected]>

* fix: spelling

Co-authored-by: Josh Romero <[email protected]>

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Fixes autosave with debounce (opensearch-project#1965)

* fix: autosave editing

Signed-off-by: Ashwin Pc <[email protected]>

* chore: improve workspace animation

Signed-off-by: Ashwin Pc <[email protected]>

* fix: show invalid field when editing

Signed-off-by: Ashwin Pc <[email protected]>

* fix: header offset

Signed-off-by: Ashwin Pc <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/index.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/types.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Final fixes (opensearch-project#2071)

* chore: Disable wizard by default

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove routes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove translations

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: adds license to scss files

Signed-off-by: Ashwin Pc <[email protected]>

* chore: drop hover dark mode

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Initial functional tests (opensearch-project#2070)

* fix: searchable dropdown

Signed-off-by: Ashwin Pc <[email protected]>

* fix: broken empty test

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds basic functional tests for D&D

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds CI group 13 to test workflow

Signed-off-by: Ashwin Pc <[email protected]>

* fix: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: att test to jenkinsfile

Signed-off-by: Ashwin Pc <[email protected]>

* chore: minor nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: downgrade redux-toolkit for plugin compatibility

Signed-off-by: Ashwin Pc <[email protected]>

* chore: add docker config flag

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>
Co-authored-by: Brooke <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kartik Desai <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Aug 5, 2022
Backport PR:
opensearch-project#1966

Signed-off-by: Anan Zhuang <[email protected]>

Backport PR commit message:
* [Chore] Moves Drag and Drop to new branch (opensearch-project#1400)

* Initial Drag and Drop plugin code (opensearch-project#946)

* Initial Drag and Drop plugin code

Signed-off-by: Ashwin Pc <[email protected]>

* Adds state management to Drag and Drop

Signed-off-by: Ashwin Pc <[email protected]>

* Moves Drag and Drop to create visualization menu

Signed-off-by: Ashwin Pc <[email protected]>

* Field Search in Data panel  (opensearch-project#995)

Add ability to search on index fields
Signed-off-by: Abbas Hussain <[email protected]>

* Adds initial type service (opensearch-project#1260)

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates viz modal snapshot

Signed-off-by: Ashwin Pc <[email protected]>

* fix(License): Fixes license headers

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>

* [D&D] Type Service Contributions (opensearch-project#1402)

* feat(Contributions): Simple working contributions

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Add new field from dropbox

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working edit mode

Signed-off-by: Ashwin Pc <[email protected]>

* fix(Contributions): Fixes switching dropbox fields

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates license headers

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Adds initial drag & drop validation

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Allows multiple instances of the same field

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Working reorder fields

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working container contributions

Signed-off-by: Ashwin Pc <[email protected]>

* chore: clean up exports

Signed-off-by: Ashwin Pc <[email protected]>

* test(Contribution): Adds unit test `mergeArrays`

Signed-off-by: Ashwin Pc <[email protected]>

* test(TypeService): Adds plugin unit tests

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove redundant code

Signed-off-by: Ashwin Pc <[email protected]>

* test(Functional): Updates
Chart types

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Refactor to use AggService and introduce metric visualization (opensearch-project#1734)

* partial progress

Signed-off-by: Ashwin Pc <[email protected]>

* simle workign metric using aggShemas

Signed-off-by: Ashwin Pc <[email protected]>

* updated VisualizationTypeOptions to be a generic

Signed-off-by: Ashwin Pc <[email protected]>

* partially working metric style options

Signed-off-by: Ashwin Pc <[email protected]>

* all state objects are serializeable

Signed-off-by: Ashwin Pc <[email protected]>

* working delete and reorder

Signed-off-by: Ashwin Pc <[email protected]>

* chore: cleanup agg service changes

Signed-off-by: Ashwin Pc <[email protected]>

* Adds the data source selector and a useIndexPatterns hook (opensearch-project#1763)

Signed-off-by: Brooke Green <[email protected]>

* [D&D] Adding and editing an aggregation + metric color ranges (opensearch-project#1781)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* cleanup dropbox field icon

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* Updated comment

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic saved object management (opensearch-project#1816)

* [D&D] Enable basic saved object management

- Create README stub for saved_objects_management plugin
- Register wizard saved object loader with management plugin
- Add management methods to SavedObjectsType
- Add capabilities provider to wizard
- Add saved wizard vis SavedObjectClass and SavedObjectLoader
- Add public plugin start method

partially addresses opensearch-project#1620

Signed-off-by: Josh Romero <[email protected]>

* [Doc] Add clarifications to README

for save objects management plugin

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds drop validation (opensearch-project#1833)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* feat: Adds agg type validation and defaults on drop

Signed-off-by: Ashwin Pc <[email protected]>

* chore: refactor filter

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates D&D icon (opensearch-project#1844)

Signed-off-by: Ashwin Pc <[email protected]>

* Chore/remove contributions (opensearch-project#1843)

* adds min/max validation

Signed-off-by: Ashwin Pc <[email protected]>

* relocated contributions

Signed-off-by: Ashwin Pc <[email protected]>

* Some more cleanup

Signed-off-by: Ashwin Pc <[email protected]>

* minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* one more unnecessary file

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Seconday panel title

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates Field selector (opensearch-project#1845)

Signed-off-by: Ashwin Pc <[email protected]>

* Adding breadcrumbs for drag and drop creation (opensearch-project#1797)

Signed-off-by: Brooke Green <[email protected]>

* fix(D&D): fixes reloading app (opensearch-project#1855)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Dropbox style and animations (opensearch-project#1863)

* fix dropbox styles and added animations

Signed-off-by: Ashwin Pc <[email protected]>

* simpler usePrefersReducedMotion

Signed-off-by: Ashwin Pc <[email protected]>

* fix drop target animation

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Basic saving, loading, and updating (opensearch-project#1870)

* [D&D] Enable basic saving and loading

- Add `/edit` route
- Sync state for saving and loading
- Add setter for vizualization slice
- Switch from BrowserRouter to Router
- Add version to saved objects
- Add savedWizardLoader to services
- store visualization and style states separately
- add version
- update breadcrumb handling
- move useSavedWizardVis to top_nav
- handle savedObjectNotFound
- use savedObjectLoader correctly
- allow copy on save
- update url and chrome on save
- add type for WizardVisSavedObject

fixes opensearch-project#1867

Signed-off-by: Josh Romero <[email protected]>

* chore: Adds a few readme's (opensearch-project#1894)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Empty-workspace polish (opensearch-project#1900)

* empty workspace polish

Signed-off-by: kaddy645 <[email protected]>

* pr update

Signed-off-by: kaddy645 <[email protected]>

* pr update 2

Signed-off-by: kaddy645 <[email protected]>

* [D&D] Fix: Topnav updates aggregation parameters (opensearch-project#1905)

* fix(D&D): Fixes top nav query and timerange

Signed-off-by: Ashwin Pc <[email protected]>

* fix(D&D): Handles topnav state update

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (opensearch-project#1889)

Resolves Issue - opensearch-project#1877

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* fix(Workspace): Fixes illustration and copy (opensearch-project#1916)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Misc fixes (opensearch-project#1924)

* fix: minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit syntax fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: simplify useSavedWizardVis

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic embeddable panels (opensearch-project#1911)

- add embeddable, embeddable component, embeddable factory
- update `toExpression` to allow passing services
- register embeddable factory in plugin setup

fixes opensearch-project#1908

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix scss lint and available fields (opensearch-project#1927)

* fix(Lint): fixes scss linting issues

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Filter field types correctly

Signed-off-by: Ashwin Pc <[email protected]>

* fix: minor

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add wizard saved objects to vis list (opensearch-project#1933)

via appExtensions of alias registration

fixes opensearch-project#1887

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Feature/experimental (opensearch-project#1934)

* feat: experimental banner

Signed-off-by: Ashwin Pc <[email protected]>

* feat: experimental embeddable

Signed-off-by: Ashwin Pc <[email protected]>

* fix: experimental banner location

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Remove search/hasMatch embeddable vestiges (opensearch-project#1935)

- removedebugging rendering
- also update embeddables icon

fixes opensearch-project#1910, opensearch-project#1925

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Refactor and cleanup embeddables (opensearch-project#1947)

General plugin updates (opensearch-project#1939):
- add start service getters/setters to plugin service
- move setters from setup to start so they're available to embeddable

Embeddable updates:
- use getters instead of depending on start services in constructor
- remove wizard from add panel "create" list
- add correct edit paths/URLs for linking to wizard opensearch-project#1940
- add basic error embeddable rendering
- render via ExpressionLoader instead of wizard_component opensearch-project#1920
- wizard_component no longer used, but updated for future use
- add subscription handling for query, filter, timerange changes opensearch-project#1937
- fix clone/replace panel actions opensearch-project#1943, opensearch-project#1944
- fix title/description panel rendering opensearch-project#1921
- add inspection panel action opensearch-project#1936

Asset updates:
- Update empty workspace illustration
- Add secondary fill icon version to match new visualization icons

fixes opensearch-project#1936, opensearch-project#1920, opensearch-project#1937, opensearch-project#1940, opensearch-project#1921, opensearch-project#1939, opensearch-project#1941, opensearch-project#1943, opensearch-project#1944

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix index pattern state and loading (opensearch-project#1949)

Remove useIndexPattern hook in favor of useIndexPatterns

fixes opensearch-project#1917

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix duplicate title warning (opensearch-project#1950)

fixes opensearch-project#1918

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds autosave while editing aggregation (opensearch-project#1953)

* fest: Adds autosave while editing agg

Signed-off-by: Ashwin Pc <[email protected]>

* fix: autosave order

Signed-off-by: Ashwin Pc <[email protected]>

* fix: spelling

Co-authored-by: Josh Romero <[email protected]>

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Fixes autosave with debounce (opensearch-project#1965)

* fix: autosave editing

Signed-off-by: Ashwin Pc <[email protected]>

* chore: improve workspace animation

Signed-off-by: Ashwin Pc <[email protected]>

* fix: show invalid field when editing

Signed-off-by: Ashwin Pc <[email protected]>

* fix: header offset

Signed-off-by: Ashwin Pc <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/index.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/types.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Final fixes (opensearch-project#2071)

* chore: Disable wizard by default

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove routes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove translations

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: adds license to scss files

Signed-off-by: Ashwin Pc <[email protected]>

* chore: drop hover dark mode

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Initial functional tests (opensearch-project#2070)

* fix: searchable dropdown

Signed-off-by: Ashwin Pc <[email protected]>

* fix: broken empty test

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds basic functional tests for D&D

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds CI group 13 to test workflow

Signed-off-by: Ashwin Pc <[email protected]>

* fix: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: att test to jenkinsfile

Signed-off-by: Ashwin Pc <[email protected]>

* chore: minor nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: downgrade redux-toolkit for plugin compatibility

Signed-off-by: Ashwin Pc <[email protected]>

* chore: add docker config flag

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>
Co-authored-by: Brooke <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kartik Desai <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
joshuarrrr added a commit that referenced this pull request Aug 5, 2022
…2078)

Backport PR:
#1966

Signed-off-by: Anan Zhuang <[email protected]>

Backport PR commit message:
* [Chore] Moves Drag and Drop to new branch (#1400)

* Initial Drag and Drop plugin code (#946)

* Initial Drag and Drop plugin code

Signed-off-by: Ashwin Pc <[email protected]>

* Adds state management to Drag and Drop

Signed-off-by: Ashwin Pc <[email protected]>

* Moves Drag and Drop to create visualization menu

Signed-off-by: Ashwin Pc <[email protected]>

* Field Search in Data panel  (#995)

Add ability to search on index fields
Signed-off-by: Abbas Hussain <[email protected]>

* Adds initial type service (#1260)

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates viz modal snapshot

Signed-off-by: Ashwin Pc <[email protected]>

* fix(License): Fixes license headers

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>

* [D&D] Type Service Contributions (#1402)

* feat(Contributions): Simple working contributions

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Add new field from dropbox

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working edit mode

Signed-off-by: Ashwin Pc <[email protected]>

* fix(Contributions): Fixes switching dropbox fields

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates license headers

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Adds initial drag & drop validation

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Allows multiple instances of the same field

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Working reorder fields

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working container contributions

Signed-off-by: Ashwin Pc <[email protected]>

* chore: clean up exports

Signed-off-by: Ashwin Pc <[email protected]>

* test(Contribution): Adds unit test `mergeArrays`

Signed-off-by: Ashwin Pc <[email protected]>

* test(TypeService): Adds plugin unit tests

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove redundant code

Signed-off-by: Ashwin Pc <[email protected]>

* test(Functional): Updates
Chart types

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Refactor to use AggService and introduce metric visualization (#1734)

* partial progress

Signed-off-by: Ashwin Pc <[email protected]>

* simle workign metric using aggShemas

Signed-off-by: Ashwin Pc <[email protected]>

* updated VisualizationTypeOptions to be a generic

Signed-off-by: Ashwin Pc <[email protected]>

* partially working metric style options

Signed-off-by: Ashwin Pc <[email protected]>

* all state objects are serializeable

Signed-off-by: Ashwin Pc <[email protected]>

* working delete and reorder

Signed-off-by: Ashwin Pc <[email protected]>

* chore: cleanup agg service changes

Signed-off-by: Ashwin Pc <[email protected]>

* Adds the data source selector and a useIndexPatterns hook (#1763)

Signed-off-by: Brooke Green <[email protected]>

* [D&D] Adding and editing an aggregation + metric color ranges (#1781)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* cleanup dropbox field icon

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* Updated comment

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic saved object management (#1816)

* [D&D] Enable basic saved object management

- Create README stub for saved_objects_management plugin
- Register wizard saved object loader with management plugin
- Add management methods to SavedObjectsType
- Add capabilities provider to wizard
- Add saved wizard vis SavedObjectClass and SavedObjectLoader
- Add public plugin start method

partially addresses #1620

Signed-off-by: Josh Romero <[email protected]>

* [Doc] Add clarifications to README

for save objects management plugin

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds drop validation (#1833)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* feat: Adds agg type validation and defaults on drop

Signed-off-by: Ashwin Pc <[email protected]>

* chore: refactor filter

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates D&D icon (#1844)

Signed-off-by: Ashwin Pc <[email protected]>

* Chore/remove contributions (#1843)

* adds min/max validation

Signed-off-by: Ashwin Pc <[email protected]>

* relocated contributions

Signed-off-by: Ashwin Pc <[email protected]>

* Some more cleanup

Signed-off-by: Ashwin Pc <[email protected]>

* minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* one more unnecessary file

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Seconday panel title

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates Field selector (#1845)

Signed-off-by: Ashwin Pc <[email protected]>

* Adding breadcrumbs for drag and drop creation (#1797)

Signed-off-by: Brooke Green <[email protected]>

* fix(D&D): fixes reloading app (#1855)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Dropbox style and animations (#1863)

* fix dropbox styles and added animations

Signed-off-by: Ashwin Pc <[email protected]>

* simpler usePrefersReducedMotion

Signed-off-by: Ashwin Pc <[email protected]>

* fix drop target animation

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Basic saving, loading, and updating (#1870)

* [D&D] Enable basic saving and loading

- Add `/edit` route
- Sync state for saving and loading
- Add setter for vizualization slice
- Switch from BrowserRouter to Router
- Add version to saved objects
- Add savedWizardLoader to services
- store visualization and style states separately
- add version
- update breadcrumb handling
- move useSavedWizardVis to top_nav
- handle savedObjectNotFound
- use savedObjectLoader correctly
- allow copy on save
- update url and chrome on save
- add type for WizardVisSavedObject

fixes #1867

Signed-off-by: Josh Romero <[email protected]>

* chore: Adds a few readme's (#1894)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Empty-workspace polish (#1900)

* empty workspace polish

Signed-off-by: kaddy645 <[email protected]>

* pr update

Signed-off-by: kaddy645 <[email protected]>

* pr update 2

Signed-off-by: kaddy645 <[email protected]>

* [D&D] Fix: Topnav updates aggregation parameters (#1905)

* fix(D&D): Fixes top nav query and timerange

Signed-off-by: Ashwin Pc <[email protected]>

* fix(D&D): Handles topnav state update

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (#1889)

Resolves Issue - #1877

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* fix(Workspace): Fixes illustration and copy (#1916)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Misc fixes (#1924)

* fix: minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit syntax fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: simplify useSavedWizardVis

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic embeddable panels (#1911)

- add embeddable, embeddable component, embeddable factory
- update `toExpression` to allow passing services
- register embeddable factory in plugin setup

fixes #1908

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix scss lint and available fields (#1927)

* fix(Lint): fixes scss linting issues

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Filter field types correctly

Signed-off-by: Ashwin Pc <[email protected]>

* fix: minor

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add wizard saved objects to vis list (#1933)

via appExtensions of alias registration

fixes #1887

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Feature/experimental (#1934)

* feat: experimental banner

Signed-off-by: Ashwin Pc <[email protected]>

* feat: experimental embeddable

Signed-off-by: Ashwin Pc <[email protected]>

* fix: experimental banner location

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Remove search/hasMatch embeddable vestiges (#1935)

- removedebugging rendering
- also update embeddables icon

fixes #1910, #1925

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Refactor and cleanup embeddables (#1947)

General plugin updates (#1939):
- add start service getters/setters to plugin service
- move setters from setup to start so they're available to embeddable

Embeddable updates:
- use getters instead of depending on start services in constructor
- remove wizard from add panel "create" list
- add correct edit paths/URLs for linking to wizard #1940
- add basic error embeddable rendering
- render via ExpressionLoader instead of wizard_component #1920
- wizard_component no longer used, but updated for future use
- add subscription handling for query, filter, timerange changes #1937
- fix clone/replace panel actions #1943, #1944
- fix title/description panel rendering #1921
- add inspection panel action #1936

Asset updates:
- Update empty workspace illustration
- Add secondary fill icon version to match new visualization icons

fixes #1936, #1920, #1937, #1940, #1921, #1939, #1941, #1943, #1944

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix index pattern state and loading (#1949)

Remove useIndexPattern hook in favor of useIndexPatterns

fixes #1917

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix duplicate title warning (#1950)

fixes #1918

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds autosave while editing aggregation (#1953)

* fest: Adds autosave while editing agg

Signed-off-by: Ashwin Pc <[email protected]>

* fix: autosave order

Signed-off-by: Ashwin Pc <[email protected]>

* fix: spelling

Co-authored-by: Josh Romero <[email protected]>

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Fixes autosave with debounce (#1965)

* fix: autosave editing

Signed-off-by: Ashwin Pc <[email protected]>

* chore: improve workspace animation

Signed-off-by: Ashwin Pc <[email protected]>

* fix: show invalid field when editing

Signed-off-by: Ashwin Pc <[email protected]>

* fix: header offset

Signed-off-by: Ashwin Pc <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/index.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/types.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Final fixes (#2071)

* chore: Disable wizard by default

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove routes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove translations

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: adds license to scss files

Signed-off-by: Ashwin Pc <[email protected]>

* chore: drop hover dark mode

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Initial functional tests (#2070)

* fix: searchable dropdown

Signed-off-by: Ashwin Pc <[email protected]>

* fix: broken empty test

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds basic functional tests for D&D

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds CI group 13 to test workflow

Signed-off-by: Ashwin Pc <[email protected]>

* fix: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: att test to jenkinsfile

Signed-off-by: Ashwin Pc <[email protected]>

* chore: minor nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: downgrade redux-toolkit for plugin compatibility

Signed-off-by: Ashwin Pc <[email protected]>

* chore: add docker config flag

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>
Co-authored-by: Brooke <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kartik Desai <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>

Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Abbas Hussain <[email protected]>
Co-authored-by: Brooke <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kartik Desai <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Dec 1, 2022
…pensearch-project#2078)

Backport PR:
opensearch-project#1966

Signed-off-by: Anan Zhuang <[email protected]>

Backport PR commit message:
* [Chore] Moves Drag and Drop to new branch (opensearch-project#1400)

* Initial Drag and Drop plugin code (opensearch-project#946)

* Initial Drag and Drop plugin code

Signed-off-by: Ashwin Pc <[email protected]>

* Adds state management to Drag and Drop

Signed-off-by: Ashwin Pc <[email protected]>

* Moves Drag and Drop to create visualization menu

Signed-off-by: Ashwin Pc <[email protected]>

* Field Search in Data panel  (opensearch-project#995)

Add ability to search on index fields
Signed-off-by: Abbas Hussain <[email protected]>

* Adds initial type service (opensearch-project#1260)

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates viz modal snapshot

Signed-off-by: Ashwin Pc <[email protected]>

* fix(License): Fixes license headers

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>

* [D&D] Type Service Contributions (opensearch-project#1402)

* feat(Contributions): Simple working contributions

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Add new field from dropbox

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working edit mode

Signed-off-by: Ashwin Pc <[email protected]>

* fix(Contributions): Fixes switching dropbox fields

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates license headers

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Adds initial drag & drop validation

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Allows multiple instances of the same field

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Dropbox): Working reorder fields

Signed-off-by: Ashwin Pc <[email protected]>

* feat(Contributions): Working container contributions

Signed-off-by: Ashwin Pc <[email protected]>

* chore: clean up exports

Signed-off-by: Ashwin Pc <[email protected]>

* test(Contribution): Adds unit test `mergeArrays`

Signed-off-by: Ashwin Pc <[email protected]>

* test(TypeService): Adds plugin unit tests

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove redundant code

Signed-off-by: Ashwin Pc <[email protected]>

* test(Functional): Updates
Chart types

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Refactor to use AggService and introduce metric visualization (opensearch-project#1734)

* partial progress

Signed-off-by: Ashwin Pc <[email protected]>

* simle workign metric using aggShemas

Signed-off-by: Ashwin Pc <[email protected]>

* updated VisualizationTypeOptions to be a generic

Signed-off-by: Ashwin Pc <[email protected]>

* partially working metric style options

Signed-off-by: Ashwin Pc <[email protected]>

* all state objects are serializeable

Signed-off-by: Ashwin Pc <[email protected]>

* working delete and reorder

Signed-off-by: Ashwin Pc <[email protected]>

* chore: cleanup agg service changes

Signed-off-by: Ashwin Pc <[email protected]>

* Adds the data source selector and a useIndexPatterns hook (opensearch-project#1763)

Signed-off-by: Brooke Green <[email protected]>

* [D&D] Adding and editing an aggregation + metric color ranges (opensearch-project#1781)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* cleanup dropbox field icon

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* Updated comment

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic saved object management (opensearch-project#1816)

* [D&D] Enable basic saved object management

- Create README stub for saved_objects_management plugin
- Register wizard saved object loader with management plugin
- Add management methods to SavedObjectsType
- Add capabilities provider to wizard
- Add saved wizard vis SavedObjectClass and SavedObjectLoader
- Add public plugin start method

partially addresses opensearch-project#1620

Signed-off-by: Josh Romero <[email protected]>

* [Doc] Add clarifications to README

for save objects management plugin

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds drop validation (opensearch-project#1833)

* edit and add agg works

Signed-off-by: Ashwin Pc <[email protected]>

* edit agg using draft state

Signed-off-by: Ashwin Pc <[email protected]>

* Adds other metric style props

Signed-off-by: Ashwin Pc <[email protected]>

* feat: Adds agg type validation and defaults on drop

Signed-off-by: Ashwin Pc <[email protected]>

* chore: refactor filter

Signed-off-by: Ashwin Pc <[email protected]>

* chore: updates D&D icon (opensearch-project#1844)

Signed-off-by: Ashwin Pc <[email protected]>

* Chore/remove contributions (opensearch-project#1843)

* adds min/max validation

Signed-off-by: Ashwin Pc <[email protected]>

* relocated contributions

Signed-off-by: Ashwin Pc <[email protected]>

* Some more cleanup

Signed-off-by: Ashwin Pc <[email protected]>

* minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* one more unnecessary file

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Seconday panel title

Signed-off-by: Ashwin Pc <[email protected]>

* chore: Updates Field selector (opensearch-project#1845)

Signed-off-by: Ashwin Pc <[email protected]>

* Adding breadcrumbs for drag and drop creation (opensearch-project#1797)

Signed-off-by: Brooke Green <[email protected]>

* fix(D&D): fixes reloading app (opensearch-project#1855)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Dropbox style and animations (opensearch-project#1863)

* fix dropbox styles and added animations

Signed-off-by: Ashwin Pc <[email protected]>

* simpler usePrefersReducedMotion

Signed-off-by: Ashwin Pc <[email protected]>

* fix drop target animation

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Basic saving, loading, and updating (opensearch-project#1870)

* [D&D] Enable basic saving and loading

- Add `/edit` route
- Sync state for saving and loading
- Add setter for vizualization slice
- Switch from BrowserRouter to Router
- Add version to saved objects
- Add savedWizardLoader to services
- store visualization and style states separately
- add version
- update breadcrumb handling
- move useSavedWizardVis to top_nav
- handle savedObjectNotFound
- use savedObjectLoader correctly
- allow copy on save
- update url and chrome on save
- add type for WizardVisSavedObject

fixes opensearch-project#1867

Signed-off-by: Josh Romero <[email protected]>

* chore: Adds a few readme's (opensearch-project#1894)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Empty-workspace polish (opensearch-project#1900)

* empty workspace polish

Signed-off-by: kaddy645 <[email protected]>

* pr update

Signed-off-by: kaddy645 <[email protected]>

* pr update 2

Signed-off-by: kaddy645 <[email protected]>

* [D&D] Fix: Topnav updates aggregation parameters (opensearch-project#1905)

* fix(D&D): Fixes top nav query and timerange

Signed-off-by: Ashwin Pc <[email protected]>

* fix(D&D): Handles topnav state update

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (opensearch-project#1889)

Resolves Issue - opensearch-project#1877

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* fix(Workspace): Fixes illustration and copy (opensearch-project#1916)

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Misc fixes (opensearch-project#1924)

* fix: minor fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit syntax fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: simplify useSavedWizardVis

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Enable basic embeddable panels (opensearch-project#1911)

- add embeddable, embeddable component, embeddable factory
- update `toExpression` to allow passing services
- register embeddable factory in plugin setup

fixes opensearch-project#1908

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix scss lint and available fields (opensearch-project#1927)

* fix(Lint): fixes scss linting issues

Signed-off-by: Ashwin Pc <[email protected]>

* fix: Filter field types correctly

Signed-off-by: Ashwin Pc <[email protected]>

* fix: minor

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Add wizard saved objects to vis list (opensearch-project#1933)

via appExtensions of alias registration

fixes opensearch-project#1887

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Feature/experimental (opensearch-project#1934)

* feat: experimental banner

Signed-off-by: Ashwin Pc <[email protected]>

* feat: experimental embeddable

Signed-off-by: Ashwin Pc <[email protected]>

* fix: experimental banner location

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Remove search/hasMatch embeddable vestiges (opensearch-project#1935)

- removedebugging rendering
- also update embeddables icon

fixes opensearch-project#1910, opensearch-project#1925

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Refactor and cleanup embeddables (opensearch-project#1947)

General plugin updates (opensearch-project#1939):
- add start service getters/setters to plugin service
- move setters from setup to start so they're available to embeddable

Embeddable updates:
- use getters instead of depending on start services in constructor
- remove wizard from add panel "create" list
- add correct edit paths/URLs for linking to wizard opensearch-project#1940
- add basic error embeddable rendering
- render via ExpressionLoader instead of wizard_component opensearch-project#1920
- wizard_component no longer used, but updated for future use
- add subscription handling for query, filter, timerange changes opensearch-project#1937
- fix clone/replace panel actions opensearch-project#1943, opensearch-project#1944
- fix title/description panel rendering opensearch-project#1921
- add inspection panel action opensearch-project#1936

Asset updates:
- Update empty workspace illustration
- Add secondary fill icon version to match new visualization icons

fixes opensearch-project#1936, opensearch-project#1920, opensearch-project#1937, opensearch-project#1940, opensearch-project#1921, opensearch-project#1939, opensearch-project#1941, opensearch-project#1943, opensearch-project#1944

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix index pattern state and loading (opensearch-project#1949)

Remove useIndexPattern hook in favor of useIndexPatterns

fixes opensearch-project#1917

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Fix duplicate title warning (opensearch-project#1950)

fixes opensearch-project#1918

Signed-off-by: Josh Romero <[email protected]>

* [D&D] Adds autosave while editing aggregation (opensearch-project#1953)

* fest: Adds autosave while editing agg

Signed-off-by: Ashwin Pc <[email protected]>

* fix: autosave order

Signed-off-by: Ashwin Pc <[email protected]>

* fix: spelling

Co-authored-by: Josh Romero <[email protected]>

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Fixes autosave with debounce (opensearch-project#1965)

* fix: autosave editing

Signed-off-by: Ashwin Pc <[email protected]>

* chore: improve workspace animation

Signed-off-by: Ashwin Pc <[email protected]>

* fix: show invalid field when editing

Signed-off-by: Ashwin Pc <[email protected]>

* fix: header offset

Signed-off-by: Ashwin Pc <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/index.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/server/types.ts

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/wizard/README.md

Co-authored-by: Josh Romero <[email protected]>

* Update src/plugins/saved_objects_management/README.md

Co-authored-by: Josh Romero <[email protected]>

* [D&D] Final fixes (opensearch-project#2071)

* chore: Disable wizard by default

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove routes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: remove translations

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: adds license to scss files

Signed-off-by: Ashwin Pc <[email protected]>

* chore: drop hover dark mode

Signed-off-by: Ashwin Pc <[email protected]>

* chore: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* [D&D] Initial functional tests (opensearch-project#2070)

* fix: searchable dropdown

Signed-off-by: Ashwin Pc <[email protected]>

* fix: broken empty test

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds basic functional tests for D&D

Signed-off-by: Ashwin Pc <[email protected]>

* test(FTR): Adds CI group 13 to test workflow

Signed-off-by: Ashwin Pc <[email protected]>

* fix: nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: att test to jenkinsfile

Signed-off-by: Ashwin Pc <[email protected]>

* chore: minor nit fixes

Signed-off-by: Ashwin Pc <[email protected]>

* chore: downgrade redux-toolkit for plugin compatibility

Signed-off-by: Ashwin Pc <[email protected]>

* chore: add docker config flag

Signed-off-by: Ashwin Pc <[email protected]>

Co-authored-by: Abbas Hussain <[email protected]>
Co-authored-by: Brooke <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kartik Desai <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>

Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Abbas Hussain <[email protected]>
Co-authored-by: Brooke <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kartik Desai <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
@joshuarrrr joshuarrrr deleted the feature/d-and-d branch August 8, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants