Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue on saving custom vector map options as part of visualization #1896

Conversation

Shivamdhar
Copy link
Contributor

Signed-off-by: Shivam Dhar [email protected]

Description

Modifies region map rendering logic to show saved visualizations correctly.

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@Shivamdhar Shivamdhar requested a review from a team as a code owner July 14, 2022 00:26
@codecov-commenter
Copy link

Codecov Report

Merging #1896 (8c8964e) into main (c33bf8c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
- Coverage   67.49%   67.48%   -0.02%     
==========================================
  Files        3076     3076              
  Lines       59144    59144              
  Branches     8989     8989              
==========================================
- Hits        39921    39915       -6     
- Misses      17040    17044       +4     
- Partials     2183     2185       +2     
Impacted Files Coverage Δ
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-2.78%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33bf8c...8c8964e. Read the comment docs.

@kavilla
Copy link
Member

kavilla commented Jul 15, 2022

Hello @Shivamdhar can you help provide insight what was the issue?

@junqiu-lei junqiu-lei merged commit 6dfe116 into opensearch-project:main Jul 15, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1896-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6dfe116e3a478a1bf4df736485a24cd8372f09fc
# Push it to GitHub
git push --set-upstream origin backport/backport-1896-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1896-to-2.x.

@Shivamdhar
Copy link
Contributor Author

Hello @Shivamdhar can you help provide insight what was the issue?

Sure @kavilla , as part of custom geoJSON feature - when custom vector map and join fields were selected by user and the visualization was saved, there was an issue with rendering of the saved visualization (as the inspector tool in the saved objects tab showed correct object properties). By default, the saved visualization pulled the first vector map and first join field in the list (which wasn't the correct behavior).

Screen Shot 2022-07-15 at 10 11 37 AM

This PR helps in fixing the rendering issue of saved object in region map component.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2022
…ion (#1896)

Signed-off-by: Shivam Dhar <[email protected]>
(cherry picked from commit 6dfe116)
kavilla added a commit that referenced this pull request Jul 27, 2022
…ion (#1896) (#1942)

Signed-off-by: Shivam Dhar <[email protected]>
(cherry picked from commit 6dfe116)

Co-authored-by: Shivam Dhar <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
CPTNB pushed a commit to CPTNB/OpenSearch-Dashboards that referenced this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants