-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue on saving custom vector map options as part of visualization #1896
Fixes issue on saving custom vector map options as part of visualization #1896
Conversation
Signed-off-by: Shivam Dhar <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1896 +/- ##
==========================================
- Coverage 67.49% 67.48% -0.02%
==========================================
Files 3076 3076
Lines 59144 59144
Branches 8989 8989
==========================================
- Hits 39921 39915 -6
- Misses 17040 17044 +4
- Partials 2183 2185 +2
Continue to review full report at Codecov.
|
Hello @Shivamdhar can you help provide insight what was the issue? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1896-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6dfe116e3a478a1bf4df736485a24cd8372f09fc
# Push it to GitHub
git push --set-upstream origin backport/backport-1896-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Sure @kavilla , as part of custom geoJSON feature - when custom vector map and join fields were selected by user and the visualization was saved, there was an issue with rendering of the saved visualization (as the inspector tool in the saved objects tab showed correct object properties). By default, the saved visualization pulled the first vector map and first join field in the list (which wasn't the correct behavior). This PR helps in fixing the rendering issue of saved object in region map component. |
…ion (#1896) Signed-off-by: Shivam Dhar <[email protected]> (cherry picked from commit 6dfe116)
…ion (#1896) (#1942) Signed-off-by: Shivam Dhar <[email protected]> (cherry picked from commit 6dfe116) Co-authored-by: Shivam Dhar <[email protected]> Co-authored-by: Kawika Avilla <[email protected]>
…ion (opensearch-project#1896) Signed-off-by: Shivam Dhar <[email protected]>
Signed-off-by: Shivam Dhar [email protected]
Description
Modifies region map rendering logic to show saved visualizations correctly.
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr